| Message ID | 88c83ce7-5d1a-44a8-b9bf-0d01cfea24db@kili.mountain (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | iommu/mediatek: fix a reversed test in probe | expand |
On Sat, 2023-03-25 at 14:07 +0300, Dan Carpenter wrote: > > The dma_set_mask() function returns negative error codes on failure > but > this code is testing for zero instead. > > Fixes: f4b49c7c5e67 ("iommu/mediatek: Set dma_mask for > PGTABLE_PA_35_EN") > Signed-off-by: Dan Carpenter <error27@gmail.com> Reviewed-by: Yong Wu <yong.wu@mediatek.com> Thanks for the help. > --- > drivers/iommu/mtk_iommu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c > index 1a75b4382a92..6a00ce208dc2 100644 > --- a/drivers/iommu/mtk_iommu.c > +++ b/drivers/iommu/mtk_iommu.c > @@ -1260,7 +1260,7 @@ static int mtk_iommu_probe(struct > platform_device *pdev) > > if (MTK_IOMMU_HAS_FLAG(data->plat_data, PGTABLE_PA_35_EN)) { > ret = dma_set_mask(dev, DMA_BIT_MASK(35)); > - if (!ret) { > + if (ret) { > dev_err(dev, "Failed to set dma_mask 35.\n"); > return ret; > } > -- > 2.39.1 >
Il 25/03/23 12:07, Dan Carpenter ha scritto: > The dma_set_mask() function returns negative error codes on failure but > this code is testing for zero instead. > > Fixes: f4b49c7c5e67 ("iommu/mediatek: Set dma_mask for PGTABLE_PA_35_EN") > Signed-off-by: Dan Carpenter <error27@gmail.com> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
On Sat, Mar 25, 2023 at 02:07:52PM +0300, Dan Carpenter wrote: > The dma_set_mask() function returns negative error codes on failure but > this code is testing for zero instead. > > Fixes: f4b49c7c5e67 ("iommu/mediatek: Set dma_mask for PGTABLE_PA_35_EN") > Signed-off-by: Dan Carpenter <error27@gmail.com> > --- > drivers/iommu/mtk_iommu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks for the fix, but I replaced above commit with v3, which I overlooked when applying it. The v3 post has this already fixed. Regards, Joerg
diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c index 1a75b4382a92..6a00ce208dc2 100644 --- a/drivers/iommu/mtk_iommu.c +++ b/drivers/iommu/mtk_iommu.c @@ -1260,7 +1260,7 @@ static int mtk_iommu_probe(struct platform_device *pdev) if (MTK_IOMMU_HAS_FLAG(data->plat_data, PGTABLE_PA_35_EN)) { ret = dma_set_mask(dev, DMA_BIT_MASK(35)); - if (!ret) { + if (ret) { dev_err(dev, "Failed to set dma_mask 35.\n"); return ret; }
The dma_set_mask() function returns negative error codes on failure but this code is testing for zero instead. Fixes: f4b49c7c5e67 ("iommu/mediatek: Set dma_mask for PGTABLE_PA_35_EN") Signed-off-by: Dan Carpenter <error27@gmail.com> --- drivers/iommu/mtk_iommu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)