| Message ID | 20230326143224.572654-73-u.kleine-koenig@pengutronix.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | None | expand |
Hi Uwe, W dniu 26.03.2023 o 16:31, Uwe Kleine-König pisze: > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is (mostly) ignored > and this typically results in resource leaks. To improve here there is a > quest to make the remove callback return void. In the first step of this > quest all drivers are converted to .remove_new() which already returns > void. > > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Acked-by: Andrzej Pietrasiewicz <andrzejtp2010@gmail.com> > --- > drivers/media/platform/samsung/s5p-jpeg/jpeg-core.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/media/platform/samsung/s5p-jpeg/jpeg-core.c b/drivers/media/platform/samsung/s5p-jpeg/jpeg-core.c > index 55814041b8d8..c3c7e48f1b6e 100644 > --- a/drivers/media/platform/samsung/s5p-jpeg/jpeg-core.c > +++ b/drivers/media/platform/samsung/s5p-jpeg/jpeg-core.c > @@ -2991,7 +2991,7 @@ static int s5p_jpeg_probe(struct platform_device *pdev) > return ret; > } > > -static int s5p_jpeg_remove(struct platform_device *pdev) > +static void s5p_jpeg_remove(struct platform_device *pdev) > { > struct s5p_jpeg *jpeg = platform_get_drvdata(pdev); > int i; > @@ -3008,8 +3008,6 @@ static int s5p_jpeg_remove(struct platform_device *pdev) > for (i = jpeg->variant->num_clocks - 1; i >= 0; i--) > clk_disable_unprepare(jpeg->clocks[i]); > } > - > - return 0; > } > > #ifdef CONFIG_PM > @@ -3164,7 +3162,7 @@ static void *jpeg_get_drv_data(struct device *dev) > > static struct platform_driver s5p_jpeg_driver = { > .probe = s5p_jpeg_probe, > - .remove = s5p_jpeg_remove, > + .remove_new = s5p_jpeg_remove, > .driver = { > .of_match_table = of_match_ptr(samsung_jpeg_match), > .name = S5P_JPEG_M2M_NAME,
diff --git a/drivers/media/platform/samsung/s5p-jpeg/jpeg-core.c b/drivers/media/platform/samsung/s5p-jpeg/jpeg-core.c index 55814041b8d8..c3c7e48f1b6e 100644 --- a/drivers/media/platform/samsung/s5p-jpeg/jpeg-core.c +++ b/drivers/media/platform/samsung/s5p-jpeg/jpeg-core.c @@ -2991,7 +2991,7 @@ static int s5p_jpeg_probe(struct platform_device *pdev) return ret; } -static int s5p_jpeg_remove(struct platform_device *pdev) +static void s5p_jpeg_remove(struct platform_device *pdev) { struct s5p_jpeg *jpeg = platform_get_drvdata(pdev); int i; @@ -3008,8 +3008,6 @@ static int s5p_jpeg_remove(struct platform_device *pdev) for (i = jpeg->variant->num_clocks - 1; i >= 0; i--) clk_disable_unprepare(jpeg->clocks[i]); } - - return 0; } #ifdef CONFIG_PM @@ -3164,7 +3162,7 @@ static void *jpeg_get_drv_data(struct device *dev) static struct platform_driver s5p_jpeg_driver = { .probe = s5p_jpeg_probe, - .remove = s5p_jpeg_remove, + .remove_new = s5p_jpeg_remove, .driver = { .of_match_table = of_match_ptr(samsung_jpeg_match), .name = S5P_JPEG_M2M_NAME,
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- drivers/media/platform/samsung/s5p-jpeg/jpeg-core.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)