diff mbox series

[v1,1/1] device property: Remove unused struct net_device forward declaration

Message ID 20230323151519.58479-1-andriy.shevchenko@linux.intel.com (mailing list archive)
State Handled Elsewhere, archived
Headers show
Series [v1,1/1] device property: Remove unused struct net_device forward declaration | expand

Commit Message

Andy Shevchenko March 23, 2023, 3:15 p.m. UTC
There is no users in the property.h for the struct net_device.
Remove the latter for good.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 include/linux/property.h | 1 -
 1 file changed, 1 deletion(-)

Comments

Andy Shevchenko March 27, 2023, 10:11 a.m. UTC | #1
On Thu, Mar 23, 2023 at 05:15:19PM +0200, Andy Shevchenko wrote:
> There is no users in the property.h for the struct net_device.
> Remove the latter for good.

Oh, this seems unfortunate as it doesn't Cc Greg. Folks, shall we add
the header to "DRIVER CORE, KOBJECTS, DEBUGFS AND SYSFS"?

> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  include/linux/property.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/include/linux/property.h b/include/linux/property.h
> index ee9cc1710d82..1dff38e930fc 100644
> --- a/include/linux/property.h
> +++ b/include/linux/property.h
> @@ -16,7 +16,6 @@
>  #include <linux/types.h>
>  
>  struct device;
> -struct net_device;
>  
>  enum dev_prop_type {
>  	DEV_PROP_U8,
Greg Kroah-Hartman March 27, 2023, 11:48 a.m. UTC | #2
On Mon, Mar 27, 2023 at 01:11:20PM +0300, Andy Shevchenko wrote:
> On Thu, Mar 23, 2023 at 05:15:19PM +0200, Andy Shevchenko wrote:
> > There is no users in the property.h for the struct net_device.
> > Remove the latter for good.
> 
> Oh, this seems unfortunate as it doesn't Cc Greg. Folks, shall we add
> the header to "DRIVER CORE, KOBJECTS, DEBUGFS AND SYSFS"?

Yes please.
Andy Shevchenko March 27, 2023, 1:02 p.m. UTC | #3
On Mon, Mar 27, 2023 at 01:48:21PM +0200, Greg Kroah-Hartman wrote:
> On Mon, Mar 27, 2023 at 01:11:20PM +0300, Andy Shevchenko wrote:
> > On Thu, Mar 23, 2023 at 05:15:19PM +0200, Andy Shevchenko wrote:
> > > There is no users in the property.h for the struct net_device.
> > > Remove the latter for good.
> > 
> > Oh, this seems unfortunate as it doesn't Cc Greg. Folks, shall we add
> > the header to "DRIVER CORE, KOBJECTS, DEBUGFS AND SYSFS"?
> 
> Yes please.

Done as v2 with this patch also resent there.
diff mbox series

Patch

diff --git a/include/linux/property.h b/include/linux/property.h
index ee9cc1710d82..1dff38e930fc 100644
--- a/include/linux/property.h
+++ b/include/linux/property.h
@@ -16,7 +16,6 @@ 
 #include <linux/types.h>
 
 struct device;
-struct net_device;
 
 enum dev_prop_type {
 	DEV_PROP_U8,