| Message ID | 20230326140818.246575-1-arinc.unal@arinc9.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | net: dsa: mt7530: fix port 5 phylink, phy muxing, and port 6 | expand |
On Sun, Mar 26, 2023 at 05:08:11PM +0300, arinc9.unal@gmail.com wrote: > Hello! > > This patch series is mainly focused on fixing the support for port 5 and > setting up port 6. > > The only missing piece to properly support port 5 as a CPU port is the > fixes [0] [1] [2] from Richard. > > Russell, looking forward to your review regarding phylink. > > I have very thoroughly tested the patch series with every possible mode to > use. I'll let the name of the dtb files speak for themselves. This patch needs to be resubmitted (potentially as RFC) to the net-next tree, and the commits readjusted to clarify what are fixes and what is pure refactoring. With the mentioned that I have not reviewed the entire series and I will not do that, either.
On 28/03/2023 14:21, Vladimir Oltean wrote: > On Sun, Mar 26, 2023 at 05:08:11PM +0300, arinc9.unal@gmail.com wrote: >> Hello! >> >> This patch series is mainly focused on fixing the support for port 5 and >> setting up port 6. >> >> The only missing piece to properly support port 5 as a CPU port is the >> fixes [0] [1] [2] from Richard. >> >> Russell, looking forward to your review regarding phylink. >> >> I have very thoroughly tested the patch series with every possible mode to >> use. I'll let the name of the dtb files speak for themselves. > > This patch needs to be resubmitted (potentially as RFC) to the net-next > tree, and the commits readjusted to clarify what are fixes and what is > pure refactoring. With the mentioned that I have not reviewed the entire > series and I will not do that, either. Makes sense, will do. Arınç
Hello! This patch series is mainly focused on fixing the support for port 5 and setting up port 6. The only missing piece to properly support port 5 as a CPU port is the fixes [0] [1] [2] from Richard. Russell, looking forward to your review regarding phylink. I have very thoroughly tested the patch series with every possible mode to use. I'll let the name of the dtb files speak for themselves. MT7621 Unielec: only-gmac0-mt7621-unielec-u7621-06-16m.dtb rgmii-only-gmac0-mt7621-unielec-u7621-06-16m.dtb only-gmac1-mt7621-unielec-u7621-06-16m.dtb gmac0-and-gmac1-mt7621-unielec-u7621-06-16m.dtb phy0-muxing-mt7621-unielec-u7621-06-16m.dtb phy4-muxing-mt7621-unielec-u7621-06-16m.dtb port5-as-user-mt7621-unielec-u7621-06-16m.dtb tftpboot 0x80008000 mips-uzImage.bin; tftpboot 0x83000000 mips-rootfs.cpio.uboot; tftpboot 0x83f00000 $dtb; bootm 0x80008000 0x83000000 0x83f00000 MT7623 Bananapi: only-gmac0-mt7623n-bananapi-bpi-r2.dtb rgmii-only-gmac0-mt7623n-bananapi-bpi-r2.dtb only-gmac1-mt7623n-bananapi-bpi-r2.dtb gmac0-and-gmac1-mt7623n-bananapi-bpi-r2.dtb phy0-muxing-mt7623n-bananapi-bpi-r2.dtb phy4-muxing-mt7623n-bananapi-bpi-r2.dtb port5-as-user-mt7623n-bananapi-bpi-r2.dtb tftpboot 0x80008000 arm-uImage; tftpboot 0x83000000 arm-rootfs.cpio.uboot; tftpboot 0x83f00000 $dtb; bootm 0x80008000 0x83000000 0x83f00000 Current CPU ports setup of MT7530: mt7530_setup() -> mt7530_setup_port5() mt753x_phylink_mac_config() -> mt753x_mac_config() -> mt7530_mac_config() -> mt7530_setup_port5() -> mt753x_pad_setup() -> mt7530_pad_clk_setup() sets up port 6, rename to mt7530_setup_port6() How it will be with the patch series: mt7530_setup() -> mt7530_setup_port5() runs if the port is not used as a CPU or user port mt753x_phylink_mac_config() -> mt753x_mac_config() -> mt7530_mac_config() -> mt7530_setup_port5() -> mt7530_setup_port6() CPU ports setup of MT7531 for reference: mt7531_setup() -> mt753x_cpu_port_enable() -> mt7531_cpu_port_config() -> mt7531_mac_config() -> mt7531_rgmii_setup() -> mt7531_sgmii_setup_mode_an() -> etc. mt753x_phylink_mac_config() -> mt753x_mac_config() -> mt7531_mac_config() -> mt7531_rgmii_setup() -> mt7531_sgmii_setup_mode_an() -> etc. [0] https://lore.kernel.org/netdev/20230212213949.672443-1-richard@routerhints.com/ [1] https://lore.kernel.org/netdev/20230212215152.673221-1-richard@routerhints.com/ [2] https://lore.kernel.org/netdev/20230212214027.672501-1-richard@routerhints.com/ Arınç Arınç ÜNAL (7): net: dsa: mt7530: fix comments regarding port 5 and 6 for both switches net: dsa: mt7530: fix phylink for port 5 and fix port 5 modes net: dsa: mt7530: do not run mt7530_setup_port5() if port 5 is disabled net: dsa: mt7530: set both CPU port interfaces to PHY_INTERFACE_MODE_NA net: dsa: mt7530: set up port 5 before CPU ports are enabled net: dsa: mt7530: call port 6 setup from mt7530_mac_config() net: dsa: mt7530: remove pad_setup function pointer drivers/net/dsa/mt7530.c | 154 +++++++++++++++++++----------------------- drivers/net/dsa/mt7530.h | 3 - 2 files changed, 70 insertions(+), 87 deletions(-)