| Message ID | 251aa2a2-913e-4868-aac9-0a90fc3eeeda@kili.mountain (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 765f3604641e1524389e1d6431974d2bbcab14a7 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] octeon_ep: unlock the correct lock on error path | expand |
On Wed, Mar 29, 2023 at 09:51:37AM +0300, Dan Carpenter wrote: > The h and the f letters are swapped so it unlocks the wrong lock. > > Fixes: 577f0d1b1c5f ("octeon_ep: add separate mailbox command and response queues") > Signed-off-by: Dan Carpenter <error27@gmail.com> > --- > Thees vairable nmaes are terirble. The huamn mnid deos not raed ervey > lteter by istlef, but the wrod as a wlohe. > > https://www.dictionary.com/e/typoglycemia/ > > drivers/net/ethernet/marvell/octeon_ep/octep_ctrl_mbox.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Thanks, Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Wed, 29 Mar 2023 09:51:37 +0300 you wrote: > The h and the f letters are swapped so it unlocks the wrong lock. > > Fixes: 577f0d1b1c5f ("octeon_ep: add separate mailbox command and response queues") > Signed-off-by: Dan Carpenter <error27@gmail.com> > --- > Thees vairable nmaes are terirble. The huamn mnid deos not raed ervey > lteter by istlef, but the wrod as a wlohe. > > [...] Here is the summary with links: - [net-next] octeon_ep: unlock the correct lock on error path https://git.kernel.org/netdev/net-next/c/765f3604641e You are awesome, thank you!
diff --git a/drivers/net/ethernet/marvell/octeon_ep/octep_ctrl_mbox.c b/drivers/net/ethernet/marvell/octeon_ep/octep_ctrl_mbox.c index a4ee6f3ae354..035ead7935c7 100644 --- a/drivers/net/ethernet/marvell/octeon_ep/octep_ctrl_mbox.c +++ b/drivers/net/ethernet/marvell/octeon_ep/octep_ctrl_mbox.c @@ -167,7 +167,7 @@ int octep_ctrl_mbox_send(struct octep_ctrl_mbox *mbox, struct octep_ctrl_mbox_ms ci = readl(q->hw_cons); if (octep_ctrl_mbox_circq_space(pi, ci, q->sz) < (msg->hdr.s.sz + mbox_hdr_sz)) { - mutex_unlock(&mbox->f2hq_lock); + mutex_unlock(&mbox->h2fq_lock); return -EAGAIN; }
The h and the f letters are swapped so it unlocks the wrong lock. Fixes: 577f0d1b1c5f ("octeon_ep: add separate mailbox command and response queues") Signed-off-by: Dan Carpenter <error27@gmail.com> --- Thees vairable nmaes are terirble. The huamn mnid deos not raed ervey lteter by istlef, but the wrod as a wlohe. https://www.dictionary.com/e/typoglycemia/ drivers/net/ethernet/marvell/octeon_ep/octep_ctrl_mbox.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)