[v2] Bluetooth: btintel: Add LE States quirk support for Intel's new generation controllers

Commit Message

Chethan T N March 21, 2023, 4:33 a.m. UTC

Basically all Intel controllers support both Central/Peripheral
LE states.

This patch enables the LE States quirk by default on all
Solar and Magnertor Intel controllers.

Signed-off-by: Chethan T N <[e-mail]>
---
 drivers/bluetooth/btintel.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

Comments

[e-mail] March 21, 2023, 5:01 a.m. UTC | #1

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=732171

---Test result---

Test Summary:
CheckPatch                    PASS      0.66 seconds
GitLint                       FAIL      0.62 seconds
SubjectPrefix                 PASS      0.10 seconds
BuildKernel                   PASS      34.89 seconds
CheckAllWarning               PASS      38.73 seconds
CheckSparse                   PASS      42.81 seconds
CheckSmatch                   PASS      115.16 seconds
BuildKernel32                 PASS      34.09 seconds
TestRunnerSetup               PASS      509.89 seconds
TestRunner_l2cap-tester       PASS      19.29 seconds
TestRunner_iso-tester         PASS      20.80 seconds
TestRunner_bnep-tester        PASS      6.50 seconds
TestRunner_mgmt-tester        PASS      130.52 seconds
TestRunner_rfcomm-tester      PASS      10.26 seconds
TestRunner_sco-tester         PASS      9.57 seconds
TestRunner_ioctl-tester       PASS      11.71 seconds
TestRunner_mesh-tester        PASS      8.51 seconds
TestRunner_smp-tester         PASS      9.45 seconds
TestRunner_userchan-tester    PASS      6.98 seconds
IncrementalBuild              PASS      34.50 seconds

Details
##############################
Test: GitLint - FAIL
Desc: Run gitlint
Output:
[v2] Bluetooth: btintel: Add LE States quirk support for Intel's new generation controllers

WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search
1: T1 Title exceeds max length (91>80): "[v2] Bluetooth: btintel: Add LE States quirk support for Intel's new generation controllers"


---
Regards,
Linux Bluetooth

[e-mail] March 29, 2023, 7:50 p.m. UTC | #2

Hello:

This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <[e-mail]>:

On Tue, 21 Mar 2023 10:03:10 +0530 you wrote:
> Basically all Intel controllers support both Central/Peripheral
> LE states.
> 
> This patch enables the LE States quirk by default on all
> Solar and Magnertor Intel controllers.
> 
> Signed-off-by: Chethan T N <[e-mail]>
> 
> [...]

Here is the summary with links:
  - [v2] Bluetooth: btintel: Add LE States quirk support for Intel's new generation controllers
    https://git.kernel.org/bluetooth/bluetooth-next/c/5b23f8375a36

You are awesome, thank you!

Patch

diff --git a/drivers/bluetooth/btintel.c b/drivers/bluetooth/btintel.c
index af774688f1c0..7a6dc05553f1 100644
--- a/drivers/bluetooth/btintel.c
+++ b/drivers/bluetooth/btintel.c
@@ -2684,9 +2684,8 @@  static int btintel_setup_combined(struct hci_dev *hdev)
 		 */
 		set_bit(HCI_QUIRK_WIDEBAND_SPEECH_SUPPORTED, &hdev->quirks);
 
-		/* Valid LE States quirk for GfP */
-		if (INTEL_HW_VARIANT(ver_tlv.cnvi_bt) == 0x18)
-			set_bit(HCI_QUIRK_VALID_LE_STATES, &hdev->quirks);
+		/* Apply LE States quirk from solar onwards */
+		set_bit(HCI_QUIRK_VALID_LE_STATES, &hdev->quirks);
 
 		/* Setup MSFT Extension support */
 		btintel_set_msft_opcode(hdev,