| Message ID | 20230329-acpi-header-cleanup-v1-1-8dc5cd3c610e@kernel.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Remove acpi.h implicit include of of.h | expand |
| Context | Check | Description |
|---|---|---|
| netdev/series_format | success | Posting correctly formatted |
| netdev/tree_selection | success | Guessed tree name to be net-next |
| netdev/fixes_present | success | Fixes tag not required for -next series |
| netdev/header_inline | success | No static functions without inline keyword in header files |
| netdev/build_32bit | success | Errors and warnings before: 18 this patch: 18 |
| netdev/cc_maintainers | success | CCed 5 of 5 maintainers |
| netdev/build_clang | success | Errors and warnings before: 18 this patch: 18 |
| netdev/verify_signedoff | success | Signed-off-by tag matches author and committer |
| netdev/deprecated_api | success | None detected |
| netdev/check_selftest | success | No net selftest shell script |
| netdev/verify_fixes | success | No Fixes tag |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 18 this patch: 18 |
| netdev/checkpatch | warning | WARNING: Possible repeated word: 'of' |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/source_inline | success | Was 0 now: 0 |
On 03/29, Rob Herring wrote: > With linux/acpi.h no longer implicitly including of.h, add an explicit > include of of.h to fix the following error: > > drivers/iio/adc/ad7292.c:307:9: error: implicit declaration of function 'for_each_available_child_of_node'; did you mean 'fwnode_for_each_available_child_node'? [-Werror=implicit-function-declaration] > > Signed-off-by: Rob Herring <robh@kernel.org> Acked-by: Marcelo Schmitt <marcelo.schmitt1@gmail.com> Thanks, Marcelo > --- > drivers/iio/adc/ad7292.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/iio/adc/ad7292.c b/drivers/iio/adc/ad7292.c > index a2f9fda25ff3..cccacec5db6d 100644 > --- a/drivers/iio/adc/ad7292.c > +++ b/drivers/iio/adc/ad7292.c > @@ -8,6 +8,7 @@ > #include <linux/bitfield.h> > #include <linux/device.h> > #include <linux/module.h> > +#include <linux/of.h> > #include <linux/regulator/consumer.h> > #include <linux/spi/spi.h> > > > -- > 2.39.2 >
On Wed, 29 Mar 2023 22:10:55 -0300 Marcelo Schmitt <marcelo.schmitt1@gmail.com> wrote: > On 03/29, Rob Herring wrote: > > With linux/acpi.h no longer implicitly including of.h, add an explicit > > include of of.h to fix the following error: > > > > drivers/iio/adc/ad7292.c:307:9: error: implicit declaration of function 'for_each_available_child_of_node'; did you mean 'fwnode_for_each_available_child_node'? [-Werror=implicit-function-declaration] > > > > Signed-off-by: Rob Herring <robh@kernel.org> > > Acked-by: Marcelo Schmitt <marcelo.schmitt1@gmail.com> Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > Thanks, > Marcelo > > > --- > > drivers/iio/adc/ad7292.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/iio/adc/ad7292.c b/drivers/iio/adc/ad7292.c > > index a2f9fda25ff3..cccacec5db6d 100644 > > --- a/drivers/iio/adc/ad7292.c > > +++ b/drivers/iio/adc/ad7292.c > > @@ -8,6 +8,7 @@ > > #include <linux/bitfield.h> > > #include <linux/device.h> > > #include <linux/module.h> > > +#include <linux/of.h> > > #include <linux/regulator/consumer.h> > > #include <linux/spi/spi.h> > > > > > > -- > > 2.39.2 > >
diff --git a/drivers/iio/adc/ad7292.c b/drivers/iio/adc/ad7292.c index a2f9fda25ff3..cccacec5db6d 100644 --- a/drivers/iio/adc/ad7292.c +++ b/drivers/iio/adc/ad7292.c @@ -8,6 +8,7 @@ #include <linux/bitfield.h> #include <linux/device.h> #include <linux/module.h> +#include <linux/of.h> #include <linux/regulator/consumer.h> #include <linux/spi/spi.h>
With linux/acpi.h no longer implicitly including of.h, add an explicit include of of.h to fix the following error: drivers/iio/adc/ad7292.c:307:9: error: implicit declaration of function 'for_each_available_child_of_node'; did you mean 'fwnode_for_each_available_child_node'? [-Werror=implicit-function-declaration] Signed-off-by: Rob Herring <robh@kernel.org> --- drivers/iio/adc/ad7292.c | 1 + 1 file changed, 1 insertion(+)