[blktests,v3,0/4] Test different queue types

Message

Daniel Wagner March 29, 2023, 9:01 a.m. UTC

Setup different queues, e.g. read and poll queues.

As discussed I introduced a _require_nvme_trtype() function to limit the test to
tcp and rdma. I've upated the existing _require_nvme_type_is_*() checks to
explicit transport checks.

Test run against current nvme-6.4 but it still needs patch #3 from [1] to
survive.

[1] https://lore.kernel.org/linux-nvme/[e-mail]/

changes:
 v3:
   - added _require_nvme_trtype() 
   - updated test requirement checks
   - replaced double shift instructions with 'shift 2'
   - updated license type
   - added FAIL checks
 v2:
   - make most arguements optional for _nvme_connect_subsys
   - move variable decleration at the beging of _nvme_connect_subsy
 v1:
   - initial version

Daniel Wagner (4):
  nvme/rc: Parse optional arguments in _nvme_connect_subsys()
  nvme/rc: Add nr queue parser arguments to _nvme_connect_subsys()
  nvme/rc: Add parametric transport required check
  nvme/047: Test different queue types for fabrics transports

 tests/nvme/041     |   7 ++-
 tests/nvme/042     |  10 +++--
 tests/nvme/043     |  10 +++--
 tests/nvme/044     |  23 ++++++----
 tests/nvme/045     |   6 ++-
 tests/nvme/047     |  66 +++++++++++++++++++++++++++++
 tests/nvme/047.out |   2 +
 tests/nvme/rc      | 103 +++++++++++++++++++++++++++++++++++++++------
 8 files changed, 194 insertions(+), 33 deletions(-)
 create mode 100755 tests/nvme/047
 create mode 100644 tests/nvme/047.out

Comments

Shin'ichiro Kawasaki March 31, 2023, 2:32 a.m. UTC | #1

On Mar 29, 2023 / 11:01, Daniel Wagner wrote:
> Setup different queues, e.g. read and poll queues.
> 
> As discussed I introduced a _require_nvme_trtype() function to limit the test to
> tcp and rdma. I've upated the existing _require_nvme_type_is_*() checks to
> explicit transport checks.
> 
> Test run against current nvme-6.4 but it still needs patch #3 from [1] to
> survive.
> 
> [1] https://lore.kernel.org/linux-nvme/[e-mail]/

All patches look good to me. I reconfirmed that my test system hangs without the
kernel fix patch above [1]. I'll wait for the kernel fix patch lands on Linus
tree, then apply your patches to blktests master.

Shin'ichiro Kawasaki April 12, 2023, 12:23 p.m. UTC | #2

On Mar 31, 2023 / 02:32, Shinichiro Kawasaki wrote:
> On Mar 29, 2023 / 11:01, Daniel Wagner wrote:
> > Setup different queues, e.g. read and poll queues.
> > 
> > As discussed I introduced a _require_nvme_trtype() function to limit the test to
> > tcp and rdma. I've upated the existing _require_nvme_type_is_*() checks to
> > explicit transport checks.
> > 
> > Test run against current nvme-6.4 but it still needs patch #3 from [1] to
> > survive.
> > 
> > [1] https://lore.kernel.org/linux-nvme/[e-mail]/
> 
> All patches look good to me. I reconfirmed that my test system hangs without the
> kernel fix patch above [1]. I'll wait for the kernel fix patch lands on Linus
> tree, then apply your patches to blktests master.

The fix was upstreamed and I've applied this series. Thanks!