| Message ID | 20230328092815.292665-2-bhupesh.sharma@linaro.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | arm64: qcom: Enable Crypto Engine for a few Qualcomm SoCs | expand |
On 28/03/2023 11:28, Bhupesh Sharma wrote: > Add new compatible for BAM DMA engine version v1.7.4 which is > found on Qualcomm SM6115 and QCM2290 SoCs. Since its very similar > to v1.7.0 used on SM8150 like SoCs, mark the comptible scheme > accordingly. > > While at it, also update qcom,bam-dma bindings to add comments > which describe the BAM DMA versions used in SM8150 and SM8250 SoCs. > This provides an easy reference for identifying the actual BAM DMA > version available on Qualcomm SoCs. > > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> > --- > .../devicetree/bindings/dma/qcom,bam-dma.yaml | 22 +++++++++++++------ > 1 file changed, 15 insertions(+), 7 deletions(-) > > diff --git a/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml b/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml > index f1ddcf672261..624208d20a34 100644 > --- a/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml > +++ b/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml > @@ -15,13 +15,21 @@ allOf: > > properties: > compatible: > - enum: > - # APQ8064, IPQ8064 and MSM8960 > - - qcom,bam-v1.3.0 > - # MSM8974, APQ8074 and APQ8084 > - - qcom,bam-v1.4.0 > - # MSM8916 and SDM845 > - - qcom,bam-v1.7.0 > + oneOf: > + - items: Drop "items". This is just an enum. > + - enum: > + # APQ8064, IPQ8064 and MSM8960 > + - qcom,bam-v1.3.0 Best regards, Krzysztof
On 3/30/23 1:41 PM, Krzysztof Kozlowski wrote: > On 28/03/2023 11:28, Bhupesh Sharma wrote: >> Add new compatible for BAM DMA engine version v1.7.4 which is >> found on Qualcomm SM6115 and QCM2290 SoCs. Since its very similar >> to v1.7.0 used on SM8150 like SoCs, mark the comptible scheme >> accordingly. >> >> While at it, also update qcom,bam-dma bindings to add comments >> which describe the BAM DMA versions used in SM8150 and SM8250 SoCs. >> This provides an easy reference for identifying the actual BAM DMA >> version available on Qualcomm SoCs. >> >> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> >> --- >> .../devicetree/bindings/dma/qcom,bam-dma.yaml | 22 +++++++++++++------ >> 1 file changed, 15 insertions(+), 7 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml b/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml >> index f1ddcf672261..624208d20a34 100644 >> --- a/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml >> +++ b/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml >> @@ -15,13 +15,21 @@ allOf: >> >> properties: >> compatible: >> - enum: >> - # APQ8064, IPQ8064 and MSM8960 >> - - qcom,bam-v1.3.0 >> - # MSM8974, APQ8074 and APQ8084 >> - - qcom,bam-v1.4.0 >> - # MSM8916 and SDM845 >> - - qcom,bam-v1.7.0 >> + oneOf: >> + - items: > > Drop "items". This is just an enum. Sure, will fix it in v4. Thanks >> + - enum: >> + # APQ8064, IPQ8064 and MSM8960 >> + - qcom,bam-v1.3.0
diff --git a/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml b/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml index f1ddcf672261..624208d20a34 100644 --- a/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml +++ b/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml @@ -15,13 +15,21 @@ allOf: properties: compatible: - enum: - # APQ8064, IPQ8064 and MSM8960 - - qcom,bam-v1.3.0 - # MSM8974, APQ8074 and APQ8084 - - qcom,bam-v1.4.0 - # MSM8916 and SDM845 - - qcom,bam-v1.7.0 + oneOf: + - items: + - enum: + # APQ8064, IPQ8064 and MSM8960 + - qcom,bam-v1.3.0 + # MSM8974, APQ8074 and APQ8084 + - qcom,bam-v1.4.0 + # MSM8916 + - qcom,bam-v1.7.0 + + - items: + - enum: + # SDM845, SM6115, SM8150, SM8250 and QCM2290 + - qcom,bam-v1.7.4 + - const: qcom,bam-v1.7.0 clocks: maxItems: 1
Add new compatible for BAM DMA engine version v1.7.4 which is found on Qualcomm SM6115 and QCM2290 SoCs. Since its very similar to v1.7.0 used on SM8150 like SoCs, mark the comptible scheme accordingly. While at it, also update qcom,bam-dma bindings to add comments which describe the BAM DMA versions used in SM8150 and SM8250 SoCs. This provides an easy reference for identifying the actual BAM DMA version available on Qualcomm SoCs. Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> --- .../devicetree/bindings/dma/qcom,bam-dma.yaml | 22 +++++++++++++------ 1 file changed, 15 insertions(+), 7 deletions(-)