| Message ID | 20230203-evk-board-support-v3-10-0003e80e0095@baylibre.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Improve the MT8365 SoC and EVK board support | expand |
Il 29/03/23 10:54, amergnat@baylibre.com ha scritto: > From: Fabien Parent <fparent@baylibre.com> > > MSDC1 IP block is powered by VMC. Make sure it is always on. Why always on? Can't you just set mt6357_vmc_reg as VIN of mt6357_vmch_reg? :-) Regards, Angelo > > Signed-off-by: Fabien Parent <fparent@baylibre.com> > Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com> > --- > arch/arm64/boot/dts/mediatek/mt8365-evk.dts | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8365-evk.dts b/arch/arm64/boot/dts/mediatek/mt8365-evk.dts > index b5d018686cbe..22ec332fe9c9 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8365-evk.dts > +++ b/arch/arm64/boot/dts/mediatek/mt8365-evk.dts > @@ -140,6 +140,11 @@ &mt6357_pmic { > #interrupt-cells = <2>; > }; > > +/* Needed by MSDC1 */ > +&mt6357_vmc_reg { > + regulator-always-on; > +}; > + > &pio { > gpio_keys: gpio-keys-pins { > pins { >
Le mer. 29 mars 2023 à 15:25, AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> a écrit : > > Il 29/03/23 10:54, amergnat@baylibre.com ha scritto: > > From: Fabien Parent <fparent@baylibre.com> > > > > MSDC1 IP block is powered by VMC. Make sure it is always on. > > Why always on? > Can't you just set mt6357_vmc_reg as VIN of mt6357_vmch_reg? :-) I'm not sure to get it. mt6357_vmc_reg & mt6357_vmch_reg come from PMIC and are supposed to be independent. You suggest to link them in the mt8365-evk dts file using something like: &mt6357_vmch_reg { vin-supply = <&mt6357_vmc_reg>; }; Also, regulator binding probably needs change to support that. Regards, Alex
Le ven. 31 mars 2023 à 13:08, Alexandre Mergnat <amergnat@baylibre.com> a écrit : > > Le mer. 29 mars 2023 à 15:25, AngeloGioacchino Del Regno > <angelogioacchino.delregno@collabora.com> a écrit : > > > > Il 29/03/23 10:54, amergnat@baylibre.com ha scritto: > > > From: Fabien Parent <fparent@baylibre.com> > > > > > > MSDC1 IP block is powered by VMC. Make sure it is always on. > > > > Why always on? > > Can't you just set mt6357_vmc_reg as VIN of mt6357_vmch_reg? :-) > > I'm not sure to get it. mt6357_vmc_reg & mt6357_vmch_reg come from > PMIC and are supposed to be independent. > You suggest to link them in the mt8365-evk dts file using something like: > &mt6357_vmch_reg { > vin-supply = <&mt6357_vmc_reg>; > }; Additionally, vin-supply is supported by fixed-regulator and gpio-regulator, which is not the case here. I think it isn't doable. Regards, Alex
diff --git a/arch/arm64/boot/dts/mediatek/mt8365-evk.dts b/arch/arm64/boot/dts/mediatek/mt8365-evk.dts index b5d018686cbe..22ec332fe9c9 100644 --- a/arch/arm64/boot/dts/mediatek/mt8365-evk.dts +++ b/arch/arm64/boot/dts/mediatek/mt8365-evk.dts @@ -140,6 +140,11 @@ &mt6357_pmic { #interrupt-cells = <2>; }; +/* Needed by MSDC1 */ +&mt6357_vmc_reg { + regulator-always-on; +}; + &pio { gpio_keys: gpio-keys-pins { pins {