| Message ID | 6652003b-e89c-4011-9e7d-a730a50bcfce@kili.mountain (mailing list archive) |
|---|---|
| State | Awaiting Upstream |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] net/mlx5: Fix check for allocation failure in comp_irqs_request_pci() | expand |
On Fri, Mar 31, 2023 at 10:03:47AM +0300, Dan Carpenter wrote: > This function accidentally dereferences "cpus" instead of returning > directly. > > Fixes: b48a0f72bc3e ("net/mlx5: Refactor completion irq request/release code") > Signed-off-by: Dan Carpenter <error27@gmail.com> Reviewed-by: Simon Horman <simon.horman@corigine.com>
On Fri, Mar 31, 2023 at 10:03:47AM +0300, Dan Carpenter wrote: > This function accidentally dereferences "cpus" instead of returning > directly. > > Fixes: b48a0f72bc3e ("net/mlx5: Refactor completion irq request/release code") > Signed-off-by: Dan Carpenter <error27@gmail.com> > --- > drivers/net/ethernet/mellanox/mlx5/core/eq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Thanks, Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/eq.c b/drivers/net/ethernet/mellanox/mlx5/core/eq.c index eb41f0abf798..13491246c9e9 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/eq.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/eq.c @@ -824,7 +824,7 @@ static int comp_irqs_request_pci(struct mlx5_core_dev *dev) ncomp_eqs = table->num_comp_eqs; cpus = kcalloc(ncomp_eqs, sizeof(*cpus), GFP_KERNEL); if (!cpus) - ret = -ENOMEM; + return -ENOMEM; i = 0; rcu_read_lock();
This function accidentally dereferences "cpus" instead of returning directly. Fixes: b48a0f72bc3e ("net/mlx5: Refactor completion irq request/release code") Signed-off-by: Dan Carpenter <error27@gmail.com> --- drivers/net/ethernet/mellanox/mlx5/core/eq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)