| Message ID | 5e9a87a3f4c1ccc30625c8092b057f0fbd8a9947.1680435823.git.daniel@makrotopia.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | ad651d68cee75e9ac20002254c4e5d09ee67a84b |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: sfp: add qurik enabling 2500Base-x for HG MXPD-483II | expand |
On Sun, Apr 02, 2023 at 12:44:37PM +0100, Daniel Golle wrote: > The HG MXPD-483II 1310nm SFP module is meant to operate with 2500Base-X, > however, in their EEPROM they incorrectly specify: > Transceiver type : Ethernet: 1000BASE-LX > ... > BR, Nominal : 2600MBd > > Use sfp_quirk_2500basex for this module to allow 2500Base-X mode anyway. > > https://forum.banana-pi.org/t/bpi-r3-sfp-module-compatibility/14573/60 Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> Please could you also arrange for the reporter to capture the ethtool information via: ethtool -m ethX raw on > sfp-name.bin and send me the binary file? Thanks!
> Gesendet: Sonntag, 02. April 2023 um 13:44 Uhr > Von: "Daniel Golle" <daniel@makrotopia.org> > Betreff: [PATCH] net: sfp: add qurik enabling 2500Base-x for HG MXPD-483II just noted a small typo...s/qurik/quirk/ regards Frank
Hello: This patch was applied to netdev/net.git (main) by David S. Miller <davem@davemloft.net>: On Sun, 2 Apr 2023 12:44:37 +0100 you wrote: > The HG MXPD-483II 1310nm SFP module is meant to operate with 2500Base-X, > however, in their EEPROM they incorrectly specify: > Transceiver type : Ethernet: 1000BASE-LX > ... > BR, Nominal : 2600MBd > > Use sfp_quirk_2500basex for this module to allow 2500Base-X mode anyway. > > [...] Here is the summary with links: - net: sfp: add qurik enabling 2500Base-x for HG MXPD-483II https://git.kernel.org/netdev/net/c/ad651d68cee7 You are awesome, thank you!
diff --git a/drivers/net/phy/sfp.c b/drivers/net/phy/sfp.c index f0fcb06fbe829..5e515165ceab7 100644 --- a/drivers/net/phy/sfp.c +++ b/drivers/net/phy/sfp.c @@ -406,6 +406,10 @@ static const struct sfp_quirk sfp_quirks[] = { SFP_QUIRK_F("HALNy", "HL-GSFP", sfp_fixup_halny_gsfp), + // HG MXPD-483II-F 2.5G supports 2500Base-X, but incorrectly reports + // 2600MBd in their EERPOM + SFP_QUIRK_M("HG GENUINE", "MXPD-483II", sfp_quirk_2500basex), + // Huawei MA5671A can operate at 2500base-X, but report 1.2GBd NRZ in // their EEPROM SFP_QUIRK("HUAWEI", "MA5671A", sfp_quirk_2500basex,
The HG MXPD-483II 1310nm SFP module is meant to operate with 2500Base-X, however, in their EEPROM they incorrectly specify: Transceiver type : Ethernet: 1000BASE-LX ... BR, Nominal : 2600MBd Use sfp_quirk_2500basex for this module to allow 2500Base-X mode anyway. https://forum.banana-pi.org/t/bpi-r3-sfp-module-compatibility/14573/60 Reported-by: chowtom <chowtom@gmail.com> Tested-by: chowtom <chowtom@gmail.com> Signed-off-by: Daniel Golle <daniel@makrotopia.org> --- drivers/net/phy/sfp.c | 4 ++++ 1 file changed, 4 insertions(+) base-commit: d74aab2ca19842d16815a97d4dd605deaae73c69