[v1] Bluetooth: btnxpuart: Disable Power Save feature on startup

Commit Message

Neeraj Sanjay Kale April 3, 2023, 12:24 p.m. UTC

This sets the default power save mode setting to disabled.
With this setting, this driver will behave like a normal h4 driver.
If user needs to use the power save feature, it can be enabled
using the following vendor command:
hcitool cmd 3f 23 02 00 00 (HCI_NXP_AUTO_SLEEP_MODE)

Signed-off-by: Neeraj Sanjay Kale <[e-mail]>
---
 drivers/bluetooth/btnxpuart.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

[e-mail] April 3, 2023, 1:13 p.m. UTC | #1

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=736376

---Test result---

Test Summary:
CheckPatch                    PASS      0.69 seconds
GitLint                       PASS      0.36 seconds
SubjectPrefix                 PASS      0.12 seconds
BuildKernel                   PASS      33.88 seconds
CheckAllWarning               PASS      35.88 seconds
CheckSparse                   PASS      40.50 seconds
CheckSmatch                   PASS      110.02 seconds
BuildKernel32                 PASS      31.60 seconds
TestRunnerSetup               PASS      451.07 seconds
TestRunner_l2cap-tester       PASS      16.24 seconds
TestRunner_iso-tester         PASS      16.51 seconds
TestRunner_bnep-tester        PASS      5.36 seconds
TestRunner_mgmt-tester        PASS      109.77 seconds
TestRunner_rfcomm-tester      PASS      8.55 seconds
TestRunner_sco-tester         PASS      7.96 seconds
TestRunner_ioctl-tester       PASS      9.17 seconds
TestRunner_mesh-tester        PASS      6.76 seconds
TestRunner_smp-tester         PASS      7.85 seconds
TestRunner_userchan-tester    PASS      5.63 seconds
IncrementalBuild              PASS      30.57 seconds



---
Regards,
Linux Bluetooth

[e-mail] April 6, 2023, 9 p.m. UTC | #2

Hello:

This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <[e-mail]>:

On Mon,  3 Apr 2023 17:54:29 +0530 you wrote:
> This sets the default power save mode setting to disabled.
> With this setting, this driver will behave like a normal h4 driver.
> If user needs to use the power save feature, it can be enabled
> using the following vendor command:
> hcitool cmd 3f 23 02 00 00 (HCI_NXP_AUTO_SLEEP_MODE)
> 
> Signed-off-by: Neeraj Sanjay Kale <[e-mail]>
> 
> [...]

Here is the summary with links:
  - [v1] Bluetooth: btnxpuart: Disable Power Save feature on startup
    https://git.kernel.org/bluetooth/bluetooth-next/c/3f8dae828fb2

You are awesome, thank you!

Patch

diff --git a/drivers/bluetooth/btnxpuart.c b/drivers/bluetooth/btnxpuart.c
index ad9e25e0c350..93f3afc0c0c8 100644
--- a/drivers/bluetooth/btnxpuart.c
+++ b/drivers/bluetooth/btnxpuart.c
@@ -262,7 +262,7 @@  static u8 crc8_table[CRC8_TABLE_SIZE];
 
 /* Default configurations */
 #define DEFAULT_H2C_WAKEUP_MODE	WAKEUP_METHOD_BREAK
-#define DEFAULT_PS_MODE		PS_MODE_ENABLE
+#define DEFAULT_PS_MODE		PS_MODE_DISABLE
 #define FW_INIT_BAUDRATE	HCI_NXP_PRI_BAUDRATE
 
 static struct sk_buff *nxp_drv_send_cmd(struct hci_dev *hdev, u16 opcode,