| Message ID | 20230330164556.31533-3-Jonathan.Cameron@huawei.com |
|---|---|
| State | Accepted |
| Commit | 143f83e2003a4c3ca0c2558254129569048e0759 |
| Headers | show |
| Series | CXL 3.0 Performance Monitoring Unit support | expand |
Jonathan Cameron wrote: > Some PMUs have well defined parents such as PCI devices. > As the device_initialize() and device_add() are all within > pmu_dev_alloc() which is called from perf_pmu_register() > there is no opportunity to set the parent from within a driver. > > Add a struct device *parent field to struct pmu and use that > to set the parent. > > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > --- > v4: No change > Note that this may first merge as part of a larger series I > plan to post next week that adds parents for many of the of the > other struct pmu instances. If so please drop this patch whilst > applying. Feel free to add my: Reviewed-by: Dan Williams <dan.j.williams@intel.com> ...whereever this gets applied, and yes it makes sense especially as more device attached PMUs are showing up.
diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h index d5628a7b5eaa..b99db1eda72c 100644 --- a/include/linux/perf_event.h +++ b/include/linux/perf_event.h @@ -303,6 +303,7 @@ struct pmu { struct module *module; struct device *dev; + struct device *parent; const struct attribute_group **attr_groups; const struct attribute_group **attr_update; const char *name; diff --git a/kernel/events/core.c b/kernel/events/core.c index fb3e436bcd4a..a84c282221f2 100644 --- a/kernel/events/core.c +++ b/kernel/events/core.c @@ -11367,6 +11367,7 @@ static int pmu_dev_alloc(struct pmu *pmu) dev_set_drvdata(pmu->dev, pmu); pmu->dev->bus = &pmu_bus; + pmu->dev->parent = pmu->parent; pmu->dev->release = pmu_dev_release; ret = dev_set_name(pmu->dev, "%s", pmu->name);
Some PMUs have well defined parents such as PCI devices. As the device_initialize() and device_add() are all within pmu_dev_alloc() which is called from perf_pmu_register() there is no opportunity to set the parent from within a driver. Add a struct device *parent field to struct pmu and use that to set the parent. Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> --- v4: No change Note that this may first merge as part of a larger series I plan to post next week that adds parents for many of the of the other struct pmu instances. If so please drop this patch whilst applying. --- include/linux/perf_event.h | 1 + kernel/events/core.c | 1 + 2 files changed, 2 insertions(+)