| Message ID | 20230203-evk-board-support-v4-0-5cffe66a38c0@baylibre.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Improve the MT8365 SoC and EVK board support | expand |
Alexandre Mergnat <amergnat@baylibre.com> writes: > This commits are based on the Fabien Parent <fparent@baylibre.com> work. > > The purpose of this series is to add the following HWs / IPs support for > the mt8365-evk board: > - Watchdog > - Power Management Integrated Circuit "PMIC" wrapper > - MT6357 PMIC > - MultiMediaCard "MMC" & Secure Digital "SD" controller > - USB controller > - Ethernet MAC controller > > Add CPU Freq & IDLE support for this board. > > This series depends to anothers which add support for MT8365 EVK board > [1] and the MT8365 I2C support [2]. Both are currently applied. > > The DTB check may failed/warn about pinctrl binding, but it should be > fixed thanks to this serie [3] It's not just the DTB check that that depends on the pinctrl binding series. Patch 2 of this series touches the pinctrl bindings, and does not apply unless the pinctrl series is also applied. IOW, I needed to apply [1], [2] and [3] to mainline in order to apply this series. After applying the dependencies, the kernel fails to build: ../arch/arm64/boot/dts/mediatek/mt8365-evk.dts:15:10: fatal error: mt6357.dtsi: No such file or directory 15 | #include "mt6357.dtsi" | ^~~~~~~~~~~~~ compilation terminated. With lots of dependencies like this, it would be useful for you to push a temporary branch on mainline where you've applied all the dependencies so we can better see what the dependencies actually are. Kevin
You forgot to apply the patches merged by Matthias: Changes in v4: - Remove v3 applied patch from the serie: - arm64: dts: mediatek: add ethernet support for mt8365 SoC - arm64: dts: mediatek: add mmc support for mt8365 SoC - arm64: dts: mediatek: add mt6357 device-tree - arm64: dts: mediatek: add pwrap support to mt8365 SoC - arm64: dts: mediatek: Increase the size BL31 reserved memory ... Changes in v3: - Remove v2 applied patch from the serie: - dt-bindings: mmc: mediatek,mtk-sd: add mt8365 Regards, Alex
Here a build-able & working branch with dependencies: https://gitlab.baylibre.com/baylibre/mediatek/bsp/linux/-/commits/amergnat/i350-evk-board-support Regards, Alex Le ven. 31 mars 2023 à 20:45, Alexandre Mergnat <amergnat@baylibre.com> a écrit : > > You forgot to apply the patches merged by Matthias: > > Changes in v4: > - Remove v3 applied patch from the serie: > - arm64: dts: mediatek: add ethernet support for mt8365 SoC > - arm64: dts: mediatek: add mmc support for mt8365 SoC > - arm64: dts: mediatek: add mt6357 device-tree > - arm64: dts: mediatek: add pwrap support to mt8365 SoC > - arm64: dts: mediatek: Increase the size BL31 reserved memory > > ... > > Changes in v3: > - Remove v2 applied patch from the serie: > - dt-bindings: mmc: mediatek,mtk-sd: add mt8365 > > Regards, > Alex
Alexandre Mergnat <amergnat@baylibre.com> writes: > You forgot to apply the patches merged by Matthias: Because they weren't listed as dependencies. :) Kevin > Changes in v4: > - Remove v3 applied patch from the serie: > - arm64: dts: mediatek: add ethernet support for mt8365 SoC > - arm64: dts: mediatek: add mmc support for mt8365 SoC > - arm64: dts: mediatek: add mt6357 device-tree > - arm64: dts: mediatek: add pwrap support to mt8365 SoC > - arm64: dts: mediatek: Increase the size BL31 reserved memory > > ... > > Changes in v3: > - Remove v2 applied patch from the serie: > - dt-bindings: mmc: mediatek,mtk-sd: add mt8365 > > Regards, > Alex
Alexandre Mergnat <amergnat@baylibre.com> writes: > Here a build-able & working branch with dependencies: > https://gitlab.baylibre.com/baylibre/mediatek/bsp/linux/-/commits/amergnat/i350-evk-board-support This branch doesn't compile. Kevin
Kevin Hilman <khilman@baylibre.com> writes: > Alexandre Mergnat <amergnat@baylibre.com> writes: > >> Here a build-able & working branch with dependencies: >> https://gitlab.baylibre.com/baylibre/mediatek/bsp/linux/-/commits/amergnat/i350-evk-board-support > > This branch doesn't compile. I'm wrong, it compiles fine. I was on the wrong branch. Sorry for the noise, Kevin
Alexandre Mergnat <amergnat@baylibre.com> writes: > Here a build-able & working branch with dependencies: > https://gitlab.baylibre.com/baylibre/mediatek/bsp/linux/-/commits/amergnat/i350-evk-board-support Thanks for a branch with all the dependencies. This branch builds & boots, but crashes because in the upstream default defconfig, the CPUfreq driver is built-in and the regulator that it depends on is not enabled. Changing CPUfreq to be modular with CONFIG_ARM_MEDIATEK_CPUFREQ=m allowed me to boot to a shell on mt8365-evk. This suggests that this series needs some defconfig patches to enable the new features, preferably as modules. It's probably OK that the defconfig patch(es) come as a separate series, but not sure what Matthias' preferences are here. Kevin
This commits are based on the Fabien Parent <fparent@baylibre.com> work. The purpose of this series is to add the following HWs / IPs support for the mt8365-evk board: - Watchdog - Power Management Integrated Circuit "PMIC" wrapper - MT6357 PMIC - MultiMediaCard "MMC" & Secure Digital "SD" controller - USB controller - Ethernet MAC controller Add CPU Freq & IDLE support for this board. This series depends to anothers which add support for MT8365 EVK board [1] and the MT8365 I2C support [2]. Both are currently applied. The DTB check may failed/warn about pinctrl binding, but it should be fixed thanks to this serie [3] Regards, Alex [1]: https://lore.kernel.org/all/20230309213501.794764-1-bero@baylibre.com/ [2]: https://lore.kernel.org/all/20221122-mt8365-i2c-support-v6-0-e1009c8afd53@baylibre.com/ [3]: https://lore.kernel.org/all/20230327-cleanup-pinctrl-binding-v2-0-f21fbcc3016e@baylibre.com/ Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com> --- Changes in v4: - Remove v3 applied patch from the serie: - arm64: dts: mediatek: add ethernet support for mt8365 SoC - arm64: dts: mediatek: add mmc support for mt8365 SoC - arm64: dts: mediatek: add mt6357 device-tree - arm64: dts: mediatek: add pwrap support to mt8365 SoC - arm64: dts: mediatek: Increase the size BL31 reserved memory - Drop "arm64: dts: mediatek: fix systimer properties" which is done [1] - Fix style, typo and re-order properties. - Use interrupts-extended for the PMIC node. - Link to v3: https://lore.kernel.org/r/20230203-evk-board-support-v3-0-0003e80e0095@baylibre.com Changes in v3: - Remove v2 applied patch from the serie: - dt-bindings: mmc: mediatek,mtk-sd: add mt8365 - Add trailers and simply resend. - Link to v2: https://lore.kernel.org/r/20230203-evk-board-support-v2-0-6ec7cdb10ccf@baylibre.com --- Alexandre Mergnat (9): dt-bindings: watchdog: mediatek,mtk-wdt: add mt8365 dt-bindings: pinctrl: mediatek,mt8365-pinctrl: add drive strength property arm64: dts: mediatek: add watchdog support for mt8365 SoC arm64: dts: mediatek: add mt6357 PMIC support for mt8365-evk arm64: dts: mediatek: add mmc support for mt8365-evk arm64: dts: mediatek: add usb controller support for mt8365-evk arm64: dts: mediatek: add ethernet support for mt8365-evk arm64: dts: mediatek: add OPP support for mt8365 SoC arm64: dts: mediatek: add cpufreq support for mt8365-evk Amjad Ouled-Ameur (1): arm64: dts: mediatek: Add CPU Idle support Fabien Parent (1): arm64: dts: mediatek: set vmc regulator as always on .../bindings/pinctrl/mediatek,mt8365-pinctrl.yaml | 3 + .../bindings/watchdog/mediatek,mtk-wdt.yaml | 1 + arch/arm64/boot/dts/mediatek/mt8365-evk.dts | 249 +++++++++++++++++++++ arch/arm64/boot/dts/mediatek/mt8365.dtsi | 142 ++++++++++++ 4 files changed, 395 insertions(+) --- base-commit: 4f2a499a344b36ebb325e610265452ea88541116 change-id: 20230203-evk-board-support-d5b7a839ed7b Best regards,