| Message ID | 20230207-iommu-support-v2-0-60d5fa00e4e5@baylibre.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Add IOMMU support to MT8365 SoC | expand |
On 05/04/2023 10:06, Alexandre Mergnat wrote: > This commits are based on the Fabien Parent <fparent@baylibre.com> work. > > The purpose of this series is to add the following HWs / IPs support for > the MT8365 SoC: > - System Power Manager > - MultiMedia Memory Management Unit "M4U" (IOMMU) > - Smart Multimedia Interface "SMI" > - Local arbiter "LARB" > > This series depends to two others which add power support for MT8365 SoC > [1] [2]. So does it mean they cannot be merged? On first glance I do not see the dependency, so I wonder if we understand the dependencies the same. And subsystems. Best regards, Krzysztof
On 05/04/2023 13:43, Krzysztof Kozlowski wrote: > On 05/04/2023 10:06, Alexandre Mergnat wrote: >> This commits are based on the Fabien Parent <fparent@baylibre.com> work. >> >> The purpose of this series is to add the following HWs / IPs support for >> the MT8365 SoC: >> - System Power Manager >> - MultiMedia Memory Management Unit "M4U" (IOMMU) >> - Smart Multimedia Interface "SMI" >> - Local arbiter "LARB" >> >> This series depends to two others which add power support for MT8365 SoC >> [1] [2]. > So does it mean they cannot be merged? On first glance I do not see the > dependency, so I wonder if we understand the dependencies the same. And > subsystems. Exactly, we shouldn't merge it before the dependent series to don't break the build due to "#include <dt-bindings/power/mediatek,mt8365-power.h>" in the DTSI file. Additionally, LARB will not work properly (or at all) without the power support. Regards, Alexandre
On 05/04/2023 15:13, Alexandre Mergnat wrote: > > On 05/04/2023 13:43, Krzysztof Kozlowski wrote: >> On 05/04/2023 10:06, Alexandre Mergnat wrote: >>> This commits are based on the Fabien Parent <fparent@baylibre.com> work. >>> >>> The purpose of this series is to add the following HWs / IPs support for >>> the MT8365 SoC: >>> - System Power Manager >>> - MultiMedia Memory Management Unit "M4U" (IOMMU) >>> - Smart Multimedia Interface "SMI" >>> - Local arbiter "LARB" >>> >>> This series depends to two others which add power support for MT8365 SoC >>> [1] [2]. >> So does it mean they cannot be merged? On first glance I do not see the >> dependency, so I wonder if we understand the dependencies the same. And >> subsystems. > Exactly, we shouldn't merge it before the dependent series to don't ] > break the build due to > "#include <dt-bindings/power/mediatek,mt8365-power.h>" in the DTSI file. > Additionally, LARB will not work properly (or at all) without the power > support. And how driver is related to it? If it is, you might have some unusual coupling between power and memory controller driver. Best regards, Krzysztof
This commits are based on the Fabien Parent <fparent@baylibre.com> work. The purpose of this series is to add the following HWs / IPs support for the MT8365 SoC: - System Power Manager - MultiMedia Memory Management Unit "M4U" (IOMMU) - Smart Multimedia Interface "SMI" - Local arbiter "LARB" This series depends to two others which add power support for MT8365 SoC [1] [2]. Regards, Alex [1]: https://lore.kernel.org/all/20230203-evk-board-support-v2-0-6ec7cdb10ccf@baylibre.com/ [2]: https://lore.kernel.org/lkml/20230105170735.1637416-1-msp@baylibre.com/ Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com> --- Changes in v2: - Split power domain patch (3) in 4 patches to explain in the commit messages the added subsystems. - Add an independent "mediatek,mt8365-smi-common" compatible to have its own LARB bus select. - Link to v1: https://lore.kernel.org/r/20230207-iommu-support-v1-0-4f0c81fd52c1@baylibre.com --- Alexandre Mergnat (10): dt-bindings: memory-controllers: mediatek,smi-common: add mt8365 dt-bindings: memory-controllers: mediatek,smi-larb: add mt8365 arm64: dts: mediatek: add mmsys support for mt8365 SoC arm64: dts: mediatek: add camsys support for mt8365 SoC arm64: dts: mediatek: add apu support for mt8365 SoC arm64: dts: mediatek: add power domain support for mt8365 SoC arm64: dts: mediatek: add smi support for mt8365 SoC arm64: dts: mediatek: add larb support for mt8365 SoC arm64: dts: mediatek: add iommu support for mt8365 SoC memory: mtk-smi: mt8365: Add SMI Support .../memory-controllers/mediatek,smi-common.yaml | 2 + .../memory-controllers/mediatek,smi-larb.yaml | 4 + arch/arm64/boot/dts/mediatek/mt8365.dtsi | 210 +++++++++++++++++++++ drivers/memory/mtk-smi.c | 7 + 4 files changed, 223 insertions(+) --- base-commit: 1db7fc94e6e116f43f7bf3adb33407f21bc29fd9 change-id: 20230207-iommu-support-5e620926e42e Best regards,