| Message ID | 20230404173807.490520-1-cristian.ciocaltea@collabora.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Add PWM fan support to Rock 5B board | expand |
On Tue, 4 Apr 2023 20:38:05 +0300, Cristian Ciocaltea wrote: > This patch series enables support for the PWM controlled heat sink fan > on the Rock 5B SBC and, additionally, converts the hwmon PWM fan bindings > to DT schema format. > > Changes in v2: > - Updated PATCH 1/2 according to Rob's review > - Added Reviewed-by from Christopher to PATCH 2/2 > - v1: https://lore.kernel.org/lkml/20230403105052.426135-1-cristian.ciocaltea@collabora.com/ > > [...] Applied, thanks! [2/2] arm64: dts: rockchip: rk3588-rock-5b: Add pwm-fan commit: f36bb17653e4b9e26bbdb1224027d20614e77636 Best regards,
On 4/5/23 10:45, Heiko Stuebner wrote: > On Tue, 4 Apr 2023 20:38:05 +0300, Cristian Ciocaltea wrote: >> This patch series enables support for the PWM controlled heat sink fan >> on the Rock 5B SBC and, additionally, converts the hwmon PWM fan bindings >> to DT schema format. >> >> Changes in v2: >> - Updated PATCH 1/2 according to Rob's review >> - Added Reviewed-by from Christopher to PATCH 2/2 >> - v1: https://lore.kernel.org/lkml/20230403105052.426135-1-cristian.ciocaltea@collabora.com/ >> >> [...] > > Applied, thanks! > Both patches or only the second one ? Thanks, Guenter
Am Mittwoch, 5. April 2023, 21:04:04 CEST schrieb Guenter Roeck: > On 4/5/23 10:45, Heiko Stuebner wrote: > > On Tue, 4 Apr 2023 20:38:05 +0300, Cristian Ciocaltea wrote: > >> This patch series enables support for the PWM controlled heat sink fan > >> on the Rock 5B SBC and, additionally, converts the hwmon PWM fan bindings > >> to DT schema format. > >> > >> Changes in v2: > >> - Updated PATCH 1/2 according to Rob's review > >> - Added Reviewed-by from Christopher to PATCH 2/2 > >> - v1: https://lore.kernel.org/lkml/20230403105052.426135-1-cristian.ciocaltea@collabora.com/ > >> > >> [...] > > > > Applied, thanks! > > > > Both patches or only the second one ? only the second one of course. According to earlier talks the dts patch does already follow the text binding, so the yaml conversion is actually not a requirement for it. So I picked the dts patch let the binding sort itself when people have time for it :-) . Looking at the mail b4 created, I guessed this would also be visible with the subject saying (subset) and the listed commits only showing [2/2] arm64: dts: rockchip: rk3588-rock-5b: Add pwm-fan commit: f36bb17653e4b9e26bbdb1224027d20614e77636 Heiko
On 4/5/23 14:35, Heiko Stübner wrote: > Am Mittwoch, 5. April 2023, 21:04:04 CEST schrieb Guenter Roeck: >> On 4/5/23 10:45, Heiko Stuebner wrote: >>> On Tue, 4 Apr 2023 20:38:05 +0300, Cristian Ciocaltea wrote: >>>> This patch series enables support for the PWM controlled heat sink fan >>>> on the Rock 5B SBC and, additionally, converts the hwmon PWM fan bindings >>>> to DT schema format. >>>> >>>> Changes in v2: >>>> - Updated PATCH 1/2 according to Rob's review >>>> - Added Reviewed-by from Christopher to PATCH 2/2 >>>> - v1: https://lore.kernel.org/lkml/20230403105052.426135-1-cristian.ciocaltea@collabora.com/ >>>> >>>> [...] >>> >>> Applied, thanks! >>> >> >> Both patches or only the second one ? > > only the second one of course. According to earlier talks the dts patch > does already follow the text binding, so the yaml conversion is actually > not a requirement for it. > > So I picked the dts patch let the binding sort itself when people have > time for it :-) . > > > Looking at the mail b4 created, I guessed this would also be visible > with the subject saying (subset) and the listed commits only showing > > [2/2] arm64: dts: rockchip: rk3588-rock-5b: Add pwm-fan > commit: f36bb17653e4b9e26bbdb1224027d20614e77636 > Kind of, sure, but I figured it doesn't hurt asking to avoid the situation (again) where I apply a patch and then get a nice e-mail telling me that some other branch also applied the same patch. Guenter
Am Donnerstag, 6. April 2023, 20:27:33 CEST schrieb Guenter Roeck: > On 4/5/23 14:35, Heiko Stübner wrote: > > Am Mittwoch, 5. April 2023, 21:04:04 CEST schrieb Guenter Roeck: > >> On 4/5/23 10:45, Heiko Stuebner wrote: > >>> On Tue, 4 Apr 2023 20:38:05 +0300, Cristian Ciocaltea wrote: > >>>> This patch series enables support for the PWM controlled heat sink fan > >>>> on the Rock 5B SBC and, additionally, converts the hwmon PWM fan bindings > >>>> to DT schema format. > >>>> > >>>> Changes in v2: > >>>> - Updated PATCH 1/2 according to Rob's review > >>>> - Added Reviewed-by from Christopher to PATCH 2/2 > >>>> - v1: https://lore.kernel.org/lkml/20230403105052.426135-1-cristian.ciocaltea@collabora.com/ > >>>> > >>>> [...] > >>> > >>> Applied, thanks! > >>> > >> > >> Both patches or only the second one ? > > > > only the second one of course. According to earlier talks the dts patch > > does already follow the text binding, so the yaml conversion is actually > > not a requirement for it. > > > > So I picked the dts patch let the binding sort itself when people have > > time for it :-) . > > > > > > Looking at the mail b4 created, I guessed this would also be visible > > with the subject saying (subset) and the listed commits only showing > > > > [2/2] arm64: dts: rockchip: rk3588-rock-5b: Add pwm-fan > > commit: f36bb17653e4b9e26bbdb1224027d20614e77636 > > > > Kind of, sure, but I figured it doesn't hurt asking to avoid the situation > (again) where I apply a patch and then get a nice e-mail telling me that > some other branch also applied the same patch. no worries and yes better save than sorry. Though you had me worried for a bit that somehow the mail b4 generated for me was faulty ;-) Heiko