| Message ID | 20230407150112.79854-1-krzysztof.kozlowski@linaro.org (mailing list archive) |
|---|---|
| State | Handled Elsewhere |
| Headers | show |
| Series | fpga: dfl-fme: constify pointers to hwmon_channel_info | expand |
On 4/7/23 08:01, Krzysztof Kozlowski wrote: > Statically allocated array of pointed to hwmon_channel_info can be made > const for safety. Reviewed-by: Russ Weight <russell.h.weight@intel.com> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > --- > > This depends on hwmon core patch: > https://lore.kernel.org/all/20230406203103.3011503-2-krzysztof.kozlowski@linaro.org/ > > Therefore I propose this should also go via hwmon tree. > > Cc: Jean Delvare <jdelvare@suse.com> > Cc: Guenter Roeck <linux@roeck-us.net> > Cc: linux-hwmon@vger.kernel.org > --- > drivers/fpga/dfl-fme-main.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/fpga/dfl-fme-main.c b/drivers/fpga/dfl-fme-main.c > index 77ea04d4edbe..bcb5d34b3b82 100644 > --- a/drivers/fpga/dfl-fme-main.c > +++ b/drivers/fpga/dfl-fme-main.c > @@ -265,7 +265,7 @@ static const struct hwmon_ops thermal_hwmon_ops = { > .read = thermal_hwmon_read, > }; > > -static const struct hwmon_channel_info *thermal_hwmon_info[] = { > +static const struct hwmon_channel_info * const thermal_hwmon_info[] = { > HWMON_CHANNEL_INFO(temp, HWMON_T_INPUT | HWMON_T_EMERGENCY | > HWMON_T_MAX | HWMON_T_MAX_ALARM | > HWMON_T_CRIT | HWMON_T_CRIT_ALARM), > @@ -465,7 +465,7 @@ static const struct hwmon_ops power_hwmon_ops = { > .write = power_hwmon_write, > }; > > -static const struct hwmon_channel_info *power_hwmon_info[] = { > +static const struct hwmon_channel_info * const power_hwmon_info[] = { > HWMON_CHANNEL_INFO(power, HWMON_P_INPUT | > HWMON_P_MAX | HWMON_P_MAX_ALARM | > HWMON_P_CRIT | HWMON_P_CRIT_ALARM),
On 4/7/23 08:01, Krzysztof Kozlowski wrote: > Statically allocated array of pointed to hwmon_channel_info can be made > const for safety. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > --- > > This depends on hwmon core patch: > https://lore.kernel.org/all/20230406203103.3011503-2-krzysztof.kozlowski@linaro.org/ > > Therefore I propose this should also go via hwmon tree. I am not going to apply patches for 10+ subsystems through the hwmon tree. This can only result in chaos. The dependent patch is available at git://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-const or wait until after the next commit window to apply this patch. Thanks, Guenter > > Cc: Jean Delvare <jdelvare@suse.com> > Cc: Guenter Roeck <linux@roeck-us.net> > Cc: linux-hwmon@vger.kernel.org > --- > drivers/fpga/dfl-fme-main.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/fpga/dfl-fme-main.c b/drivers/fpga/dfl-fme-main.c > index 77ea04d4edbe..bcb5d34b3b82 100644 > --- a/drivers/fpga/dfl-fme-main.c > +++ b/drivers/fpga/dfl-fme-main.c > @@ -265,7 +265,7 @@ static const struct hwmon_ops thermal_hwmon_ops = { > .read = thermal_hwmon_read, > }; > > -static const struct hwmon_channel_info *thermal_hwmon_info[] = { > +static const struct hwmon_channel_info * const thermal_hwmon_info[] = { > HWMON_CHANNEL_INFO(temp, HWMON_T_INPUT | HWMON_T_EMERGENCY | > HWMON_T_MAX | HWMON_T_MAX_ALARM | > HWMON_T_CRIT | HWMON_T_CRIT_ALARM), > @@ -465,7 +465,7 @@ static const struct hwmon_ops power_hwmon_ops = { > .write = power_hwmon_write, > }; > > -static const struct hwmon_channel_info *power_hwmon_info[] = { > +static const struct hwmon_channel_info * const power_hwmon_info[] = { > HWMON_CHANNEL_INFO(power, HWMON_P_INPUT | > HWMON_P_MAX | HWMON_P_MAX_ALARM | > HWMON_P_CRIT | HWMON_P_CRIT_ALARM),
On 2023-04-07 at 16:08:45 -0700, Guenter Roeck wrote: > On 4/7/23 08:01, Krzysztof Kozlowski wrote: > > Statically allocated array of pointed to hwmon_channel_info can be made > > const for safety. > > > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > > > --- > > > > This depends on hwmon core patch: > > https://lore.kernel.org/all/20230406203103.3011503-2-krzysztof.kozlowski@linaro.org/ > > > > Therefore I propose this should also go via hwmon tree. > > I am not going to apply patches for 10+ subsystems through the hwmon tree. > This can only result in chaos. The dependent patch is available at > > git://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-const > > or wait until after the next commit window to apply this patch. OK, I could apply this patch to linux-fpga in next cycle. Thanks, Yilun > > Thanks, > Guenter > > > > > Cc: Jean Delvare <jdelvare@suse.com> > > Cc: Guenter Roeck <linux@roeck-us.net> > > Cc: linux-hwmon@vger.kernel.org > > --- > > drivers/fpga/dfl-fme-main.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/fpga/dfl-fme-main.c b/drivers/fpga/dfl-fme-main.c > > index 77ea04d4edbe..bcb5d34b3b82 100644 > > --- a/drivers/fpga/dfl-fme-main.c > > +++ b/drivers/fpga/dfl-fme-main.c > > @@ -265,7 +265,7 @@ static const struct hwmon_ops thermal_hwmon_ops = { > > .read = thermal_hwmon_read, > > }; > > -static const struct hwmon_channel_info *thermal_hwmon_info[] = { > > +static const struct hwmon_channel_info * const thermal_hwmon_info[] = { > > HWMON_CHANNEL_INFO(temp, HWMON_T_INPUT | HWMON_T_EMERGENCY | > > HWMON_T_MAX | HWMON_T_MAX_ALARM | > > HWMON_T_CRIT | HWMON_T_CRIT_ALARM), > > @@ -465,7 +465,7 @@ static const struct hwmon_ops power_hwmon_ops = { > > .write = power_hwmon_write, > > }; > > -static const struct hwmon_channel_info *power_hwmon_info[] = { > > +static const struct hwmon_channel_info * const power_hwmon_info[] = { > > HWMON_CHANNEL_INFO(power, HWMON_P_INPUT | > > HWMON_P_MAX | HWMON_P_MAX_ALARM | > > HWMON_P_CRIT | HWMON_P_CRIT_ALARM), >
diff --git a/drivers/fpga/dfl-fme-main.c b/drivers/fpga/dfl-fme-main.c index 77ea04d4edbe..bcb5d34b3b82 100644 --- a/drivers/fpga/dfl-fme-main.c +++ b/drivers/fpga/dfl-fme-main.c @@ -265,7 +265,7 @@ static const struct hwmon_ops thermal_hwmon_ops = { .read = thermal_hwmon_read, }; -static const struct hwmon_channel_info *thermal_hwmon_info[] = { +static const struct hwmon_channel_info * const thermal_hwmon_info[] = { HWMON_CHANNEL_INFO(temp, HWMON_T_INPUT | HWMON_T_EMERGENCY | HWMON_T_MAX | HWMON_T_MAX_ALARM | HWMON_T_CRIT | HWMON_T_CRIT_ALARM), @@ -465,7 +465,7 @@ static const struct hwmon_ops power_hwmon_ops = { .write = power_hwmon_write, }; -static const struct hwmon_channel_info *power_hwmon_info[] = { +static const struct hwmon_channel_info * const power_hwmon_info[] = { HWMON_CHANNEL_INFO(power, HWMON_P_INPUT | HWMON_P_MAX | HWMON_P_MAX_ALARM | HWMON_P_CRIT | HWMON_P_CRIT_ALARM),
Statically allocated array of pointed to hwmon_channel_info can be made const for safety. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- This depends on hwmon core patch: https://lore.kernel.org/all/20230406203103.3011503-2-krzysztof.kozlowski@linaro.org/ Therefore I propose this should also go via hwmon tree. Cc: Jean Delvare <jdelvare@suse.com> Cc: Guenter Roeck <linux@roeck-us.net> Cc: linux-hwmon@vger.kernel.org --- drivers/fpga/dfl-fme-main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)