| Message ID | 20230405080152.6732-2-ilpo.jarvinen@linux.intel.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | Manage register access to control delay during sec update | expand |
On 4/5/23 01:01, Ilpo Järvinen wrote: > Create INTEL_M10_BMC_CORE namespace for symbols exported by > intel-m10-bmc-core. Reviewed-by: Russ Weight <russell.h.weight@intel.com> > Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> > --- > drivers/mfd/intel-m10-bmc-core.c | 2 +- > drivers/mfd/intel-m10-bmc-pmci.c | 1 + > drivers/mfd/intel-m10-bmc-spi.c | 1 + > 3 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/mfd/intel-m10-bmc-core.c b/drivers/mfd/intel-m10-bmc-core.c > index dac9cf7bcb4a..b94412813887 100644 > --- a/drivers/mfd/intel-m10-bmc-core.c > +++ b/drivers/mfd/intel-m10-bmc-core.c > @@ -98,7 +98,7 @@ const struct attribute_group *m10bmc_dev_groups[] = { > &m10bmc_group, > NULL, > }; > -EXPORT_SYMBOL_GPL(m10bmc_dev_groups); > +EXPORT_SYMBOL_NS_GPL(m10bmc_dev_groups, INTEL_M10_BMC_CORE); > > int m10bmc_dev_init(struct intel_m10bmc *m10bmc, const struct intel_m10bmc_platform_info *info) > { > diff --git a/drivers/mfd/intel-m10-bmc-pmci.c b/drivers/mfd/intel-m10-bmc-pmci.c > index 8821f1876dd6..0392ef8b57d8 100644 > --- a/drivers/mfd/intel-m10-bmc-pmci.c > +++ b/drivers/mfd/intel-m10-bmc-pmci.c > @@ -453,3 +453,4 @@ module_dfl_driver(m10bmc_pmci_driver); > MODULE_DESCRIPTION("MAX10 BMC PMCI-based interface"); > MODULE_AUTHOR("Intel Corporation"); > MODULE_LICENSE("GPL"); > +MODULE_IMPORT_NS(INTEL_M10_BMC_CORE); > diff --git a/drivers/mfd/intel-m10-bmc-spi.c b/drivers/mfd/intel-m10-bmc-spi.c > index 957200e17fed..edd266557ab9 100644 > --- a/drivers/mfd/intel-m10-bmc-spi.c > +++ b/drivers/mfd/intel-m10-bmc-spi.c > @@ -166,3 +166,4 @@ MODULE_DESCRIPTION("Intel MAX 10 BMC SPI bus interface"); > MODULE_AUTHOR("Intel Corporation"); > MODULE_LICENSE("GPL v2"); > MODULE_ALIAS("spi:intel-m10-bmc"); > +MODULE_IMPORT_NS(INTEL_M10_BMC_CORE);
On 2023-04-05 at 11:01:49 +0300, Ilpo Järvinen wrote: > Create INTEL_M10_BMC_CORE namespace for symbols exported by > intel-m10-bmc-core. Is it necessary for handshake register, or just an independent improvement? > > Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> > --- > drivers/mfd/intel-m10-bmc-core.c | 2 +- > drivers/mfd/intel-m10-bmc-pmci.c | 1 + > drivers/mfd/intel-m10-bmc-spi.c | 1 + > 3 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/mfd/intel-m10-bmc-core.c b/drivers/mfd/intel-m10-bmc-core.c > index dac9cf7bcb4a..b94412813887 100644 > --- a/drivers/mfd/intel-m10-bmc-core.c > +++ b/drivers/mfd/intel-m10-bmc-core.c > @@ -98,7 +98,7 @@ const struct attribute_group *m10bmc_dev_groups[] = { > &m10bmc_group, > NULL, > }; > -EXPORT_SYMBOL_GPL(m10bmc_dev_groups); > +EXPORT_SYMBOL_NS_GPL(m10bmc_dev_groups, INTEL_M10_BMC_CORE); > > int m10bmc_dev_init(struct intel_m10bmc *m10bmc, const struct intel_m10bmc_platform_info *info) Why this function is not included in namespace? Thanks, Yilun > { > diff --git a/drivers/mfd/intel-m10-bmc-pmci.c b/drivers/mfd/intel-m10-bmc-pmci.c > index 8821f1876dd6..0392ef8b57d8 100644 > --- a/drivers/mfd/intel-m10-bmc-pmci.c > +++ b/drivers/mfd/intel-m10-bmc-pmci.c > @@ -453,3 +453,4 @@ module_dfl_driver(m10bmc_pmci_driver); > MODULE_DESCRIPTION("MAX10 BMC PMCI-based interface"); > MODULE_AUTHOR("Intel Corporation"); > MODULE_LICENSE("GPL"); > +MODULE_IMPORT_NS(INTEL_M10_BMC_CORE); > diff --git a/drivers/mfd/intel-m10-bmc-spi.c b/drivers/mfd/intel-m10-bmc-spi.c > index 957200e17fed..edd266557ab9 100644 > --- a/drivers/mfd/intel-m10-bmc-spi.c > +++ b/drivers/mfd/intel-m10-bmc-spi.c > @@ -166,3 +166,4 @@ MODULE_DESCRIPTION("Intel MAX 10 BMC SPI bus interface"); > MODULE_AUTHOR("Intel Corporation"); > MODULE_LICENSE("GPL v2"); > MODULE_ALIAS("spi:intel-m10-bmc"); > +MODULE_IMPORT_NS(INTEL_M10_BMC_CORE); > -- > 2.30.2 >
On Fri, 7 Apr 2023, Xu Yilun wrote: > On 2023-04-05 at 11:01:49 +0300, Ilpo Järvinen wrote: > > Create INTEL_M10_BMC_CORE namespace for symbols exported by > > intel-m10-bmc-core. > > Is it necessary for handshake register, or just an independent > improvement? It's independent improvement. > > Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> > > --- > > drivers/mfd/intel-m10-bmc-core.c | 2 +- > > drivers/mfd/intel-m10-bmc-pmci.c | 1 + > > drivers/mfd/intel-m10-bmc-spi.c | 1 + > > 3 files changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/mfd/intel-m10-bmc-core.c b/drivers/mfd/intel-m10-bmc-core.c > > index dac9cf7bcb4a..b94412813887 100644 > > --- a/drivers/mfd/intel-m10-bmc-core.c > > +++ b/drivers/mfd/intel-m10-bmc-core.c > > @@ -98,7 +98,7 @@ const struct attribute_group *m10bmc_dev_groups[] = { > > &m10bmc_group, > > NULL, > > }; > > -EXPORT_SYMBOL_GPL(m10bmc_dev_groups); > > +EXPORT_SYMBOL_NS_GPL(m10bmc_dev_groups, INTEL_M10_BMC_CORE); > > > > int m10bmc_dev_init(struct intel_m10bmc *m10bmc, const struct intel_m10bmc_platform_info *info) > > Why this function is not included in namespace? It was not left out on purpose, I'll add it there.
diff --git a/drivers/mfd/intel-m10-bmc-core.c b/drivers/mfd/intel-m10-bmc-core.c index dac9cf7bcb4a..b94412813887 100644 --- a/drivers/mfd/intel-m10-bmc-core.c +++ b/drivers/mfd/intel-m10-bmc-core.c @@ -98,7 +98,7 @@ const struct attribute_group *m10bmc_dev_groups[] = { &m10bmc_group, NULL, }; -EXPORT_SYMBOL_GPL(m10bmc_dev_groups); +EXPORT_SYMBOL_NS_GPL(m10bmc_dev_groups, INTEL_M10_BMC_CORE); int m10bmc_dev_init(struct intel_m10bmc *m10bmc, const struct intel_m10bmc_platform_info *info) { diff --git a/drivers/mfd/intel-m10-bmc-pmci.c b/drivers/mfd/intel-m10-bmc-pmci.c index 8821f1876dd6..0392ef8b57d8 100644 --- a/drivers/mfd/intel-m10-bmc-pmci.c +++ b/drivers/mfd/intel-m10-bmc-pmci.c @@ -453,3 +453,4 @@ module_dfl_driver(m10bmc_pmci_driver); MODULE_DESCRIPTION("MAX10 BMC PMCI-based interface"); MODULE_AUTHOR("Intel Corporation"); MODULE_LICENSE("GPL"); +MODULE_IMPORT_NS(INTEL_M10_BMC_CORE); diff --git a/drivers/mfd/intel-m10-bmc-spi.c b/drivers/mfd/intel-m10-bmc-spi.c index 957200e17fed..edd266557ab9 100644 --- a/drivers/mfd/intel-m10-bmc-spi.c +++ b/drivers/mfd/intel-m10-bmc-spi.c @@ -166,3 +166,4 @@ MODULE_DESCRIPTION("Intel MAX 10 BMC SPI bus interface"); MODULE_AUTHOR("Intel Corporation"); MODULE_LICENSE("GPL v2"); MODULE_ALIAS("spi:intel-m10-bmc"); +MODULE_IMPORT_NS(INTEL_M10_BMC_CORE);
Create INTEL_M10_BMC_CORE namespace for symbols exported by intel-m10-bmc-core. Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> --- drivers/mfd/intel-m10-bmc-core.c | 2 +- drivers/mfd/intel-m10-bmc-pmci.c | 1 + drivers/mfd/intel-m10-bmc-spi.c | 1 + 3 files changed, 3 insertions(+), 1 deletion(-)