| Message ID | 20230404164828.8031-6-quic_devipriy@quicinc.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Add PCIe support for IPQ9574 | expand |
On 04/04/2023 18:48, Devi Priya wrote: > Add bindings for PCIe hosts on IPQ9574 platform and allow > msi-parent property Missing full stop. Also in your other patches. > > Signed-off-by: Devi Priya <quic_devipriy@quicinc.com> > --- > Changes in V2: > - Updated the commit message and dropped the aggr_noc entries > as it will be handled via interconnect driver > > .../devicetree/bindings/pci/qcom,pcie.yaml | 48 +++++++++++++++++++ > 1 file changed, 48 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > index fb32c43dd12d..8657ab65008c 100644 > --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > @@ -26,6 +26,7 @@ properties: > - qcom,pcie-ipq8064-v2 > - qcom,pcie-ipq8074 > - qcom,pcie-ipq8074-gen3 > + - qcom,pcie-ipq9574 > - qcom,pcie-msm8996 > - qcom,pcie-qcs404 > - qcom,pcie-sa8540p > @@ -105,6 +106,8 @@ properties: > items: > - const: pciephy > > + msi-parent: true Isn't this conflicting with Mani's series: https://lore.kernel.org/all/20230108203340.GA229573-robh@kernel.org/ https://lore.kernel.org/all/20230111123004.21048-1-manivannan.sadhasivam@linaro.org/#t Although for some reason Mani's patch references non-existing commit and hunk... Best regards, Krzysztof
On 4/5/2023 12:28 PM, Krzysztof Kozlowski wrote: > On 04/04/2023 18:48, Devi Priya wrote: >> Add bindings for PCIe hosts on IPQ9574 platform and allow >> msi-parent property > > Missing full stop. Also in your other patches. Okay > >> >> Signed-off-by: Devi Priya <quic_devipriy@quicinc.com> >> --- >> Changes in V2: >> - Updated the commit message and dropped the aggr_noc entries >> as it will be handled via interconnect driver >> >> .../devicetree/bindings/pci/qcom,pcie.yaml | 48 +++++++++++++++++++ >> 1 file changed, 48 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml >> index fb32c43dd12d..8657ab65008c 100644 >> --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml >> +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml >> @@ -26,6 +26,7 @@ properties: >> - qcom,pcie-ipq8064-v2 >> - qcom,pcie-ipq8074 >> - qcom,pcie-ipq8074-gen3 >> + - qcom,pcie-ipq9574 >> - qcom,pcie-msm8996 >> - qcom,pcie-qcs404 >> - qcom,pcie-sa8540p >> @@ -105,6 +106,8 @@ properties: >> items: >> - const: pciephy >> >> + msi-parent: true > Yes right, will rebase it on Mani's series. But, as you have pointed out don't see the binding changes in linux-next/master Mani, could you please provide the tree details onto which the binding change is merged? > Isn't this conflicting with Mani's series: > https://lore.kernel.org/all/20230108203340.GA229573-robh@kernel.org/ > https://lore.kernel.org/all/20230111123004.21048-1-manivannan.sadhasivam@linaro.org/#t > > Although for some reason Mani's patch references non-existing commit and > hunk... > > Best regards, > Krzysztof > Best Regards, Devi Priya
On Tue, Apr 11, 2023 at 04:27:23PM +0530, Devi Priya wrote: > > > On 4/5/2023 12:28 PM, Krzysztof Kozlowski wrote: > > On 04/04/2023 18:48, Devi Priya wrote: > > > Add bindings for PCIe hosts on IPQ9574 platform and allow > > > msi-parent property > > > > Missing full stop. Also in your other patches. > Okay > > > > > > > > Signed-off-by: Devi Priya <quic_devipriy@quicinc.com> > > > --- > > > Changes in V2: > > > - Updated the commit message and dropped the aggr_noc entries > > > as it will be handled via interconnect driver > > > > > > .../devicetree/bindings/pci/qcom,pcie.yaml | 48 +++++++++++++++++++ > > > 1 file changed, 48 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > > > index fb32c43dd12d..8657ab65008c 100644 > > > --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > > > +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > > > @@ -26,6 +26,7 @@ properties: > > > - qcom,pcie-ipq8064-v2 > > > - qcom,pcie-ipq8074 > > > - qcom,pcie-ipq8074-gen3 > > > + - qcom,pcie-ipq9574 > > > - qcom,pcie-msm8996 > > > - qcom,pcie-qcs404 > > > - qcom,pcie-sa8540p > > > @@ -105,6 +106,8 @@ properties: > > > items: > > > - const: pciephy > > > + msi-parent: true > > > > Yes right, will rebase it on Mani's series. > But, as you have pointed out don't see the binding changes > in linux-next/master > Mani, could you please provide the tree details onto which the > binding change is merged? > Looks like the initial msi-map binding's patch [1] never got merged even though the dts patch went in. I'll squash the later fix to this, post v4 and CC you. - Mani [1] https://lore.kernel.org/all/20230102105821.28243-3-manivannan.sadhasivam@linaro.org/ > > Isn't this conflicting with Mani's series: > > https://lore.kernel.org/all/20230108203340.GA229573-robh@kernel.org/ > > https://lore.kernel.org/all/20230111123004.21048-1-manivannan.sadhasivam@linaro.org/#t > > > > Although for some reason Mani's patch references non-existing commit and > > hunk... > > > > Best regards, > > Krzysztof > > > Best Regards, > Devi Priya
On 4/11/2023 5:22 PM, Manivannan Sadhasivam wrote: > On Tue, Apr 11, 2023 at 04:27:23PM +0530, Devi Priya wrote: >> >> >> On 4/5/2023 12:28 PM, Krzysztof Kozlowski wrote: >>> On 04/04/2023 18:48, Devi Priya wrote: >>>> Add bindings for PCIe hosts on IPQ9574 platform and allow >>>> msi-parent property >>> >>> Missing full stop. Also in your other patches. >> Okay >>> >>>> >>>> Signed-off-by: Devi Priya <quic_devipriy@quicinc.com> >>>> --- >>>> Changes in V2: >>>> - Updated the commit message and dropped the aggr_noc entries >>>> as it will be handled via interconnect driver >>>> >>>> .../devicetree/bindings/pci/qcom,pcie.yaml | 48 +++++++++++++++++++ >>>> 1 file changed, 48 insertions(+) >>>> >>>> diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml >>>> index fb32c43dd12d..8657ab65008c 100644 >>>> --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml >>>> +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml >>>> @@ -26,6 +26,7 @@ properties: >>>> - qcom,pcie-ipq8064-v2 >>>> - qcom,pcie-ipq8074 >>>> - qcom,pcie-ipq8074-gen3 >>>> + - qcom,pcie-ipq9574 >>>> - qcom,pcie-msm8996 >>>> - qcom,pcie-qcs404 >>>> - qcom,pcie-sa8540p >>>> @@ -105,6 +106,8 @@ properties: >>>> items: >>>> - const: pciephy >>>> + msi-parent: true >>> >> >> Yes right, will rebase it on Mani's series. >> But, as you have pointed out don't see the binding changes >> in linux-next/master >> Mani, could you please provide the tree details onto which the >> binding change is merged? >> > > Looks like the initial msi-map binding's patch [1] never got merged even though > the dts patch went in. > > I'll squash the later fix to this, post v4 and CC you. Thanks for that..I could see V4 posted! > > - Mani > > [1] https://lore.kernel.org/all/20230102105821.28243-3-manivannan.sadhasivam@linaro.org/ > >>> Isn't this conflicting with Mani's series: >>> https://lore.kernel.org/all/20230108203340.GA229573-robh@kernel.org/ >>> https://lore.kernel.org/all/20230111123004.21048-1-manivannan.sadhasivam@linaro.org/#t >>> >>> Although for some reason Mani's patch references non-existing commit and >>> hunk... >>> >>> Best regards, >>> Krzysztof >>> >> Best Regards, >> Devi Priya >
diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml index fb32c43dd12d..8657ab65008c 100644 --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml @@ -26,6 +26,7 @@ properties: - qcom,pcie-ipq8064-v2 - qcom,pcie-ipq8074 - qcom,pcie-ipq8074-gen3 + - qcom,pcie-ipq9574 - qcom,pcie-msm8996 - qcom,pcie-qcs404 - qcom,pcie-sa8540p @@ -105,6 +106,8 @@ properties: items: - const: pciephy + msi-parent: true + power-domains: maxItems: 1 @@ -160,6 +163,7 @@ allOf: enum: - qcom,pcie-ipq6018 - qcom,pcie-ipq8074-gen3 + - qcom,pcie-ipq9574 then: properties: reg: @@ -365,6 +369,39 @@ allOf: - const: ahb # AHB Reset - const: axi_m_sticky # AXI Master Sticky reset + - if: + properties: + compatible: + contains: + enum: + - qcom,pcie-ipq9574 + then: + properties: + clocks: + minItems: 6 + maxItems: 6 + clock-names: + items: + - const: ahb # AHB clock + - const: aux # Auxiliary clock + - const: axi_m # AXI Master clock + - const: axi_s # AXI Slave clock + - const: axi_bridge # AXI bridge clock + - const: rchng + resets: + minItems: 8 + maxItems: 8 + reset-names: + items: + - const: pipe # PIPE reset + - const: sticky # Core Sticky reset + - const: axi_s_sticky # AXI Slave Sticky reset + - const: axi_s # AXI Slave reset + - const: axi_m_sticky # AXI Master Sticky reset + - const: axi_m # AXI Master reset + - const: aux # AUX Reset + - const: ahb # AHB Reset + - if: properties: compatible: @@ -681,6 +718,16 @@ allOf: - interconnects - interconnect-names + - if: + properties: + compatible: + contains: + enum: + - qcom,pcie-ipq9574 + then: + required: + - msi-parent + - if: not: properties: @@ -693,6 +740,7 @@ allOf: - qcom,pcie-ipq8064v2 - qcom,pcie-ipq8074 - qcom,pcie-ipq8074-gen3 + - qcom,pcie-ipq9574 - qcom,pcie-qcs404 then: required:
Add bindings for PCIe hosts on IPQ9574 platform and allow msi-parent property Signed-off-by: Devi Priya <quic_devipriy@quicinc.com> --- Changes in V2: - Updated the commit message and dropped the aggr_noc entries as it will be handled via interconnect driver .../devicetree/bindings/pci/qcom,pcie.yaml | 48 +++++++++++++++++++ 1 file changed, 48 insertions(+)