| Message ID | 20230413071424.3273490-7-jens.wiklander@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Xen FF-A mediator | expand |
Hi Jens, > -----Original Message----- > Subject: [XEN PATCH v8 06/22] xen/arm: ffa: add defines for framework direct > request/response messages > > Adds defines for framework direct request/response messages. Same here, it actually took me a while to find the related chapters about this patch, so I would suggest that we can add more details about where the values are from. From the spec that I referred to (DEN0077A version 1.1 REL0), they are in section 18.3, Table 18.{21, 25, 26, 27,28}. > > Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org> I confirm the values introduced by this patch are consistent with the above spec, hence: Reviewed-by: Henry Wang <Henry.Wang@arm.com> Kind regards, Henry
Hi Henry, On Thu, Apr 13, 2023 at 12:51 PM Henry Wang <Henry.Wang@arm.com> wrote: > > Hi Jens, > > > -----Original Message----- > > Subject: [XEN PATCH v8 06/22] xen/arm: ffa: add defines for framework direct > > request/response messages > > > > Adds defines for framework direct request/response messages. > > Same here, it actually took me a while to find the related chapters > about this patch, so I would suggest that we can add more details > about where the values are from. > > From the spec that I referred to (DEN0077A version 1.1 REL0), they are > in section 18.3, Table 18.{21, 25, 26, 27,28}. OK, I'll add it. > > > > > Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org> > > I confirm the values introduced by this patch are consistent with the > above spec, hence: > > Reviewed-by: Henry Wang <Henry.Wang@arm.com> Thanks, Jens > > Kind regards, > Henry
diff --git a/xen/arch/arm/tee/ffa.c b/xen/arch/arm/tee/ffa.c index 72e7d0575de5..cf7b7545aa03 100644 --- a/xen/arch/arm/tee/ffa.c +++ b/xen/arch/arm/tee/ffa.c @@ -57,6 +57,19 @@ #define FFA_MY_VERSION MAKE_FFA_VERSION(FFA_MY_VERSION_MAJOR, \ FFA_MY_VERSION_MINOR) +/* + * Flags and field values used for the MSG_SEND_DIRECT_REQ/RESP: + * BIT(31): Framework or partition message + * BIT(7-0): Message type for frameworks messages + */ +#define FFA_MSG_FLAG_FRAMEWORK BIT(31, U) +#define FFA_MSG_TYPE_MASK 0xFFU; +#define FFA_MSG_PSCI 0x0U +#define FFA_MSG_SEND_VM_CREATED 0x4U +#define FFA_MSG_RESP_VM_CREATED 0x5U +#define FFA_MSG_SEND_VM_DESTROYED 0x6U +#define FFA_MSG_RESP_VM_DESTROYED 0x7U + /* * Flags to determine partition properties in FFA_PARTITION_INFO_GET return * message:
Adds defines for framework direct request/response messages. Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org> --- xen/arch/arm/tee/ffa.c | 13 +++++++++++++ 1 file changed, 13 insertions(+)