| Message ID | 0e48ef5a9558c0bab5c2918af3c15ed4425b07be.1681375949.git.quic_schowdhu@quicinc.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | soc: qcom: boot_stats: Add driver support for boot_stats | expand |
On 13/04/2023 11:28, Souradeep Chowdhury wrote: Thank you for your patch. There is something to discuss/improve. > + "^stats@[0-9a-f]+$": > + type: object > + description: > + Imem region dedicated for storing timestamps related > + information regarding bootstats. > + > + properties: > + compatible: > + items: > + - enum: > + - qcom,sm8450-bootstats > + - const: qcom,imem-bootstats > + > + reg: > + maxItems: 1 > + > + required: > + - compatible > + - reg > + > + additionalProperties: false The feedback about additionalProperties was given in different place. On purpose, because it is easier to read when it is placed before properties for indented cases. Therefore move it after description, how I originally asked. > + > required: > - compatible > - reg Best regards, Krzysztof
On 4/13/2023 10:11 PM, Krzysztof Kozlowski wrote: > On 13/04/2023 11:28, Souradeep Chowdhury wrote: > > Thank you for your patch. There is something to discuss/improve. > >> + "^stats@[0-9a-f]+$": >> + type: object >> + description: >> + Imem region dedicated for storing timestamps related >> + information regarding bootstats. >> + >> + properties: >> + compatible: >> + items: >> + - enum: >> + - qcom,sm8450-bootstats >> + - const: qcom,imem-bootstats >> + >> + reg: >> + maxItems: 1 >> + >> + required: >> + - compatible >> + - reg >> + >> + additionalProperties: false > > The feedback about additionalProperties was given in different place. On > purpose, because it is easier to read when it is placed before > properties for indented cases. Therefore move it after description, how > I originally asked. Ack > >> + >> required: >> - compatible >> - reg > > Best regards, > Krzysztof >
diff --git a/Documentation/devicetree/bindings/sram/qcom,imem.yaml b/Documentation/devicetree/bindings/sram/qcom,imem.yaml index ba694ce..c1e1e9b 100644 --- a/Documentation/devicetree/bindings/sram/qcom,imem.yaml +++ b/Documentation/devicetree/bindings/sram/qcom,imem.yaml @@ -49,6 +49,28 @@ patternProperties: $ref: /schemas/remoteproc/qcom,pil-info.yaml# description: Peripheral image loader relocation region + "^stats@[0-9a-f]+$": + type: object + description: + Imem region dedicated for storing timestamps related + information regarding bootstats. + + properties: + compatible: + items: + - enum: + - qcom,sm8450-bootstats + - const: qcom,imem-bootstats + + reg: + maxItems: 1 + + required: + - compatible + - reg + + additionalProperties: false + required: - compatible - reg
All Qualcomm bootloaders log useful timestamp information related to bootloader stats in the IMEM region. Add the child node within IMEM for the boot stat region containing register address and compatible string. Signed-off-by: Souradeep Chowdhury <quic_schowdhu@quicinc.com> --- .../devicetree/bindings/sram/qcom,imem.yaml | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+)