| Message ID | 20230412112739.160376-23-angelogioacchino.delregno@collabora.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | MediaTek Helio X10 - Mailbox, Display, MMC/SD/SDIO | expand |
On 12/04/2023 13:27, AngeloGioacchino Del Regno wrote: > I have added more than 800 lines to this devicetree: adding myself to > the copyright header. > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > --- > arch/arm64/boot/dts/mediatek/mt6795.dtsi | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt6795.dtsi b/arch/arm64/boot/dts/mediatek/mt6795.dtsi > index 29ca9a7bf0b3..a4c950b65006 100644 > --- a/arch/arm64/boot/dts/mediatek/mt6795.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt6795.dtsi > @@ -2,6 +2,9 @@ > /* > * Copyright (c) 2015 MediaTek Inc. > * Author: Mars.C <mars.cheng@mediatek.com> > + * > + * Copyright (C) 2023 Collabora Ltd. > + * AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Indentation? BTW from what I understand the copyright will be by your employer, Collabora not you, but I'm not an legal expert :) > */ > > #include <dt-bindings/interrupt-controller/irq.h>
Il 12/04/23 14:41, Matthias Brugger ha scritto: > > > On 12/04/2023 13:27, AngeloGioacchino Del Regno wrote: >> I have added more than 800 lines to this devicetree: adding myself to >> the copyright header. >> >> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> >> --- >> arch/arm64/boot/dts/mediatek/mt6795.dtsi | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/mediatek/mt6795.dtsi >> b/arch/arm64/boot/dts/mediatek/mt6795.dtsi >> index 29ca9a7bf0b3..a4c950b65006 100644 >> --- a/arch/arm64/boot/dts/mediatek/mt6795.dtsi >> +++ b/arch/arm64/boot/dts/mediatek/mt6795.dtsi >> @@ -2,6 +2,9 @@ >> /* >> * Copyright (c) 2015 MediaTek Inc. >> * Author: Mars.C <mars.cheng@mediatek.com> >> + * >> + * Copyright (C) 2023 Collabora Ltd. >> + * AngeloGioacchino Del Regno >> <angelogioacchino.delregno@collabora.com> > > Indentation? > > BTW from what I understand the copyright will be by your employer, Collabora not > you, but I'm not an legal expert :) > The copyright *is* by my employer ... but at the same time I'm adding my name, because it's me performing the work. I didn't write (c) myname, but (c) employer, myname - that's ok :-) Or was the comment about the commit description? Should that be reworded? Cheers, Angelo
On 12/04/2023 13:27, AngeloGioacchino Del Regno wrote: > I have added more than 800 lines to this devicetree: adding myself to > the copyright header. > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > --- > arch/arm64/boot/dts/mediatek/mt6795.dtsi | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt6795.dtsi b/arch/arm64/boot/dts/mediatek/mt6795.dtsi > index 29ca9a7bf0b3..a4c950b65006 100644 > --- a/arch/arm64/boot/dts/mediatek/mt6795.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt6795.dtsi > @@ -2,6 +2,9 @@ > /* > * Copyright (c) 2015 MediaTek Inc. > * Author: Mars.C <mars.cheng@mediatek.com> > + * > + * Copyright (C) 2023 Collabora Ltd. > + * AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Copyright is a result of significant changes, thus it is a part of commit(s) making these changes. Adding copyrights in separate commits looks like you are spreading them unjustified. Squash it. Best regards, Krzysztof
Il 14/04/23 10:46, Krzysztof Kozlowski ha scritto: > On 12/04/2023 13:27, AngeloGioacchino Del Regno wrote: >> I have added more than 800 lines to this devicetree: adding myself to >> the copyright header. >> >> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> >> --- >> arch/arm64/boot/dts/mediatek/mt6795.dtsi | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/mediatek/mt6795.dtsi b/arch/arm64/boot/dts/mediatek/mt6795.dtsi >> index 29ca9a7bf0b3..a4c950b65006 100644 >> --- a/arch/arm64/boot/dts/mediatek/mt6795.dtsi >> +++ b/arch/arm64/boot/dts/mediatek/mt6795.dtsi >> @@ -2,6 +2,9 @@ >> /* >> * Copyright (c) 2015 MediaTek Inc. >> * Author: Mars.C <mars.cheng@mediatek.com> >> + * >> + * Copyright (C) 2023 Collabora Ltd. >> + * AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > > Copyright is a result of significant changes, thus it is a part of > commit(s) making these changes. Adding copyrights in separate commits > looks like you are spreading them unjustified. Squash it. > Ok, I'll squash it in one of the commits of this series. Regards, Angelo
diff --git a/arch/arm64/boot/dts/mediatek/mt6795.dtsi b/arch/arm64/boot/dts/mediatek/mt6795.dtsi index 29ca9a7bf0b3..a4c950b65006 100644 --- a/arch/arm64/boot/dts/mediatek/mt6795.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt6795.dtsi @@ -2,6 +2,9 @@ /* * Copyright (c) 2015 MediaTek Inc. * Author: Mars.C <mars.cheng@mediatek.com> + * + * Copyright (C) 2023 Collabora Ltd. + * AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> */ #include <dt-bindings/interrupt-controller/irq.h>
I have added more than 800 lines to this devicetree: adding myself to the copyright header. Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> --- arch/arm64/boot/dts/mediatek/mt6795.dtsi | 3 +++ 1 file changed, 3 insertions(+)