| Message ID | 1681468167-11689-1-git-send-email-quic_srichara@quicinc.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Add minimal boot support for IPQ5018 | expand |
On 14.04.2023 12:29, Sricharan Ramabadhran wrote: > Add support for the global clock controller found on IPQ5018 > based devices. > > Co-developed-by: Varadarajan Narayanan <quic_varada@quicinc.com> > Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> > Co-developed-by: Gokul Sriram Palanisamy <quic_gokulsri@quicinc.com> > Signed-off-by: Gokul Sriram Palanisamy <quic_gokulsri@quicinc.com> > Signed-off-by: Sricharan Ramabadhran <quic_srichara@quicinc.com> > --- [...] > + .name = "adss_pwm_clk_src", > + .parent_data = gcc_xo_gpll0, > + .num_parents = 2, ARRAY_SIZE(), everywhere where you reference parent_data [...] > +MODULE_DESCRIPTION("Qualcomm Technologies, Inc. GCC IPQ5018 Driver"); > +MODULE_LICENSE("GPL v2"); "GPL" Konrad
On 4/14/2023 4:59 PM, Konrad Dybcio wrote: > > > On 14.04.2023 12:29, Sricharan Ramabadhran wrote: >> Add support for the global clock controller found on IPQ5018 >> based devices. >> >> Co-developed-by: Varadarajan Narayanan <quic_varada@quicinc.com> >> Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> >> Co-developed-by: Gokul Sriram Palanisamy <quic_gokulsri@quicinc.com> >> Signed-off-by: Gokul Sriram Palanisamy <quic_gokulsri@quicinc.com> >> Signed-off-by: Sricharan Ramabadhran <quic_srichara@quicinc.com> >> --- > [...] > >> + .name = "adss_pwm_clk_src", >> + .parent_data = gcc_xo_gpll0, >> + .num_parents = 2, > ARRAY_SIZE(), everywhere where you reference parent_data > ok. > [...] > >> +MODULE_DESCRIPTION("Qualcomm Technologies, Inc. GCC IPQ5018 Driver"); >> +MODULE_LICENSE("GPL v2"); > "GPL" ok, will fix. Regards, Sricharan
On 14/04/2023 12:29, Sricharan Ramabadhran wrote: > The IPQ5018 is Qualcomm's 802.11ax SoC for Routers, > Gateways and Access Points. > > This series adds minimal board boot support for ipq5018-mp03.1-c2 board. > > [v3] > Fixed all comments for clocks, schema fixes > Picked up Reviewed-by from Bjorn for pinctrl driver Didn't you just ignore all the tags you got? I was already acking and reviewing a lot of these... Best regards, Krzysztof
Hi Krysztof, On 4/16/2023 2:37 PM, Krzysztof Kozlowski wrote: > On 14/04/2023 12:29, Sricharan Ramabadhran wrote: >> The IPQ5018 is Qualcomm's 802.11ax SoC for Routers, >> Gateways and Access Points. >> >> This series adds minimal board boot support for ipq5018-mp03.1-c2 board. >> >> [v3] >> Fixed all comments for clocks, schema fixes >> Picked up Reviewed-by from Bjorn for pinctrl driver > > Didn't you just ignore all the tags you got? I was already acking and > reviewing a lot of these... > While i got review comments for V2, only one tag from Bjorn (reviewed-by) for the pinctrl driver. That one i picked. Regards, Sricharan
The IPQ5018 is Qualcomm's 802.11ax SoC for Routers, Gateways and Access Points. This series adds minimal board boot support for ipq5018-mp03.1-c2 board. [v3] Fixed all comments for clocks, schema fixes Picked up Reviewed-by from Bjorn for pinctrl driver [v2] Fixed all comments and rebased for TOT. Sricharan Ramabadhran (9): dt-bindings: arm64: Add IPQ5018 clock and reset clk: qcom: Add Global Clock controller (GCC) driver for IPQ5018 dt-bindings: pinctrl: qcom: Add support for ipq5018 pinctrl: qcom: Add IPQ5018 pinctrl driver dt-bindings: qcom: Add ipq5018 bindings dt-bindings: firmware: document IPQ5018 SCM dt-bindings: mmc: sdhci-msm: Document the IPQ5018 compatible arm64: dts: Add ipq5018 SoC and rdp432-c2 board support arm64: defconfig: Enable IPQ5018 SoC base configs Documentation/devicetree/bindings/arm/qcom.yaml | 7 + .../bindings/clock/qcom,ipq5018-gcc.yaml | 63 + .../devicetree/bindings/firmware/qcom,scm.yaml | 1 + .../devicetree/bindings/mmc/sdhci-msm.yaml | 1 + .../bindings/pinctrl/qcom,ipq5018-tlmm.yaml | 129 + arch/arm64/boot/dts/qcom/Makefile | 1 + arch/arm64/boot/dts/qcom/ipq5018-rdp432-c2.dts | 72 + arch/arm64/boot/dts/qcom/ipq5018.dtsi | 248 ++ arch/arm64/configs/defconfig | 3 + drivers/clk/qcom/Kconfig | 7 + drivers/clk/qcom/Makefile | 1 + drivers/clk/qcom/gcc-ipq5018.c | 3731 ++++++++++++++++++++ drivers/pinctrl/qcom/Kconfig | 10 + drivers/pinctrl/qcom/Makefile | 1 + drivers/pinctrl/qcom/pinctrl-ipq5018.c | 791 +++++ include/dt-bindings/clock/qcom,gcc-ipq5018.h | 183 + include/dt-bindings/reset/qcom,gcc-ipq5018.h | 122 + 17 files changed, 5371 insertions(+) create mode 100644 Documentation/devicetree/bindings/clock/qcom,ipq5018-gcc.yaml create mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,ipq5018-tlmm.yaml create mode 100644 arch/arm64/boot/dts/qcom/ipq5018-rdp432-c2.dts create mode 100644 arch/arm64/boot/dts/qcom/ipq5018.dtsi create mode 100644 drivers/clk/qcom/gcc-ipq5018.c create mode 100644 drivers/pinctrl/qcom/pinctrl-ipq5018.c create mode 100644 include/dt-bindings/clock/qcom,gcc-ipq5018.h create mode 100644 include/dt-bindings/reset/qcom,gcc-ipq5018.h