| Message ID | 20230414-rpmsg-wwan-secondary-at-port-v1-1-6d7307527911@nayarsystems.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | net: wwan: Expose secondary AT port on DATA1 | expand |
On Fri, Apr 14, 2023 at 01:07:40PM +0200, Jaime Breva via B4 Relay wrote: > From: Jaime Breva <jbreva@nayarsystems.com> > > Our use-case needs two AT ports available: > One for running a ppp daemon, and another one for management > > This patch enables a second AT port on DATA1 > > Signed-off-by: Jaime Breva <jbreva@nayarsystems.com> Acked-by: Stephan Gerhold <stephan@gerhold.net> Thanks, Stephan > --- > drivers/net/wwan/rpmsg_wwan_ctrl.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/wwan/rpmsg_wwan_ctrl.c b/drivers/net/wwan/rpmsg_wwan_ctrl.c > index 31c24420ab2e..e964bdeea2b3 100644 > --- a/drivers/net/wwan/rpmsg_wwan_ctrl.c > +++ b/drivers/net/wwan/rpmsg_wwan_ctrl.c > @@ -149,6 +149,7 @@ static const struct rpmsg_device_id rpmsg_wwan_ctrl_id_table[] = { > /* RPMSG channels for Qualcomm SoCs with integrated modem */ > { .name = "DATA5_CNTL", .driver_data = WWAN_PORT_QMI }, > { .name = "DATA4", .driver_data = WWAN_PORT_AT }, > + { .name = "DATA1", .driver_data = WWAN_PORT_AT }, > {}, > }; > MODULE_DEVICE_TABLE(rpmsg, rpmsg_wwan_ctrl_id_table); > > --- > base-commit: c9c3395d5e3dcc6daee66c6908354d47bf98cb0c > change-id: 20230414-rpmsg-wwan-secondary-at-port-db72a66ce74a > > Best regards, > -- > Jaime Breva <jbreva@nayarsystems.com> >
Hello, On Fri, 14 Apr 2023 at 13:09, Jaime Breva via B4 Relay <devnull+jbreva.nayarsystems.com@kernel.org> wrote: > > From: Jaime Breva <jbreva@nayarsystems.com> > > Our use-case needs two AT ports available: > One for running a ppp daemon, and another one for management > > This patch enables a second AT port on DATA1 > > Signed-off-by: Jaime Breva <jbreva@nayarsystems.com> > --- Could you fix your subject prefix to be compliant with netdev list [1], and also probably target net-next. [1] https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html Regards, Loic > drivers/net/wwan/rpmsg_wwan_ctrl.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/wwan/rpmsg_wwan_ctrl.c b/drivers/net/wwan/rpmsg_wwan_ctrl.c > index 31c24420ab2e..e964bdeea2b3 100644 > --- a/drivers/net/wwan/rpmsg_wwan_ctrl.c > +++ b/drivers/net/wwan/rpmsg_wwan_ctrl.c > @@ -149,6 +149,7 @@ static const struct rpmsg_device_id rpmsg_wwan_ctrl_id_table[] = { > /* RPMSG channels for Qualcomm SoCs with integrated modem */ > { .name = "DATA5_CNTL", .driver_data = WWAN_PORT_QMI }, > { .name = "DATA4", .driver_data = WWAN_PORT_AT }, > + { .name = "DATA1", .driver_data = WWAN_PORT_AT }, > {}, > }; > MODULE_DEVICE_TABLE(rpmsg, rpmsg_wwan_ctrl_id_table); > > --- > base-commit: c9c3395d5e3dcc6daee66c6908354d47bf98cb0c > change-id: 20230414-rpmsg-wwan-secondary-at-port-db72a66ce74a > > Best regards, > -- > Jaime Breva <jbreva@nayarsystems.com> >
diff --git a/drivers/net/wwan/rpmsg_wwan_ctrl.c b/drivers/net/wwan/rpmsg_wwan_ctrl.c index 31c24420ab2e..e964bdeea2b3 100644 --- a/drivers/net/wwan/rpmsg_wwan_ctrl.c +++ b/drivers/net/wwan/rpmsg_wwan_ctrl.c @@ -149,6 +149,7 @@ static const struct rpmsg_device_id rpmsg_wwan_ctrl_id_table[] = { /* RPMSG channels for Qualcomm SoCs with integrated modem */ { .name = "DATA5_CNTL", .driver_data = WWAN_PORT_QMI }, { .name = "DATA4", .driver_data = WWAN_PORT_AT }, + { .name = "DATA1", .driver_data = WWAN_PORT_AT }, {}, }; MODULE_DEVICE_TABLE(rpmsg, rpmsg_wwan_ctrl_id_table);