| Message ID | 20230412081929.173220-1-mschmidt@redhat.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | ice: lower CPU usage with GNSS | expand |
>From: Michal Schmidt <mschmidt@redhat.com> >Sent: Wednesday, April 12, 2023 10:19 AM > >This series lowers the CPU usage of the ice driver when using its >provided /dev/gnss*. > >v2: > - Changed subject of patch 1. Requested by Andrew Lunn. > - Added patch 2 to change the polling interval as recommended by Intel. > - Added patch 3 to remove sq_cmd_timeout as suggested by Simon Horman. > >Michal Schmidt (6): > ice: do not busy-wait to read GNSS data > ice: increase the GNSS data polling interval to 20 ms > ice: remove ice_ctl_q_info::sq_cmd_timeout > ice: sleep, don't busy-wait, for ICE_CTL_Q_SQ_CMD_TIMEOUT > ice: remove unused buffer copy code in ice_sq_send_cmd_retry() > ice: sleep, don't busy-wait, in the SQ send retry loop > > drivers/net/ethernet/intel/ice/ice_common.c | 29 +++++-------- > drivers/net/ethernet/intel/ice/ice_controlq.c | 12 +++--- > drivers/net/ethernet/intel/ice/ice_controlq.h | 3 +- > drivers/net/ethernet/intel/ice/ice_gnss.c | 42 +++++++++---------- > drivers/net/ethernet/intel/ice/ice_gnss.h | 3 +- > 5 files changed, 36 insertions(+), 53 deletions(-) > >-- >2.39.2 In general I couldn't find any issues with the series. Thank you all for suggestions and your work on this. Reviewed-by: Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>
> -----Original Message----- > From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of Michal Schmidt > Sent: Wednesday, April 12, 2023 1:19 AM > To: intel-wired-lan@lists.osuosl.org > Cc: Andrew Lunn <andrew@lunn.ch>; netdev@vger.kernel.org; Brandeburg, Jesse <jesse.brandeburg@intel.com>; Kolacinski, Karol <karol.kolacinski@intel.com>; Nguyen, Anthony L <anthony.l.nguyen@intel.com>; Simon Horman <simon.horman@corigine.com> > Subject: [Intel-wired-lan] [PATCH net-next v2 0/6] ice: lower CPU usage with GNSS > > This series lowers the CPU usage of the ice driver when using its provided /dev/gnss*. > > v2: > - Changed subject of patch 1. Requested by Andrew Lunn. > - Added patch 2 to change the polling interval as recommended by Intel. > - Added patch 3 to remove sq_cmd_timeout as suggested by Simon Horman. > > Michal Schmidt (6): > ice: do not busy-wait to read GNSS data > ice: increase the GNSS data polling interval to 20 ms > ice: remove ice_ctl_q_info::sq_cmd_timeout > ice: sleep, don't busy-wait, for ICE_CTL_Q_SQ_CMD_TIMEOUT > ice: remove unused buffer copy code in ice_sq_send_cmd_retry() > ice: sleep, don't busy-wait, in the SQ send retry loop > > drivers/net/ethernet/intel/ice/ice_common.c | 29 +++++-------- > drivers/net/ethernet/intel/ice/ice_controlq.c | 12 +++--- drivers/net/ethernet/intel/ice/ice_controlq.h | 3 +- > drivers/net/ethernet/intel/ice/ice_gnss.c | 42 +++++++++---------- > drivers/net/ethernet/intel/ice/ice_gnss.h | 3 +- > 5 files changed, 36 insertions(+), 53 deletions(-) > Tested-by: Sunitha Mekala <sunithax.d.mekala@intel.com> (A Contingent worker at Intel)