[v3,0/4] clk: Add basic register clock controller

Message

David Yang April 16, 2023, 7:46 p.m. UTC

These clocks were provided in `include/linux/clk-provider.h`, but lacks DT
bindings. Add DT bindings for them.

v2: split clock controller and its clocks
v3:
  * rewrite commit message
  * rewrite descriptions in dt-bindings to describe the devices
  * fix format error of dt-bindings

Links:
v1: https://lore.kernel.org/r/[e-mail]
v2: https://lore.kernel.org/r/[e-mail]

David Yang (4):
  dt-bindings: clock: Add simple-clock-controller
  clk: Add simple clock controller
  dt-bindings: clock: Add gate-clock
  clk: gate: Add DT binding

 .../devicetree/bindings/clock/gate-clock.yaml |  59 ++++
 .../clock/simple-clock-controller.yaml        |  39 +++
 drivers/clk/Makefile                          |   1 +
 drivers/clk/clk-gate.c                        |  81 +++++
 drivers/clk/clk-of.c                          | 292 ++++++++++++++++++
 drivers/clk/clk-of.h                          |  26 ++
 6 files changed, 498 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/clock/gate-clock.yaml
 create mode 100644 Documentation/devicetree/bindings/clock/simple-clock-controller.yaml
 create mode 100644 drivers/clk/clk-of.c
 create mode 100644 drivers/clk/clk-of.h


base-commit: 7a934f4bd7d6f9da84c8812da3ba42ee10f5778e

Comments

Krzysztof Kozlowski April 17, 2023, 6:27 a.m. UTC | #1

On 16/04/2023 21:46, David Yang wrote:
> These clocks were provided in `include/linux/clk-provider.h`, but lacks DT
> bindings. Add DT bindings for them.
> 
> v2: split clock controller and its clocks

I gave you several comments on v1 and this vague changelog entry
suggests you ignored all of it.

Implement feedback and respond to each one that you ack it or disagree
with it.


Best regards,
Krzysztof

David Yang April 17, 2023, 6:16 p.m. UTC | #2

Krzysztof Kozlowski <[e-mail]> 于2023年4月17日周一 14:27写道：
>
> On 16/04/2023 21:46, David Yang wrote:
> > These clocks were provided in `include/linux/clk-provider.h`, but lacks DT
> > bindings. Add DT bindings for them.
> >
> > v2: split clock controller and its clocks
>
> I gave you several comments on v1 and this vague changelog entry
> suggests you ignored all of it.
>
> Implement feedback and respond to each one that you ack it or disagree
> with it.
>
>
> Best regards,
> Krzysztof
>

All issues have been addressed in v3 patch. I omitted details in
changelog to reduce redundancy. If that is not the proper way to make
response in dt maillist, please let me know.

Responses for each comments in v1 and v2 have been sent against original email.

Rob Herring (Arm) April 18, 2023, 10:29 p.m. UTC | #3

On Tue, Apr 18, 2023 at 02:16:28AM +0800, Yangfl wrote:
> Krzysztof Kozlowski <[e-mail]> 于2023年4月17日周一 14:27写道：
> >
> > On 16/04/2023 21:46, David Yang wrote:
> > > These clocks were provided in `include/linux/clk-provider.h`, but lacks DT
> > > bindings. Add DT bindings for them.
> > >
> > > v2: split clock controller and its clocks
> >
> > I gave you several comments on v1 and this vague changelog entry
> > suggests you ignored all of it.
> >
> > Implement feedback and respond to each one that you ack it or disagree
> > with it.
> >
> >
> > Best regards,
> > Krzysztof
> >
> 
> All issues have been addressed in v3 patch. I omitted details in
> changelog to reduce redundancy. If that is not the proper way to make
> response in dt maillist, please let me know.
> 
> Responses for each comments in v1 and v2 have been sent against original email.

Go look at v1 replies. This series is a hard no.

Rob