mbox series

[v7,0/2] spi: loongson: add bus driver for the loongson spi

Message ID 20230412045152.4694-1-zhuyinbo@loongson.cn (mailing list archive)
Headers show
Series spi: loongson: add bus driver for the loongson spi | expand

Message

Yinbo Zhu April 12, 2023, 4:51 a.m. UTC 
Loongson platform support spi hardware controller and this series patch
was to add spi driver and binding support.

Change in v2:
		1. This [PATCH v2 1/2] dt-bindings patch need depend on clk patch:
	 	   https://
		   lore.kernel.org/all/20230307115022.12846-1-zhuyinbo@loongson.cn/
		2. Remove the clock-names in spi yaml file.
		3. Add "loongson,ls7a-spi" compatible in spi yaml file.
		4. Add an || COMPILE_TEST and drop && PCI then add some CONFIG_PCI
		   macro to limit some pci code.
		5. Make the spi driver top code comment block that use C++ style.
		6. Drop spi->max_speed_hz.
		7. Add a spin_lock for loongson_spi_setup.
		8. Add a timeout and cpu_relax() in loongson_spi_write_read_8bit.
		9. Add spi_transfer_one and drop transfer and rework entire spi
		   driver that include some necessary changes.
		10. Use module_init replace subsys_initcall.
		11. About PM interface that I don't find any issue so I don't add
		    any changes.
Change in v3:
		1. This [PATCH v3 1/2] dt-bindings patch need depend on clk patch:
		   https://
		   lore.kernel.org/all/20230323025229.2971-1-zhuyinbo@loongson.cn/
		2. Drop the unused blank line in loongson,ls-spi.yaml file.
		3. Replace clock minItems with clock maxItems in yaml file.
		4. Separate spi driver into platform module, pci module and core
		   module.
		5. Replace DIV_ROUND_UP with DIV_ROUND_UP_ULL to fix compile error
		   "undefined reference to `__aeabi_uldivmod'" and  "__udivdi3 undefined"
		   that reported by test robot.
		6. Remove the spin lock.
		7. Clear the loongson_spi->hz and loongson_spi->mode in setup to fixup
		   the issue that multiple spi device transfer that maybe cause spi was
		   be misconfigured.
Change in v4:
		1. This [PATCH v4 1/2] dt-bindings patch need depend on clk patch:
		   https://
		   lore.kernel.org/all/20230323025229.2971-1-zhuyinbo@loongson.cn/
		2. Add "#include <linux/io.h>" in spi-loongson-core.c for fix the compile
		   issue which devm_ioremap no declaration.
		3. Add "EXPORT_SYMBOL_GPL(loongson_spi_dev_pm_ops)" in
		   spi-loongson-core.c for fix the compile issue which
		   loongson_spi_dev_pm_ops undefined.
Change in v5:
		1. Get rid of the clock patch's dependency and open-code the clock IDs.
		2. Fixup checkpatch issue that by installed ply and gitpython package
		   locally, but this series of patch's code doesn't have any change.
Change in v6:
		1. Remove the "#include <dt-bindings/clock/loongson,ls2k-clk.h>" in
		   yaml file.
Change in v7:
		1. Remove the "loongson,ls7a-spi" and change yaml file name as
		   "loongson,ls2k-spi.yaml".
		2. Use module_pci_driver and module_platform_driver to replace
		   module_init and module_exit.
		3. Drop ".owner	= THIS_MODULE" in spi platform driver.
		4. Add devm_spi_alloc_master devm_spi_register_master to simplify code.
		5. Add pci_disable_device() in loongson_spi_pci_unregister.

Yinbo Zhu (2):
  dt-bindings: spi: add loongson spi
  spi: loongson: add bus driver for the loongson spi controller

 .../bindings/spi/loongson,ls2k-spi.yaml       |  41 +++
 MAINTAINERS                                   |  10 +
 drivers/spi/Kconfig                           |  31 ++
 drivers/spi/Makefile                          |   3 +
 drivers/spi/spi-loongson-core.c               | 292 ++++++++++++++++++
 drivers/spi/spi-loongson-pci.c                |  72 +++++
 drivers/spi/spi-loongson-plat.c               |  47 +++
 drivers/spi/spi-loongson.h                    |  41 +++
 8 files changed, 537 insertions(+)

Comments

Krzysztof Kozlowski April 14, 2023, 8:43 p.m. UTC | #1 
On 12/04/2023 06:51, Yinbo Zhu wrote:
> Loongson platform support spi hardware controller and this series patch
> was to add spi driver and binding support.
> 
> Change in v2:
> 		1. This [PATCH v2 1/2] dt-bindings patch need depend on clk patch:
> 	 	   https://

Can you stop Ccing fake address "loongson-kernel@lists.loongnix.cn"? It
does not exist. Remove it from all submissions.

Best regards,
Krzysztof
Yinbo Zhu April 18, 2023, 2:53 a.m. UTC | #2 
在 2023/4/15 上午4:43, Krzysztof Kozlowski 写道:
> On 12/04/2023 06:51, Yinbo Zhu wrote:
>> Loongson platform support spi hardware controller and this series patch
>> was to add spi driver and binding support.
>>
>> Change in v2:
>> 		1. This [PATCH v2 1/2] dt-bindings patch need depend on clk patch:
>> 	 	   https://
> 
> Can you stop Ccing fake address "loongson-kernel@lists.loongnix.cn"? It
> does not exist. Remove it from all submissions.Recently, There was some issue with the company's email server, causing
this mail list "loongson-kernel@lists.loongnix.cn" to only accept
internal emails and not accpet external emails. The company's IT is
working to fix this issue. and Ccing this mail list is an internal
requirement.  I will not send emails to this mail list until this email
sever issue is resolved.

Thanks.
> 
> Best regards,
> Krzysztof
>
Krzysztof Kozlowski April 18, 2023, 7:06 a.m. UTC | #3 
On 18/04/2023 04:53, zhuyinbo wrote:
> 
> 
> 在 2023/4/15 上午4:43, Krzysztof Kozlowski 写道:
>> On 12/04/2023 06:51, Yinbo Zhu wrote:
>>> Loongson platform support spi hardware controller and this series patch
>>> was to add spi driver and binding support.
>>>
>>> Change in v2:
>>> 		1. This [PATCH v2 1/2] dt-bindings patch need depend on clk patch:
>>> 	 	   https://
>>
>> Can you stop Ccing fake address "loongson-kernel@lists.loongnix.cn"? It
>> does not exist. Remove it from all submissions.Recently, There was some issue with the company's email server, causing
> this mail list "loongson-kernel@lists.loongnix.cn" to only accept
> internal emails and not accpet external emails. The company's IT is
> working to fix this issue. and Ccing this mail list is an internal
> requirement.  I will not send emails to this mail list until this email
> sever issue is resolved.

You can always Bcc it, if you have such requirement. However your
internal requirements should not cause my removing all the time multiple
bounces...

Best regards,
Krzysztof
Yinbo Zhu April 18, 2023, 11:21 a.m. UTC | #4 
在 2023/4/18 下午3:06, Krzysztof Kozlowski 写道:
> On 18/04/2023 04:53, zhuyinbo wrote:
>>
>>
>> 在 2023/4/15 上午4:43, Krzysztof Kozlowski 写道:
>>> On 12/04/2023 06:51, Yinbo Zhu wrote:
>>>> Loongson platform support spi hardware controller and this series patch
>>>> was to add spi driver and binding support.
>>>>
>>>> Change in v2:
>>>> 		1. This [PATCH v2 1/2] dt-bindings patch need depend on clk patch:
>>>> 	 	   https://
>>>
>>> Can you stop Ccing fake address "loongson-kernel@lists.loongnix.cn"? It
>>> does not exist. Remove it from all submissions.Recently, There was some issue with the company's email server, causing
>> this mail list "loongson-kernel@lists.loongnix.cn" to only accept
>> internal emails and not accpet external emails. The company's IT is
>> working to fix this issue. and Ccing this mail list is an internal
>> requirement.  I will not send emails to this mail list until this email
>> sever issue is resolved.
> 
> You can always Bcc it, if you have such requirement. However your
> internal requirements should not cause my removing all the time multiple
> bounces...
> 

okay, I got it.

Thanks.
> Best regards,
> Krzysztof
>
Yinbo Zhu April 19, 2023, 1:53 a.m. UTC | #5 
在 2023/4/18 下午3:06, Krzysztof Kozlowski 写道:
> On 18/04/2023 04:53, zhuyinbo wrote:
>>
>>
>> 在 2023/4/15 上午4:43, Krzysztof Kozlowski 写道:
>>> On 12/04/2023 06:51, Yinbo Zhu wrote:
>>>> Loongson platform support spi hardware controller and this series patch
>>>> was to add spi driver and binding support.
>>>>
>>>> Change in v2:
>>>> 		1. This [PATCH v2 1/2] dt-bindings patch need depend on clk patch:
>>>> 	 	   https://
>>>
>>> Can you stop Ccing fake address "loongson-kernel@lists.loongnix.cn"? It
>>> does not exist. Remove it from all submissions.Recently, There was some issue with the company's email server, causing
>> this mail list "loongson-kernel@lists.loongnix.cn" to only accept
>> internal emails and not accpet external emails. The company's IT is
>> working to fix this issue. and Ccing this mail list is an internal
>> requirement.  I will not send emails to this mail list until this email
>> sever issue is resolved.
> 
> You can always Bcc it, if you have such requirement. However your
> internal requirements should not cause my removing all the time multiple
> bounces...

The company' IT had fix that mail list server issue and ccing that mail
list "loongson-kernel@lists.loongnix.cn" that will not cause your
removing all the time multiple bounces.

Thanks.
> 
> Best regards,
> Krzysztof
>