| Message ID | 20230415104613.61224-2-jernej.skrabec@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/bridge: dw_hdmi: allow to disable CEC from DT | expand |
On Sat, Apr 15, 2023 at 12:46:11PM +0200, Jernej Skrabec wrote: > Even though some DW-HDMI controllers have perfectly usable HDMI-CEC > implementation, some boards might prefer not to use it or even use > software implementation instead. > > Add property for disabling CEC so driver doesn't expose unused CEC > interface, if CEC pin isn't connected anywhere. Isn't this all true for any bridge supporting CEC? Make this common. > > Signed-off-by: Jernej Skrabec <jernej.skrabec@gmail.com> > --- > .../devicetree/bindings/display/bridge/synopsys,dw-hdmi.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/bridge/synopsys,dw-hdmi.yaml b/Documentation/devicetree/bindings/display/bridge/synopsys,dw-hdmi.yaml > index 4b7e54a8f037..624d32c024f6 100644 > --- a/Documentation/devicetree/bindings/display/bridge/synopsys,dw-hdmi.yaml > +++ b/Documentation/devicetree/bindings/display/bridge/synopsys,dw-hdmi.yaml > @@ -48,6 +48,11 @@ properties: > interrupts: > maxItems: 1 > > + snps,disable-cec: > + $ref: /schemas/types.yaml#/definitions/flag > + description: > + Disable HDMI-CEC. > + > additionalProperties: true > > ... > -- > 2.40.0 >
On 18/04/2023 23:41, Rob Herring wrote: > On Sat, Apr 15, 2023 at 12:46:11PM +0200, Jernej Skrabec wrote: >> Even though some DW-HDMI controllers have perfectly usable HDMI-CEC >> implementation, some boards might prefer not to use it or even use >> software implementation instead. >> >> Add property for disabling CEC so driver doesn't expose unused CEC >> interface, if CEC pin isn't connected anywhere. > > Isn't this all true for any bridge supporting CEC? Make this common. I agree with that, there was a similar case in the past: https://lore.kernel.org/linux-media/20180323125915.13986-1-hverkuil@xs4all.nl/ I never followed up to that, but I believe this is generic for any HDMI transmitter or receiver with built-in CEC support where the CEC line is not actually hooked up to the HDMI pin. There is no way for the CEC driver to detect that, so this has to be communicated in the device tree. For standalone CEC devices you can just disable them in the device tree, of course, but if it is incorporated into the HDMI device itself, then it needs to be told. Regards, Hans > >> >> Signed-off-by: Jernej Skrabec <jernej.skrabec@gmail.com> >> --- >> .../devicetree/bindings/display/bridge/synopsys,dw-hdmi.yaml | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/display/bridge/synopsys,dw-hdmi.yaml b/Documentation/devicetree/bindings/display/bridge/synopsys,dw-hdmi.yaml >> index 4b7e54a8f037..624d32c024f6 100644 >> --- a/Documentation/devicetree/bindings/display/bridge/synopsys,dw-hdmi.yaml >> +++ b/Documentation/devicetree/bindings/display/bridge/synopsys,dw-hdmi.yaml >> @@ -48,6 +48,11 @@ properties: >> interrupts: >> maxItems: 1 >> >> + snps,disable-cec: >> + $ref: /schemas/types.yaml#/definitions/flag >> + description: >> + Disable HDMI-CEC. >> + >> additionalProperties: true >> >> ... >> -- >> 2.40.0 >>
diff --git a/Documentation/devicetree/bindings/display/bridge/synopsys,dw-hdmi.yaml b/Documentation/devicetree/bindings/display/bridge/synopsys,dw-hdmi.yaml index 4b7e54a8f037..624d32c024f6 100644 --- a/Documentation/devicetree/bindings/display/bridge/synopsys,dw-hdmi.yaml +++ b/Documentation/devicetree/bindings/display/bridge/synopsys,dw-hdmi.yaml @@ -48,6 +48,11 @@ properties: interrupts: maxItems: 1 + snps,disable-cec: + $ref: /schemas/types.yaml#/definitions/flag + description: + Disable HDMI-CEC. + additionalProperties: true ...
Even though some DW-HDMI controllers have perfectly usable HDMI-CEC implementation, some boards might prefer not to use it or even use software implementation instead. Add property for disabling CEC so driver doesn't expose unused CEC interface, if CEC pin isn't connected anywhere. Signed-off-by: Jernej Skrabec <jernej.skrabec@gmail.com> --- .../devicetree/bindings/display/bridge/synopsys,dw-hdmi.yaml | 5 +++++ 1 file changed, 5 insertions(+)