| Message ID | 20230419035646.43702-1-changhuang.liang@starfivetech.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Add JH7110 AON PMU support | expand |
On Tue, Apr 18, 2023 at 08:56:40PM -0700, Changhuang Liang wrote: > This patchset adds aon power domain driver for the StarFive JH7110 SoC. > It is used to turn on/off dphy rx/tx power switch. The series has been > tested on the VisionFive 2 board. > > This patchset should be applied after the patchset [1]: > [1] https://lore.kernel.org/all/20230414024157.53203-1-xingyu.wu@starfivetech.com/ > > changes since v1: > - Updated commit message. > - Changed "starfive,jh7110-pmu-dphy" to "starfive,jh7110-aon-pmu". > - Put if condition under allOf in .yaml file. > - Updated spelling error. > - Dropped patch 4: Add pmu type operation. > - Changed "jh71xx_pmu_general_set_state" to "jh7110_pmu_set_state" and moved it in call back. > - Changed "jh7110_pmu_general_parse_dt" to "jh7110_pmu_parse_dt" and moved it in call back. > - Used pmu_status save the pmu status offset. > - Changed "JH71XX_PMU_DPHY_SWITCH" to "JH71XX_AON_PMU_SWITCH" > - Changed copyright to "2022-2023" For the future, when you resend, please say why you did. > > v1: https://lore.kernel.org/all/20230411064743.273388-1-changhuang.liang@starfivetech.com/ > > Changhuang Liang (6): > dt-bindings: power: Add JH7110 AON PMU support > soc: starfive: Replace SOC_STARFIVE with ARCH_STARFIVE > soc: starfive: Modify ioremap to regmap > soc: starfive: Extract JH7110 pmu private operations > soc: starfive: Add JH7110 AON PMU support > riscv: dts: starfive: jh7110: Add AON PMU node > > .../bindings/power/starfive,jh7110-pmu.yaml | 15 +- > MAINTAINERS | 1 + > arch/riscv/boot/dts/starfive/jh7110.dtsi | 5 + > drivers/soc/starfive/Kconfig | 4 +- > drivers/soc/starfive/jh71xx_pmu.c | 200 +++++++++++++----- > .../dt-bindings/power/starfive,jh7110-pmu.h | 3 + > 6 files changed, 174 insertions(+), 54 deletions(-) > > > base-commit: 197b6b60ae7bc51dd0814953c562833143b292aa > prerequisite-patch-id: 388b8adbb0fe2daf4d07a21eafd4f1bd50ce2403 Also, all of this pre-req patch id stuff is pretty useless. You've already pointed out the patches that this is based on, so IMO this information isn't helpful & is probably more likely confuse tooling than anything else. Cheers, Conor.
On 2023/4/19 14:23, Conor Dooley wrote: > On Tue, Apr 18, 2023 at 08:56:40PM -0700, Changhuang Liang wrote: [...] >> - Used pmu_status save the pmu status offset. >> - Changed "JH71XX_PMU_DPHY_SWITCH" to "JH71XX_AON_PMU_SWITCH" >> - Changed copyright to "2022-2023" > > For the future, when you resend, please say why you did. > OK, thanks for your correction. I'll pay attention. >> >> v1: https://lore.kernel.org/all/20230411064743.273388-1-changhuang.liang@starfivetech.com/ >> [...] >> >> base-commit: 197b6b60ae7bc51dd0814953c562833143b292aa >> prerequisite-patch-id: 388b8adbb0fe2daf4d07a21eafd4f1bd50ce2403 > > Also, all of this pre-req patch id stuff is pretty useless. You've > already pointed out the patches that this is based on, so IMO this > information isn't helpful & is probably more likely confuse tooling > than anything else. > > Cheers, > Conor. OK, will not use "--base" for next.