| Message ID | 20230419061146.22246-1-angelogioacchino.delregno@collabora.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | MediaTek AUXADC thermal: urgent fixes | expand |
On 19/04/2023 08:11, AngeloGioacchino Del Regno wrote: > The AUXADC thermal driver unfortunately has issues with a fixed wait > at probe, as this is not only SoC dependent, but actually depends on > the board (and even aging...): for example, that works fine on the > Chromebook that I have here in my hands but not for the ones in our lab. > > Some machines are working fine with that 30ms delay at probe, but some > others are not, hence I started digging in downstream sources here and > there, and found that there actually is a valid temperature range for > at least auxadc-thermal *v1* and can be actually found in multiple > downstream kernels for MT8173 and MT6795. > > As for v2 and v3 thermal IP, I'm sure that the v1 range works fine but > I've "left room" for adding specific ranges for them later: this fix > is urgent, as many MT8173 and MT8183 Chromebooks are failing tests in > KernelCI due to thermal shutdown during boot. > > For the KernelCI logs, you can look at [1] for 8173, [2] for 8183. > > [1]: https://storage.kernelci.org/next/master/next-20230405/arm64/defconfig+arm64-chromebook/gcc-10/lab-collabora/igt-kms-mediatek-mt8173-elm-hana.html > [2]: https://storage.kernelci.org/next/master/next-20230405/arm64/defconfig+arm64-chromebook/gcc-10/lab-collabora/cros-ec-mt8183-kukui-jacuzzi-juniper-sku16.html > Applied, thanks
The AUXADC thermal driver unfortunately has issues with a fixed wait at probe, as this is not only SoC dependent, but actually depends on the board (and even aging...): for example, that works fine on the Chromebook that I have here in my hands but not for the ones in our lab. Some machines are working fine with that 30ms delay at probe, but some others are not, hence I started digging in downstream sources here and there, and found that there actually is a valid temperature range for at least auxadc-thermal *v1* and can be actually found in multiple downstream kernels for MT8173 and MT6795. As for v2 and v3 thermal IP, I'm sure that the v1 range works fine but I've "left room" for adding specific ranges for them later: this fix is urgent, as many MT8173 and MT8183 Chromebooks are failing tests in KernelCI due to thermal shutdown during boot. For the KernelCI logs, you can look at [1] for 8173, [2] for 8183. [1]: https://storage.kernelci.org/next/master/next-20230405/arm64/defconfig+arm64-chromebook/gcc-10/lab-collabora/igt-kms-mediatek-mt8173-elm-hana.html [2]: https://storage.kernelci.org/next/master/next-20230405/arm64/defconfig+arm64-chromebook/gcc-10/lab-collabora/cros-ec-mt8183-kukui-jacuzzi-juniper-sku16.html AngeloGioacchino Del Regno (2): Revert "thermal/drivers/mediatek: Add delay after thermal banks initialization" thermal/drivers/mediatek: Add temperature constraints to validate read drivers/thermal/mediatek/auxadc_thermal.c | 23 ++++++++++++++++++++--- 1 file changed, 20 insertions(+), 3 deletions(-)