| Message ID | 20230418094259.4150771-1-chancel.liu@nxp.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 238787157d83969e5149c8e99787d5d90e85fbe5 |
| Headers | show |
| Series | ASoC: fsl_sai: Fix pins setting for i.MX8QM platform | expand |
On Tue, Apr 18, 2023 at 5:44 PM Chancel Liu <chancel.liu@nxp.com> wrote: > SAI on i.MX8QM platform supports the data lines up to 4. So the pins > setting should be corrected to 4. > > Fixes: eba0f0077519 ("ASoC: fsl_sai: Enable combine mode soft") > Signed-off-by: Chancel Liu <chancel.liu@nxp.com> > Acked-by: Shengjiu Wang <shengjiu.wang@gmail.com> Best regards wang shengjiu > --- > sound/soc/fsl/fsl_sai.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/fsl/fsl_sai.c b/sound/soc/fsl/fsl_sai.c > index 07d13dca852e..abdaffb00fbd 100644 > --- a/sound/soc/fsl/fsl_sai.c > +++ b/sound/soc/fsl/fsl_sai.c > @@ -1544,7 +1544,7 @@ static const struct fsl_sai_soc_data > fsl_sai_imx8qm_data = { > .use_imx_pcm = true, > .use_edma = true, > .fifo_depth = 64, > - .pins = 1, > + .pins = 4, > .reg_offset = 0, > .mclk0_is_mclk1 = false, > .flags = 0, > -- > 2.25.1 > >
On 4/18/2023 12:42 PM, Chancel Liu wrote: > SAI on i.MX8QM platform supports the data lines up to 4. So the pins > setting should be corrected to 4. > > Fixes: eba0f0077519 ("ASoC: fsl_sai: Enable combine mode soft") > Signed-off-by: Chancel Liu <chancel.liu@nxp.com> > --- Reviewed-by: Iuliana Prodan <iuliana.prodan@nxp.com> Thanks, Iulia > sound/soc/fsl/fsl_sai.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/fsl/fsl_sai.c b/sound/soc/fsl/fsl_sai.c > index 07d13dca852e..abdaffb00fbd 100644 > --- a/sound/soc/fsl/fsl_sai.c > +++ b/sound/soc/fsl/fsl_sai.c > @@ -1544,7 +1544,7 @@ static const struct fsl_sai_soc_data fsl_sai_imx8qm_data = { > .use_imx_pcm = true, > .use_edma = true, > .fifo_depth = 64, > - .pins = 1, > + .pins = 4, > .reg_offset = 0, > .mclk0_is_mclk1 = false, > .flags = 0,
On Tue, 18 Apr 2023 17:42:59 +0800, Chancel Liu wrote: > SAI on i.MX8QM platform supports the data lines up to 4. So the pins > setting should be corrected to 4. > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: fsl_sai: Fix pins setting for i.MX8QM platform commit: 238787157d83969e5149c8e99787d5d90e85fbe5 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/sound/soc/fsl/fsl_sai.c b/sound/soc/fsl/fsl_sai.c index 07d13dca852e..abdaffb00fbd 100644 --- a/sound/soc/fsl/fsl_sai.c +++ b/sound/soc/fsl/fsl_sai.c @@ -1544,7 +1544,7 @@ static const struct fsl_sai_soc_data fsl_sai_imx8qm_data = { .use_imx_pcm = true, .use_edma = true, .fifo_depth = 64, - .pins = 1, + .pins = 4, .reg_offset = 0, .mclk0_is_mclk1 = false, .flags = 0,
SAI on i.MX8QM platform supports the data lines up to 4. So the pins setting should be corrected to 4. Fixes: eba0f0077519 ("ASoC: fsl_sai: Enable combine mode soft") Signed-off-by: Chancel Liu <chancel.liu@nxp.com> --- sound/soc/fsl/fsl_sai.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)