diff mbox series

[TESTSUITE] README.md: update dependencies

Message ID 20230420135803.4692-1-cgzones@googlemail.com (mailing list archive)
State Rejected
Delegated to: Ondrej Mosnáček
Headers show
Series [TESTSUITE] README.md: update dependencies | expand

Commit Message

Christian Göttsche April 20, 2023, 1:58 p.m. UTC
Add libibverbs-dev, required since 4b4922e1 ("tests/infiniband*:
simplify test activation"):

    create_modify_qp.c:10:10: fatal error: infiniband/verbs.h: No such file or directory
       10 | #include <infiniband/verbs.h>
          |          ^~~~~~~~~~~~~~~~~~~~

Signed-off-by: Christian Göttsche <cgzones@googlemail.com>
---
 README.md | 2 ++
 1 file changed, 2 insertions(+)

Comments

Ondrej Mosnacek April 20, 2023, 2:28 p.m. UTC | #1
On Thu, Apr 20, 2023 at 3:59 PM Christian Göttsche
<cgzones@googlemail.com> wrote:
> Add libibverbs-dev, required since 4b4922e1 ("tests/infiniband*:
> simplify test activation"):
>
>     create_modify_qp.c:10:10: fatal error: infiniband/verbs.h: No such file or directory
>        10 | #include <infiniband/verbs.h>
>           |          ^~~~~~~~~~~~~~~~~~~~
>
> Signed-off-by: Christian Göttsche <cgzones@googlemail.com>
> ---
>  README.md | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/README.md b/README.md
> index 7bd1dbc..5256cda 100644
> --- a/README.md
> +++ b/README.md
> @@ -82,6 +82,7 @@ following command (NOTE: On Fedora 32 and below you need to remove
>                 lksctp-tools-devel \
>                 attr \
>                 libbpf-devel \
> +               libibverbs-devel \
>                 keyutils-libs-devel \
>                 quota \
>                 xfsprogs-devel \
> @@ -124,6 +125,7 @@ command:
>                 libselinux1-dev \
>                 net-tools \
>                 iptables \
> +               libibverbs-dev \
>                 libsctp-dev \
>                 attr \
>                 libbpf-dev \
> --
> 2.40.0
>

These have already been added in
https://github.com/SELinuxProject/selinux-testsuite/commit/65cbbb8c4a4cafd1b307bfbd954acd7c5a653bb8
Christian Göttsche April 20, 2023, 3:11 p.m. UTC | #2
On Thu, 20 Apr 2023 at 16:28, Ondrej Mosnacek <omosnace@redhat.com> wrote:
>
> On Thu, Apr 20, 2023 at 3:59 PM Christian Göttsche
> <cgzones@googlemail.com> wrote:
> > Add libibverbs-dev, required since 4b4922e1 ("tests/infiniband*:
> > simplify test activation"):
> >
> >     create_modify_qp.c:10:10: fatal error: infiniband/verbs.h: No such file or directory
> >        10 | #include <infiniband/verbs.h>
> >           |          ^~~~~~~~~~~~~~~~~~~~
> >
> > Signed-off-by: Christian Göttsche <cgzones@googlemail.com>
> > ---
> >  README.md | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/README.md b/README.md
> > index 7bd1dbc..5256cda 100644
> > --- a/README.md
> > +++ b/README.md
> > @@ -82,6 +82,7 @@ following command (NOTE: On Fedora 32 and below you need to remove
> >                 lksctp-tools-devel \
> >                 attr \
> >                 libbpf-devel \
> > +               libibverbs-devel \
> >                 keyutils-libs-devel \
> >                 quota \
> >                 xfsprogs-devel \
> > @@ -124,6 +125,7 @@ command:
> >                 libselinux1-dev \
> >                 net-tools \
> >                 iptables \
> > +               libibverbs-dev \
> >                 libsctp-dev \
> >                 attr \
> >                 libbpf-dev \
> > --
> > 2.40.0
> >
>
> These have already been added in
> https://github.com/SELinuxProject/selinux-testsuite/commit/65cbbb8c4a4cafd1b307bfbd954acd7c5a653bb8

Whoops, must have looked on an outdated fork.
Please disregard my fault.

>
> --
> Ondrej Mosnacek
> Senior Software Engineer, Linux Security - SELinux kernel
> Red Hat, Inc.
>
Ondrej Mosnacek April 21, 2023, 7:32 a.m. UTC | #3
On Thu, Apr 20, 2023 at 5:11 PM Christian Göttsche
<cgzones@googlemail.com> wrote:
>
> On Thu, 20 Apr 2023 at 16:28, Ondrej Mosnacek <omosnace@redhat.com> wrote:
> >
> > On Thu, Apr 20, 2023 at 3:59 PM Christian Göttsche
> > <cgzones@googlemail.com> wrote:
> > > Add libibverbs-dev, required since 4b4922e1 ("tests/infiniband*:
> > > simplify test activation"):
> > >
> > >     create_modify_qp.c:10:10: fatal error: infiniband/verbs.h: No such file or directory
> > >        10 | #include <infiniband/verbs.h>
> > >           |          ^~~~~~~~~~~~~~~~~~~~
> > >
> > > Signed-off-by: Christian Göttsche <cgzones@googlemail.com>
> > > ---
> > >  README.md | 2 ++
> > >  1 file changed, 2 insertions(+)
> > >
> > > diff --git a/README.md b/README.md
> > > index 7bd1dbc..5256cda 100644
> > > --- a/README.md
> > > +++ b/README.md
> > > @@ -82,6 +82,7 @@ following command (NOTE: On Fedora 32 and below you need to remove
> > >                 lksctp-tools-devel \
> > >                 attr \
> > >                 libbpf-devel \
> > > +               libibverbs-devel \
> > >                 keyutils-libs-devel \
> > >                 quota \
> > >                 xfsprogs-devel \
> > > @@ -124,6 +125,7 @@ command:
> > >                 libselinux1-dev \
> > >                 net-tools \
> > >                 iptables \
> > > +               libibverbs-dev \
> > >                 libsctp-dev \
> > >                 attr \
> > >                 libbpf-dev \
> > > --
> > > 2.40.0
> > >
> >
> > These have already been added in
> > https://github.com/SELinuxProject/selinux-testsuite/commit/65cbbb8c4a4cafd1b307bfbd954acd7c5a653bb8
>
> Whoops, must have looked on an outdated fork.
> Please disregard my fault.

No problem, mistakes happen :)
diff mbox series

Patch

diff --git a/README.md b/README.md
index 7bd1dbc..5256cda 100644
--- a/README.md
+++ b/README.md
@@ -82,6 +82,7 @@  following command (NOTE: On Fedora 32 and below you need to remove
 		lksctp-tools-devel \
 		attr \
 		libbpf-devel \
+		libibverbs-devel \
 		keyutils-libs-devel \
 		quota \
 		xfsprogs-devel \
@@ -124,6 +125,7 @@  command:
 		libselinux1-dev \
 		net-tools \
 		iptables \
+		libibverbs-dev \
 		libsctp-dev \
 		attr \
 		libbpf-dev \