| Message ID | 20230421071630.524822-3-chenhuiz@axis.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Add support for the ICM 20600 IMU | expand |
On 21/04/2023 09:16, Hermes Zhang wrote: > Adding the invensense ICM-20600 to the compatible list of the mpu6050 > driver > > Signed-off-by: Hermes Zhang <chenhuiz@axis.com> > --- > .../devicetree/bindings/iio/imu/invensense,mpu6050.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/iio/imu/invensense,mpu6050.yaml b/Documentation/devicetree/bindings/iio/imu/invensense,mpu6050.yaml > index ec64d7877fe5..67711bc0ee6c 100644 > --- a/Documentation/devicetree/bindings/iio/imu/invensense,mpu6050.yaml > +++ b/Documentation/devicetree/bindings/iio/imu/invensense,mpu6050.yaml > @@ -20,6 +20,7 @@ properties: > - invensense,icm20608 > - invensense,icm20609 > - invensense,icm20689 > + - invensense,icm20600 > - invensense,icm20602 Didn't we start switching to compatible groups of devices? This looks compatible with 20602. Best regards, Krzysztof
在 2023/4/21 16:23, Krzysztof Kozlowski 写道: > Didn't we start switching to compatible groups of devices? This looks > compatible with 20602. Hi Krzysztof, Sorry, I may not aware of this. Could you give some more info about the compatible groups? Yes, the icm20602 is quite similar as icm20600. Thanks & Best Regards, Hermes
On Sat, 22 Apr 2023 14:14:49 +0800 Hermes Zhang <chenhuiz@axis.com> wrote: > 在 2023/4/21 16:23, Krzysztof Kozlowski 写道: > > Didn't we start switching to compatible groups of devices? This looks > > compatible with 20602. > > Hi Krzysztof, > > Sorry, I may not aware of this. Could you give some more info about the > compatible groups? Yes, the icm20602 is quite similar as icm20600. If it's compatible enough that a device tree that lists compatible = "invensense,icm20600", "invensense,icm20602" would work correctly with an old kernel by first checking for invensense,icm20600 then falling back to invense,icm20602 then it should be listed with that fallback. See the existing block that covers the fallback form icm20608d to icm20608 - items: - const: invensense,icm20608d - const: invensense,icm20608 Note it is fine if the driver 'warns' that it's found a WHOAMI value it doesn't know as long as it then goes on and works correctly. Thus there can't be any incompatibilities between the two parts when we consider the functionality the driver implements today. If we add features in future that aren't compatible, that's fine because we will be matching against the more specific compatible you are adding here. Jonathan > > Thanks & Best Regards, > > Hermes >
diff --git a/Documentation/devicetree/bindings/iio/imu/invensense,mpu6050.yaml b/Documentation/devicetree/bindings/iio/imu/invensense,mpu6050.yaml index ec64d7877fe5..67711bc0ee6c 100644 --- a/Documentation/devicetree/bindings/iio/imu/invensense,mpu6050.yaml +++ b/Documentation/devicetree/bindings/iio/imu/invensense,mpu6050.yaml @@ -20,6 +20,7 @@ properties: - invensense,icm20608 - invensense,icm20609 - invensense,icm20689 + - invensense,icm20600 - invensense,icm20602 - invensense,icm20690 - invensense,mpu6000
Adding the invensense ICM-20600 to the compatible list of the mpu6050 driver Signed-off-by: Hermes Zhang <chenhuiz@axis.com> --- .../devicetree/bindings/iio/imu/invensense,mpu6050.yaml | 1 + 1 file changed, 1 insertion(+)