| Message ID | 20230421124142.2640825-3-berrange@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | fix broken pxb-cxl realization | expand |
On 21/04/2023 14.41, Daniel P. Berrangé wrote: > The QMO cast debugging is designed to catch developer mistakes > and as such should always be enabled during CI runs. > > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> > --- > .gitlab-ci.d/buildtest-template.yml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/.gitlab-ci.d/buildtest-template.yml b/.gitlab-ci.d/buildtest-template.yml > index a6cfe9be97..9151dece6f 100644 > --- a/.gitlab-ci.d/buildtest-template.yml > +++ b/.gitlab-ci.d/buildtest-template.yml > @@ -12,6 +12,7 @@ > - mkdir build > - cd build > - ../configure --enable-werror --disable-docs --enable-fdt=system > + --enable-qom-cast-debug > ${LD_JOBS:+--meson=git} ${TARGETS:+--target-list="$TARGETS"} > $CONFIGURE_ARGS || > { cat config.log meson-logs/meson-log.txt && exit 1; } No, it's better to always enable it again, since it was just switched off by accident in the past: https://lore.kernel.org/qemu-devel/20230417130037.236747-3-thuth@redhat.com/ Thomas
diff --git a/.gitlab-ci.d/buildtest-template.yml b/.gitlab-ci.d/buildtest-template.yml index a6cfe9be97..9151dece6f 100644 --- a/.gitlab-ci.d/buildtest-template.yml +++ b/.gitlab-ci.d/buildtest-template.yml @@ -12,6 +12,7 @@ - mkdir build - cd build - ../configure --enable-werror --disable-docs --enable-fdt=system + --enable-qom-cast-debug ${LD_JOBS:+--meson=git} ${TARGETS:+--target-list="$TARGETS"} $CONFIGURE_ARGS || { cat config.log meson-logs/meson-log.txt && exit 1; }
The QMO cast debugging is designed to catch developer mistakes and as such should always be enabled during CI runs. Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> --- .gitlab-ci.d/buildtest-template.yml | 1 + 1 file changed, 1 insertion(+)