diff mbox series

[for,6.3] MIPS: Define RUNTIME_DISCARD_EXIT in LD script

Message ID 20230408203348.28896-1-jiaxun.yang@flygoat.com (mailing list archive)
State Accepted
Commit 6dcbd0a69c84a8ae7a442840a8cf6b1379dc8f16
Headers show
Series [for,6.3] MIPS: Define RUNTIME_DISCARD_EXIT in LD script | expand

Commit Message

Jiaxun Yang April 8, 2023, 8:33 p.m. UTC
MIPS's exit sections are discarded at runtime as well.

Fixes link error:
`.exit.text' referenced in section `__jump_table' of fs/fuse/inode.o:
defined in discarded section `.exit.text' of fs/fuse/inode.o

Fixes: 99cb0d917ffa ("arch: fix broken BuildID for arm64 and riscv")
Reported-by: "kernelci.org bot" <bot@kernelci.org>
Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
---
 arch/mips/kernel/vmlinux.lds.S | 2 ++
 1 file changed, 2 insertions(+)

Comments

Jiaxun Yang April 21, 2023, 9:10 p.m. UTC | #1
> 2023年4月8日 21:33,Jiaxun Yang <jiaxun.yang@flygoat.com> 写道:
> 
> MIPS's exit sections are discarded at runtime as well.
> 
> Fixes link error:
> `.exit.text' referenced in section `__jump_table' of fs/fuse/inode.o:
> defined in discarded section `.exit.text' of fs/fuse/inode.o
> 
> Fixes: 99cb0d917ffa ("arch: fix broken BuildID for arm64 and riscv")
> Reported-by: "kernelci.org bot" <bot@kernelci.org>
> Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>

Hi Thomas,

Also ping on this patch which is blocking KernelCI’s build for a while [1].
You can check build logs here [2].

Really don’t want to leave this as a 6.3 build regression.

Thanks
Jiaxun

[1]: https://linux.kernelci.org/build/id/6442f2ccfbc366d1592e8739/
[2]: https://storage.kernelci.org/mainline/master/v6.3-rc7-180-gc337b23f32c87/mips/32r2el_defconfig+debug/gcc-10/logs/kernel.log

> ---
> arch/mips/kernel/vmlinux.lds.S | 2 ++
> 1 file changed, 2 insertions(+)
> 
> diff --git a/arch/mips/kernel/vmlinux.lds.S b/arch/mips/kernel/vmlinux.lds.S
> index 52cbde60edf5..9ff55cb80a64 100644
> --- a/arch/mips/kernel/vmlinux.lds.S
> +++ b/arch/mips/kernel/vmlinux.lds.S
> @@ -15,6 +15,8 @@
> #define EMITS_PT_NOTE
> #endif
> 
> +#define RUNTIME_DISCARD_EXIT
> +
> #include <asm-generic/vmlinux.lds.h>
> 
> #undef mips
> -- 
> 2.39.2 (Apple Git-143)
>
Thomas Bogendoerfer April 21, 2023, 10:01 p.m. UTC | #2
On Sat, Apr 08, 2023 at 09:33:48PM +0100, Jiaxun Yang wrote:
> MIPS's exit sections are discarded at runtime as well.
> 
> Fixes link error:
> `.exit.text' referenced in section `__jump_table' of fs/fuse/inode.o:
> defined in discarded section `.exit.text' of fs/fuse/inode.o
> 
> Fixes: 99cb0d917ffa ("arch: fix broken BuildID for arm64 and riscv")
> Reported-by: "kernelci.org bot" <bot@kernelci.org>
> Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
> ---
>  arch/mips/kernel/vmlinux.lds.S | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/mips/kernel/vmlinux.lds.S b/arch/mips/kernel/vmlinux.lds.S
> index 52cbde60edf5..9ff55cb80a64 100644
> --- a/arch/mips/kernel/vmlinux.lds.S
> +++ b/arch/mips/kernel/vmlinux.lds.S
> @@ -15,6 +15,8 @@
>  #define EMITS_PT_NOTE
>  #endif
>  
> +#define RUNTIME_DISCARD_EXIT
> +
>  #include <asm-generic/vmlinux.lds.h>
>  
>  #undef mips
> -- 
> 2.39.2 (Apple Git-143)

applied to mips-fixes.

Thomas.
diff mbox series

Patch

diff --git a/arch/mips/kernel/vmlinux.lds.S b/arch/mips/kernel/vmlinux.lds.S
index 52cbde60edf5..9ff55cb80a64 100644
--- a/arch/mips/kernel/vmlinux.lds.S
+++ b/arch/mips/kernel/vmlinux.lds.S
@@ -15,6 +15,8 @@ 
 #define EMITS_PT_NOTE
 #endif
 
+#define RUNTIME_DISCARD_EXIT
+
 #include <asm-generic/vmlinux.lds.h>
 
 #undef mips