| Message ID | 168182460362.616355.14591423386485175723.stgit@firesoul (mailing list archive) |
|---|---|
| Headers | show |
| Series | XDP-hints: XDP kfunc metadata for driver igc | expand |
On Tuesday, April 18, 2023 9:31 PM, Jesper Dangaard Brouer <brouer@redhat.com> wrote: >Implement both RX hash and RX timestamp XDP hints kfunc metadata for driver >igc. > >First patch fix RX hashing for igc in general. > >Last patch change test program xdp_hw_metadata to track more timestamps, >which helps us correlate the hardware RX timestamp with something. > >--- >To maintainers: I'm uncertain which git tree this should be sent against. This is >primary NIC driver code (net-next), but it's BPF/XDP related (bpf-next) via >xdp_metadata_ops. > >Jesper Dangaard Brouer (5): > igc: enable and fix RX hash usage by netstack > igc: add igc_xdp_buff wrapper for xdp_buff in driver > igc: add XDP hints kfuncs for RX hash > igc: add XDP hints kfuncs for RX timestamp > selftests/bpf: xdp_hw_metadata track more timestamps > > > drivers/net/ethernet/intel/igc/igc.h | 35 ++++++ > drivers/net/ethernet/intel/igc/igc_main.c | 116 ++++++++++++++++-- > .../selftests/bpf/progs/xdp_hw_metadata.c | 4 +- > tools/testing/selftests/bpf/xdp_hw_metadata.c | 47 ++++++- > tools/testing/selftests/bpf/xdp_metadata.h | 1 + > 5 files changed, 186 insertions(+), 17 deletions(-) > >-- This patchset lgtm. Thanks for the changes. Thanks & Regards Siang
On 4/18/23 4:53 PM, Song, Yoong Siang wrote: > On Tuesday, April 18, 2023 9:31 PM, Jesper Dangaard Brouer <brouer@redhat.com> wrote: >> Implement both RX hash and RX timestamp XDP hints kfunc metadata for driver >> igc. >> >> First patch fix RX hashing for igc in general. >> >> Last patch change test program xdp_hw_metadata to track more timestamps, >> which helps us correlate the hardware RX timestamp with something. >> >> --- >> To maintainers: I'm uncertain which git tree this should be sent against. This is >> primary NIC driver code (net-next), but it's BPF/XDP related (bpf-next) via >> xdp_metadata_ops. >> >> Jesper Dangaard Brouer (5): >> igc: enable and fix RX hash usage by netstack >> igc: add igc_xdp_buff wrapper for xdp_buff in driver >> igc: add XDP hints kfuncs for RX hash >> igc: add XDP hints kfuncs for RX timestamp >> selftests/bpf: xdp_hw_metadata track more timestamps >> >> >> drivers/net/ethernet/intel/igc/igc.h | 35 ++++++ >> drivers/net/ethernet/intel/igc/igc_main.c | 116 ++++++++++++++++-- >> .../selftests/bpf/progs/xdp_hw_metadata.c | 4 +- >> tools/testing/selftests/bpf/xdp_hw_metadata.c | 47 ++++++- >> tools/testing/selftests/bpf/xdp_metadata.h | 1 + >> 5 files changed, 186 insertions(+), 17 deletions(-) >> >> -- > > This patchset lgtm. > Thanks for the changes. Siang, can I take this into the patches as your: Acked-by: Song Yoong Siang <yoong.siang.song@intel.com> ? Thanks, Daniel
On Friday, April 21, 2023 10:53 PM, Daniel Borkmann <daniel@iogearbox.net> wrote: >On 4/18/23 4:53 PM, Song, Yoong Siang wrote: >> On Tuesday, April 18, 2023 9:31 PM, Jesper Dangaard Brouer ><brouer@redhat.com> wrote: >>> Implement both RX hash and RX timestamp XDP hints kfunc metadata for >>> driver igc. >>> >>> First patch fix RX hashing for igc in general. >>> >>> Last patch change test program xdp_hw_metadata to track more >>> timestamps, which helps us correlate the hardware RX timestamp with >something. >>> >>> --- >>> To maintainers: I'm uncertain which git tree this should be sent >>> against. This is primary NIC driver code (net-next), but it's BPF/XDP >>> related (bpf-next) via xdp_metadata_ops. >>> >>> Jesper Dangaard Brouer (5): >>> igc: enable and fix RX hash usage by netstack >>> igc: add igc_xdp_buff wrapper for xdp_buff in driver >>> igc: add XDP hints kfuncs for RX hash >>> igc: add XDP hints kfuncs for RX timestamp >>> selftests/bpf: xdp_hw_metadata track more timestamps >>> >>> >>> drivers/net/ethernet/intel/igc/igc.h | 35 ++++++ >>> drivers/net/ethernet/intel/igc/igc_main.c | 116 ++++++++++++++++-- >>> .../selftests/bpf/progs/xdp_hw_metadata.c | 4 +- >>> tools/testing/selftests/bpf/xdp_hw_metadata.c | 47 ++++++- >>> tools/testing/selftests/bpf/xdp_metadata.h | 1 + >>> 5 files changed, 186 insertions(+), 17 deletions(-) >>> >>> -- >> >> This patchset lgtm. >> Thanks for the changes. > >Siang, can I take this into the patches as your: > >Acked-by: Song Yoong Siang <yoong.siang.song@intel.com> > >? Sure. Acked-by: Song Yoong Siang <yoong.siang.song@intel.com> Thanks & Regards Siang > >Thanks, >Daniel
Hello: This series was applied to bpf/bpf-next.git (master) by Daniel Borkmann <daniel@iogearbox.net>: On Tue, 18 Apr 2023 15:30:37 +0200 you wrote: > Implement both RX hash and RX timestamp XDP hints kfunc metadata > for driver igc. > > First patch fix RX hashing for igc in general. > > Last patch change test program xdp_hw_metadata to track more > timestamps, which helps us correlate the hardware RX timestamp > with something. > > [...] Here is the summary with links: - [bpf-next,V2,1/5] igc: enable and fix RX hash usage by netstack https://git.kernel.org/bpf/bpf-next/c/84214ab4689f - [bpf-next,V2,2/5] igc: add igc_xdp_buff wrapper for xdp_buff in driver https://git.kernel.org/bpf/bpf-next/c/73b7123de0cf - [bpf-next,V2,3/5] igc: add XDP hints kfuncs for RX hash https://git.kernel.org/bpf/bpf-next/c/8416814fffa9 - [bpf-next,V2,4/5] igc: add XDP hints kfuncs for RX timestamp https://git.kernel.org/bpf/bpf-next/c/d677266755c6 - [bpf-next,V2,5/5] selftests/bpf: xdp_hw_metadata track more timestamps https://git.kernel.org/bpf/bpf-next/c/bb323478767d You are awesome, thank you!
Implement both RX hash and RX timestamp XDP hints kfunc metadata for driver igc. First patch fix RX hashing for igc in general. Last patch change test program xdp_hw_metadata to track more timestamps, which helps us correlate the hardware RX timestamp with something. --- To maintainers: I'm uncertain which git tree this should be sent against. This is primary NIC driver code (net-next), but it's BPF/XDP related (bpf-next) via xdp_metadata_ops. Jesper Dangaard Brouer (5): igc: enable and fix RX hash usage by netstack igc: add igc_xdp_buff wrapper for xdp_buff in driver igc: add XDP hints kfuncs for RX hash igc: add XDP hints kfuncs for RX timestamp selftests/bpf: xdp_hw_metadata track more timestamps drivers/net/ethernet/intel/igc/igc.h | 35 ++++++ drivers/net/ethernet/intel/igc/igc_main.c | 116 ++++++++++++++++-- .../selftests/bpf/progs/xdp_hw_metadata.c | 4 +- tools/testing/selftests/bpf/xdp_hw_metadata.c | 47 ++++++- tools/testing/selftests/bpf/xdp_metadata.h | 1 + 5 files changed, 186 insertions(+), 17 deletions(-) --