| Message ID | 20230424105930.49944-1-lihuya@hust.edu.cn (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [RESEND] usb: dwc3: remove dead code in dwc3_otg_get_irq | expand |
On Mon, Apr 24, 2023, lihuya wrote: > platform_get_irq() only return non-zero irq number on success, or > negative error number on failure. > > There is no need to check the return value of platform_get_irq() > to determine the return value of dwc3_otg_get_irq(), removing > them to solve this problem. > > Signed-off-by: lihuya <lihuya@hust.edu.cn> Is this your full name? > --- > drivers/usb/dwc3/drd.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/usb/dwc3/drd.c b/drivers/usb/dwc3/drd.c > index 039bf241769a..c2e09700212d 100644 > --- a/drivers/usb/dwc3/drd.c > +++ b/drivers/usb/dwc3/drd.c > @@ -154,11 +154,6 @@ static int dwc3_otg_get_irq(struct dwc3 *dwc) > goto out; > > irq = platform_get_irq(dwc3_pdev, 0); > - if (irq > 0) > - goto out; > - > - if (!irq) > - irq = -EINVAL; > > out: > return irq; > -- > 2.34.1 > FWIW, here's the ack again. Acked-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com> Thanks, Thinh
On 2023/4/25 05:33, 'Thinh Nguyen' via HUST OS Kernel Contribution wrote: > On Mon, Apr 24, 2023, lihuya wrote: >> platform_get_irq() only return non-zero irq number on success, or >> negative error number on failure. >> >> There is no need to check the return value of platform_get_irq() >> to determine the return value of dwc3_otg_get_irq(), removing >> them to solve this problem. >> >> Signed-off-by: lihuya <lihuya@hust.edu.cn> > Is this your full name? Hi Yuhang, Please use your full name: Yuhang Liang. This is essential in the kernel patch submission. Dongliang Mu > >> --- >> drivers/usb/dwc3/drd.c | 5 ----- >> 1 file changed, 5 deletions(-) >> >> diff --git a/drivers/usb/dwc3/drd.c b/drivers/usb/dwc3/drd.c >> index 039bf241769a..c2e09700212d 100644 >> --- a/drivers/usb/dwc3/drd.c >> +++ b/drivers/usb/dwc3/drd.c >> @@ -154,11 +154,6 @@ static int dwc3_otg_get_irq(struct dwc3 *dwc) >> goto out; >> >> irq = platform_get_irq(dwc3_pdev, 0); >> - if (irq > 0) >> - goto out; >> - >> - if (!irq) >> - irq = -EINVAL; >> >> out: >> return irq; >> -- >> 2.34.1 >> > FWIW, here's the ack again. > > Acked-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com> > > Thanks, > Thinh >
Hello! On 4/24/23 1:59 PM, lihuya wrote: > platform_get_irq() only return non-zero irq number on success, or > negative error number on failure. > > There is no need to check the return value of platform_get_irq() > to determine the return value of dwc3_otg_get_irq(), removing > them to solve this problem. I was going to submit such patch myself at some point... which has never happened. :-/ > Signed-off-by: lihuya <lihuya@hust.edu.cn> Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru> [...] MBR, Sergey
On 2023/4/25 16:57, Sergey Shtylyov wrote: > Hello! > > On 4/24/23 1:59 PM, lihuya wrote: > >> platform_get_irq() only return non-zero irq number on success, or >> negative error number on failure. >> >> There is no need to check the return value of platform_get_irq() >> to determine the return value of dwc3_otg_get_irq(), removing >> them to solve this problem. > I was going to submit such patch myself at some point... which > has never happened. :-/ > >> Signed-off-by: lihuya <lihuya@hust.edu.cn> > Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru> Hi Sergey, Please take a look at the following thread [1]. Yuhang sent a v2 patch since he did not use his real name in the Signed-off-by. Greg already had some comments on this patch. [1] https://lore.kernel.org/lkml/20230425015532.13622-1-lihuya@hust.edu.cn/ > > [...] > > MBR, Sergey >
diff --git a/drivers/usb/dwc3/drd.c b/drivers/usb/dwc3/drd.c index 039bf241769a..c2e09700212d 100644 --- a/drivers/usb/dwc3/drd.c +++ b/drivers/usb/dwc3/drd.c @@ -154,11 +154,6 @@ static int dwc3_otg_get_irq(struct dwc3 *dwc) goto out; irq = platform_get_irq(dwc3_pdev, 0); - if (irq > 0) - goto out; - - if (!irq) - irq = -EINVAL; out: return irq;
platform_get_irq() only return non-zero irq number on success, or negative error number on failure. There is no need to check the return value of platform_get_irq() to determine the return value of dwc3_otg_get_irq(), removing them to solve this problem. Signed-off-by: lihuya <lihuya@hust.edu.cn> --- drivers/usb/dwc3/drd.c | 5 ----- 1 file changed, 5 deletions(-)