| Message ID | 20230425173158.574203-7-kwolf@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Graph locking, part 3 (more block drivers) | expand |
On Tue, Apr 25, 2023 at 07:31:44PM +0200, Kevin Wolf wrote: > For some function, parts of their interface is that are called without > holding the graph lock. Add a new macro to document this. Grammar is off; maybe: For some functions, it is part of their interface to be called without holding the graph lock. > > The macro expands to TSA_EXCLUDES(), which is a relatively weak check > because it passes in cases where the compiler just doesn't know if the > lock is held. Function pointers can't be checked at all. Therefore, its > primary purpose is documentation. > > Signed-off-by: Kevin Wolf <kwolf@redhat.com> > --- > include/block/graph-lock.h | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: Eric blake <eblake@redhat.com>
On Tue, Apr 25, 2023 at 07:31:44PM +0200, Kevin Wolf wrote: > For some function, parts of their interface is that are called without > holding the graph lock. Add a new macro to document this. > > The macro expands to TSA_EXCLUDES(), which is a relatively weak check > because it passes in cases where the compiler just doesn't know if the > lock is held. Function pointers can't be checked at all. Therefore, its > primary purpose is documentation. > > Signed-off-by: Kevin Wolf <kwolf@redhat.com> > --- > include/block/graph-lock.h | 2 ++ > 1 file changed, 2 insertions(+) Modulo Eric's comment about the commit description: Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
diff --git a/include/block/graph-lock.h b/include/block/graph-lock.h index 18cc14de22..7ef391fab3 100644 --- a/include/block/graph-lock.h +++ b/include/block/graph-lock.h @@ -73,6 +73,7 @@ extern BdrvGraphLock graph_lock; */ #define GRAPH_WRLOCK TSA_REQUIRES(graph_lock) #define GRAPH_RDLOCK TSA_REQUIRES_SHARED(graph_lock) +#define GRAPH_UNLOCKED TSA_EXCLUDES(graph_lock) /* * TSA annotations are not part of function types, so checks are defeated when @@ -83,6 +84,7 @@ extern BdrvGraphLock graph_lock; */ #define GRAPH_RDLOCK_PTR TSA_GUARDED_BY(graph_lock) #define GRAPH_WRLOCK_PTR TSA_GUARDED_BY(graph_lock) +#define GRAPH_UNLOCKED_PTR /* * register_aiocontext:
For some function, parts of their interface is that are called without holding the graph lock. Add a new macro to document this. The macro expands to TSA_EXCLUDES(), which is a relatively weak check because it passes in cases where the compiler just doesn't know if the lock is held. Function pointers can't be checked at all. Therefore, its primary purpose is documentation. Signed-off-by: Kevin Wolf <kwolf@redhat.com> --- include/block/graph-lock.h | 2 ++ 1 file changed, 2 insertions(+)