| Message ID | 20230425194622.114869-2-jandryuk@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | libxl: device_backend_callback() print rc on error | expand |
On 25.04.23 21:46, Jason Andryuk wrote: > Print the rc when an error is found in device_backend_callback() so the > user can have some idea of why things went wrong. > > Signed-off-by: Jason Andryuk <jandryuk@gmail.com> Reviewed-by: Juergen Gross <jgross@suse.com> Juergen
On 25.04.2023 21:46, Jason Andryuk wrote: > Print the rc when an error is found in device_backend_callback() so the > user can have some idea of why things went wrong. > > Signed-off-by: Jason Andryuk <jandryuk@gmail.com> > --- > tools/libs/light/libxl_device.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) While patches which are part of a series should be sent as replies to the cover letter, may I ask that you do not send individual patches as replies to other (unrelated) patches (or, in general, really as replies to anything, i.e. also not as replies to e.g. an earlier discussion)? Thanks, Jan
On Wed, Apr 26, 2023 at 4:39 AM Jan Beulich <jbeulich@suse.com> wrote: > > On 25.04.2023 21:46, Jason Andryuk wrote: > > Print the rc when an error is found in device_backend_callback() so the > > user can have some idea of why things went wrong. > > > > Signed-off-by: Jason Andryuk <jandryuk@gmail.com> > > --- > > tools/libs/light/libxl_device.c | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > While patches which are part of a series should be sent as replies to the > cover letter, may I ask that you do not send individual patches as replies > to other (unrelated) patches (or, in general, really as replies to anything, > i.e. also not as replies to e.g. an earlier discussion)? Certainly. Sorry about that. I formatted the patches individually, but sent them with a single git send-email command. Looks like I should have added --no-thread to have them sent individually. Regards, Jason
diff --git a/tools/libs/light/libxl_device.c b/tools/libs/light/libxl_device.c index a75c21d433..13da6e0573 100644 --- a/tools/libs/light/libxl_device.c +++ b/tools/libs/light/libxl_device.c @@ -1160,9 +1160,10 @@ static void device_backend_callback(libxl__egc *egc, libxl__ev_devstate *ds, } if (rc) { - LOGD(ERROR, aodev->dev->domid, "unable to %s device with path %s", + LOGD(ERROR, aodev->dev->domid, + "unable to %s device with path %s - rc %d", libxl__device_action_to_string(aodev->action), - libxl__device_backend_path(gc, aodev->dev)); + libxl__device_backend_path(gc, aodev->dev), rc); goto out; }
Print the rc when an error is found in device_backend_callback() so the user can have some idea of why things went wrong. Signed-off-by: Jason Andryuk <jandryuk@gmail.com> --- tools/libs/light/libxl_device.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)