| Message ID | 20230426104313.28950-3-harini.katakam@amd.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | Add support for VSC8531_02 PHY and DT RGMII tuning | expand |
On Wed, Apr 26, 2023 at 04:13:12PM +0530, Harini Katakam wrote: > From: Harini Katakam <harini.katakam@xilinx.com> > > Add optional properties to tune RGMII RX and TX delay. The current > default value in the Linux driver, when the phy-mode is rgmii-id, > is 2ns for both. These properties take priority if specified. > > Signed-off-by: Harini Katakam <harini.katakam@amd.com> > Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com> > Signed-off-by: Michal Simek <michal.simek@xilinx.com> > --- > v2: > - Updated DT binding description and commit for optional delay tuning > to be clearer on the precedence > - Updated dt property name to include vendor instead of phy device name > > Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt b/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt > index 0a3647fe331b..2b779bc3096b 100644 > --- a/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt > +++ b/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt > @@ -33,6 +33,8 @@ Optional properties: > VSC8531_DUPLEX_COLLISION (8). > - load-save-gpios : GPIO used for the load/save operation of the PTP > hardware clock (PHC). > +- mscc,rx-delay : RGMII RX delay. Allowed values are 0.2 - 3.4 ns. > +- mscc,tx-delay : RGMII TX delay. Allowed values are 0.2 - 3.4 ns. We have rx-internal-delay-ps and tx-internal-delay-ps in the common ethernet-phy.yaml, there is no need for a custom property.
On Wed, Apr 26, 2023 at 04:13:12PM +0530, Harini Katakam wrote: > From: Harini Katakam <harini.katakam@xilinx.com> > > Add optional properties to tune RGMII RX and TX delay. The current > default value in the Linux driver, when the phy-mode is rgmii-id, > is 2ns for both. These properties take priority if specified. > > Signed-off-by: Harini Katakam <harini.katakam@amd.com> > Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com> > Signed-off-by: Michal Simek <michal.simek@xilinx.com> Your signed-off-by needs to come last, since you are submitting it. But as Vladimir pointed out, you don't need to add anything. You could however convert to yaml, if you want. Andrew
diff --git a/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt b/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt index 0a3647fe331b..2b779bc3096b 100644 --- a/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt +++ b/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt @@ -33,6 +33,8 @@ Optional properties: VSC8531_DUPLEX_COLLISION (8). - load-save-gpios : GPIO used for the load/save operation of the PTP hardware clock (PHC). +- mscc,rx-delay : RGMII RX delay. Allowed values are 0.2 - 3.4 ns. +- mscc,tx-delay : RGMII TX delay. Allowed values are 0.2 - 3.4 ns. Table: 1 - Edge rate change