mbox series

[0/2] RISC-V: hwprobe: Couple fixes found on late review

Message ID 20230426141333.10063-1-ajones@ventanamicro.com (mailing list archive)
Headers show
Series RISC-V: hwprobe: Couple fixes found on late review | expand

Message

Andrew Jones April 26, 2023, 2:13 p.m. UTC 
I didn't get a chance to take a close look at "[PATCH v6 0/6] RISC-V
Hardware Probing User Interface" until now. I spotted a couple issues
while looking and this series collects the fixes.

Andrew Jones (2):
  RISC-V: hwprobe: There can only be one first
  RISC-V: hwprobe: Explicity check for -1 in vdso init

 arch/riscv/kernel/sys_riscv.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Comments

Conor Dooley April 26, 2023, 3:04 p.m. UTC | #1 
On Wed, Apr 26, 2023 at 04:13:31PM +0200, Andrew Jones wrote:
> I didn't get a chance to take a close look at "[PATCH v6 0/6] RISC-V
> Hardware Probing User Interface" until now. I spotted a couple issues
> while looking and this series collects the fixes.

Both seem fair..
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

Thanks,
Conor.
Evan Green April 26, 2023, 3:43 p.m. UTC | #2 
On Wed, Apr 26, 2023 at 7:13 AM Andrew Jones <ajones@ventanamicro.com> wrote:
>
> I didn't get a chance to take a close look at "[PATCH v6 0/6] RISC-V
> Hardware Probing User Interface" until now. I spotted a couple issues
> while looking and this series collects the fixes.
>
> Andrew Jones (2):
>   RISC-V: hwprobe: There can only be one first
>   RISC-V: hwprobe: Explicity check for -1 in vdso init
>
>  arch/riscv/kernel/sys_riscv.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> --
> 2.39.2

Sigh, wish I had spotted these. Thanks!

Reviewed-by: Evan Green <evan@rivosinc.com>
Palmer Dabbelt April 26, 2023, 4:45 p.m. UTC | #3 
On Wed, 26 Apr 2023 16:13:31 +0200, Andrew Jones wrote:
> I didn't get a chance to take a close look at "[PATCH v6 0/6] RISC-V
> Hardware Probing User Interface" until now. I spotted a couple issues
> while looking and this series collects the fixes.
> 
> Andrew Jones (2):
>   RISC-V: hwprobe: There can only be one first
>   RISC-V: hwprobe: Explicity check for -1 in vdso init
> 
> [...]

Applied, thanks!

[1/2] RISC-V: hwprobe: There can only be one first
      https://git.kernel.org/palmer/c/08dc10759468
[2/2] RISC-V: hwprobe: Explicity check for -1 in vdso init
      https://git.kernel.org/palmer/c/b09313dd2e72

Best regards,