| Message ID | 20230424134748.228137-1-james.clark@arm.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | perf: cs-etm: Fixes around timestamped and timeless decoding | expand |
Thanks James! Some of the patches failed to apply on ToT. Acked-by: Denis Nikitin <denik@chromium.org> - Denis On Mon, Apr 24, 2023 at 6:48 AM James Clark <james.clark@arm.com> wrote: > > The first commit contains a fix for a recently introduced regression, > but was always a shortcoming in the Coresight code anyway. > > The following commits are a tidyup in preparation for the last commit, > which is a fairly major change to the decode logic that's also > indirectly related to the regression so I thought it would be good time > to fix that now. > > Applies to perf/core (9be6ab181b7b) > > James Clark (7): > perf: cs-etm: Fix timeless decode mode detection > perf tools: Add util function for overriding user set config values > perf: cs-etm: Don't test full_auxtrace because it's always set > perf: cs-etm: Validate options after applying them > perf: cs-etm: Allow user to override timestamp and contextid settings > perf: cs-etm: Use bool type for boolean values > perf: cs-etm: Add separate decode paths for timeless and per-thread > modes > > tools/perf/arch/arm/util/cs-etm.c | 223 +++++++++--------- > tools/perf/arch/arm/util/pmu.c | 2 + > tools/perf/arch/arm64/util/arm-spe.c | 26 +- > tools/perf/arch/x86/util/intel-pt.c | 22 +- > tools/perf/tests/shell/test_arm_coresight.sh | 24 ++ > .../perf/util/cs-etm-decoder/cs-etm-decoder.h | 8 +- > tools/perf/util/cs-etm.c | 200 +++++++++++----- > tools/perf/util/cs-etm.h | 6 +- > tools/perf/util/evsel.c | 29 +++ > tools/perf/util/evsel.h | 3 + > 10 files changed, 325 insertions(+), 218 deletions(-) > > -- > 2.34.1 > > _______________________________________________ > CoreSight mailing list -- coresight@lists.linaro.org > To unsubscribe send an email to coresight-leave@lists.linaro.org
On Mon, Apr 24, 2023 at 6:48 AM James Clark <james.clark@arm.com> wrote: > > The first commit contains a fix for a recently introduced regression, > but was always a shortcoming in the Coresight code anyway. > > The following commits are a tidyup in preparation for the last commit, > which is a fairly major change to the decode logic that's also > indirectly related to the regression so I thought it would be good time > to fix that now. > > Applies to perf/core (9be6ab181b7b) Thanks for working on this. I tested with perf/core branch on acme tree, it does solve the "no samples" problem. Please feel free to add: Tested-by: Yang Shi <shy828301@gmail.com> > > James Clark (7): > perf: cs-etm: Fix timeless decode mode detection > perf tools: Add util function for overriding user set config values > perf: cs-etm: Don't test full_auxtrace because it's always set > perf: cs-etm: Validate options after applying them > perf: cs-etm: Allow user to override timestamp and contextid settings > perf: cs-etm: Use bool type for boolean values > perf: cs-etm: Add separate decode paths for timeless and per-thread > modes > > tools/perf/arch/arm/util/cs-etm.c | 223 +++++++++--------- > tools/perf/arch/arm/util/pmu.c | 2 + > tools/perf/arch/arm64/util/arm-spe.c | 26 +- > tools/perf/arch/x86/util/intel-pt.c | 22 +- > tools/perf/tests/shell/test_arm_coresight.sh | 24 ++ > .../perf/util/cs-etm-decoder/cs-etm-decoder.h | 8 +- > tools/perf/util/cs-etm.c | 200 +++++++++++----- > tools/perf/util/cs-etm.h | 6 +- > tools/perf/util/evsel.c | 29 +++ > tools/perf/util/evsel.h | 3 + > 10 files changed, 325 insertions(+), 218 deletions(-) > > -- > 2.34.1 >
The first commit contains a fix for a recently introduced regression, but was always a shortcoming in the Coresight code anyway. The following commits are a tidyup in preparation for the last commit, which is a fairly major change to the decode logic that's also indirectly related to the regression so I thought it would be good time to fix that now. Applies to perf/core (9be6ab181b7b) James Clark (7): perf: cs-etm: Fix timeless decode mode detection perf tools: Add util function for overriding user set config values perf: cs-etm: Don't test full_auxtrace because it's always set perf: cs-etm: Validate options after applying them perf: cs-etm: Allow user to override timestamp and contextid settings perf: cs-etm: Use bool type for boolean values perf: cs-etm: Add separate decode paths for timeless and per-thread modes tools/perf/arch/arm/util/cs-etm.c | 223 +++++++++--------- tools/perf/arch/arm/util/pmu.c | 2 + tools/perf/arch/arm64/util/arm-spe.c | 26 +- tools/perf/arch/x86/util/intel-pt.c | 22 +- tools/perf/tests/shell/test_arm_coresight.sh | 24 ++ .../perf/util/cs-etm-decoder/cs-etm-decoder.h | 8 +- tools/perf/util/cs-etm.c | 200 +++++++++++----- tools/perf/util/cs-etm.h | 6 +- tools/perf/util/evsel.c | 29 +++ tools/perf/util/evsel.h | 3 + 10 files changed, 325 insertions(+), 218 deletions(-)