diff mbox series

[kvm-unit-tests,v8,1/2] s390x: topology: Check the Perform Topology Function

Message ID 20230426083426.6806-2-pmorel@linux.ibm.com (mailing list archive)
State New, archived
Headers show
Series S390x: CPU Topology Information | expand

Commit Message

Pierre Morel April 26, 2023, 8:34 a.m. UTC
We check that the PTF instruction is working correctly when
the cpu topology facility is available.

For KVM only, we test changing of the polarity between horizontal
and vertical and that a reset set the horizontal polarity.

Signed-off-by: Pierre Morel <pmorel@linux.ibm.com>
---
 s390x/Makefile      |   1 +
 s390x/topology.c    | 191 ++++++++++++++++++++++++++++++++++++++++++++
 s390x/unittests.cfg |   3 +
 3 files changed, 195 insertions(+)
 create mode 100644 s390x/topology.c

Comments

Nico Boehr April 27, 2023, 6:57 a.m. UTC | #1
Quoting Pierre Morel (2023-04-26 10:34:25)
[...]
> diff --git a/s390x/topology.c b/s390x/topology.c
> new file mode 100644
> index 0000000..07f1650
> --- /dev/null
> +++ b/s390x/topology.c
> @@ -0,0 +1,191 @@
[...]
> +#define PTF_INVALID_FUNCTION   0xff

No longer used?

[...]
> +static void check_specifications(void)
> +{
> +       unsigned long wrong_bits = 0;
> +       unsigned long ptf_bits;
> +       unsigned long rc;
> +       int i;
> +
> +       report_prefix_push("Specifications");
> +
> +       /* Function codes above 3 are undefined */
> +       for (i = 4; i < 255; i++) {
> +               expect_pgm_int();
> +               ptf(i, &rc);
> +               mb();
> +               if (lowcore.pgm_int_code != PGM_INT_CODE_SPECIFICATION) {

Please use clear_pgm_int(), the return value will be the interruption code. You can also get rid of the barrier then.

Also, using wrong_bits is confusing here since it serves a completely different purpose below.

Maybe just:

if (clear_pgm_int() != PGM_INT_CODE_SPECIFICATION)
    report_fail("FC %d did not yield specification exception", i);

[...]
> +       /* Reserved bits must be 0 */
> +       for (i = 8, wrong_bits = 0; i < 64; i++) {
> +               ptf_bits = 0x01UL << i;
> +               expect_pgm_int();
> +               ptf(ptf_bits, &rc);
> +               mb();
> +               if (lowcore.pgm_int_code != PGM_INT_CODE_SPECIFICATION)

Also use clear_pgm_int() here.
Pierre Morel April 27, 2023, 8:18 a.m. UTC | #2
On 4/27/23 08:57, Nico Boehr wrote:
> Quoting Pierre Morel (2023-04-26 10:34:25)
> [...]
>> diff --git a/s390x/topology.c b/s390x/topology.c
>> new file mode 100644
>> index 0000000..07f1650
>> --- /dev/null
>> +++ b/s390x/topology.c
>> @@ -0,0 +1,191 @@
> [...]
>> +#define PTF_INVALID_FUNCTION   0xff
> No longer used?


right


>
> [...]
>> +static void check_specifications(void)
>> +{
>> +       unsigned long wrong_bits = 0;
>> +       unsigned long ptf_bits;
>> +       unsigned long rc;
>> +       int i;
>> +
>> +       report_prefix_push("Specifications");
>> +
>> +       /* Function codes above 3 are undefined */
>> +       for (i = 4; i < 255; i++) {
>> +               expect_pgm_int();
>> +               ptf(i, &rc);
>> +               mb();
>> +               if (lowcore.pgm_int_code != PGM_INT_CODE_SPECIFICATION) {
> Please use clear_pgm_int(), the return value will be the interruption code. You can also get rid of the barrier then.
>
> Also, using wrong_bits is confusing here since it serves a completely different purpose below.
>
> Maybe just:
>
> if (clear_pgm_int() != PGM_INT_CODE_SPECIFICATION)
>      report_fail("FC %d did not yield specification exception", i);

OK, thanks,


>
> [...]
>> +       /* Reserved bits must be 0 */
>> +       for (i = 8, wrong_bits = 0; i < 64; i++) {
>> +               ptf_bits = 0x01UL << i;
>> +               expect_pgm_int();
>> +               ptf(ptf_bits, &rc);
>> +               mb();
>> +               if (lowcore.pgm_int_code != PGM_INT_CODE_SPECIFICATION)
> Also use clear_pgm_int() here.


OK, too, thanks


Regards,

Pierre
diff mbox series

Patch

diff --git a/s390x/Makefile b/s390x/Makefile
index a80db53..fe77b07 100644
--- a/s390x/Makefile
+++ b/s390x/Makefile
@@ -40,6 +40,7 @@  tests += $(TEST_DIR)/panic-loop-pgm.elf
 tests += $(TEST_DIR)/migration-sck.elf
 tests += $(TEST_DIR)/exittime.elf
 tests += $(TEST_DIR)/ex.elf
+tests += $(TEST_DIR)/topology.elf
 
 pv-tests += $(TEST_DIR)/pv-diags.elf
 
diff --git a/s390x/topology.c b/s390x/topology.c
new file mode 100644
index 0000000..07f1650
--- /dev/null
+++ b/s390x/topology.c
@@ -0,0 +1,191 @@ 
+/* SPDX-License-Identifier: GPL-2.0-only */
+/*
+ * CPU Topology
+ *
+ * Copyright IBM Corp. 2022
+ *
+ * Authors:
+ *  Pierre Morel <pmorel@linux.ibm.com>
+ */
+
+#include <libcflat.h>
+#include <asm/page.h>
+#include <asm/asm-offsets.h>
+#include <asm/interrupt.h>
+#include <asm/facility.h>
+#include <asm/barrier.h>
+#include <smp.h>
+#include <sclp.h>
+#include <s390x/hardware.h>
+
+#define PTF_REQ_HORIZONTAL	0
+#define PTF_REQ_VERTICAL	1
+#define PTF_CHECK		2
+#define PTF_INVALID_FUNCTION	0xff
+
+#define PTF_ERR_NO_REASON	0
+#define PTF_ERR_ALRDY_POLARIZED	1
+#define PTF_ERR_IN_PROGRESS	2
+
+extern int diag308_load_reset(u64);
+
+static int ptf(unsigned long fc, unsigned long *rc)
+{
+	int cc;
+
+	asm volatile(
+		"	ptf	%1	\n"
+		"       ipm     %0	\n"
+		"       srl     %0,28	\n"
+		: "=d" (cc), "+d" (fc)
+		:
+		: "cc");
+
+	*rc = fc >> 8;
+	return cc;
+}
+
+static void check_privilege(int fc)
+{
+	unsigned long rc;
+
+	report_prefix_push("Privilege");
+	report_info("function code %d", fc);
+	enter_pstate();
+	expect_pgm_int();
+	ptf(fc, &rc);
+	check_pgm_int_code(PGM_INT_CODE_PRIVILEGED_OPERATION);
+	report_prefix_pop();
+}
+
+static void check_specifications(void)
+{
+	unsigned long wrong_bits = 0;
+	unsigned long ptf_bits;
+	unsigned long rc;
+	int i;
+
+	report_prefix_push("Specifications");
+
+	/* Function codes above 3 are undefined */
+	for (i = 4; i < 255; i++) {
+		expect_pgm_int();
+		ptf(i, &rc);
+		mb();
+		if (lowcore.pgm_int_code != PGM_INT_CODE_SPECIFICATION) {
+			report_info("Undefined %d", i);
+			wrong_bits = 1;
+		}
+	}
+
+	report(!wrong_bits, "Undefined function codes");
+
+	/* Reserved bits must be 0 */
+	for (i = 8, wrong_bits = 0; i < 64; i++) {
+		ptf_bits = 0x01UL << i;
+		expect_pgm_int();
+		ptf(ptf_bits, &rc);
+		mb();
+		if (lowcore.pgm_int_code != PGM_INT_CODE_SPECIFICATION)
+			wrong_bits |= ptf_bits;
+	}
+
+	report(!wrong_bits, "Reserved bits: 0x%016lx", wrong_bits);
+
+	report_prefix_pop();
+}
+
+static void check_polarization_change(void)
+{
+	unsigned long rc;
+	int cc;
+
+	report_prefix_push("Polarization change");
+
+	/* We expect a clean state through reset */
+	report(diag308_load_reset(1), "load normal reset done");
+
+	/*
+	 * Set vertical polarization to verify that RESET sets
+	 * horizontal polarization back.
+	 */
+	cc = ptf(PTF_REQ_VERTICAL, &rc);
+	report(cc == 0, "Set vertical polarization.");
+
+	report(diag308_load_reset(1), "load normal reset done");
+
+	cc = ptf(PTF_CHECK, &rc);
+	report(cc == 0, "Reset should clear topology report");
+
+	cc = ptf(PTF_REQ_HORIZONTAL, &rc);
+	report(cc == 2 && rc == PTF_ERR_ALRDY_POLARIZED,
+	       "After RESET polarization is horizontal");
+
+	/* Flip between vertical and horizontal polarization */
+	cc = ptf(PTF_REQ_VERTICAL, &rc);
+	report(cc == 0, "Change to vertical");
+
+	cc = ptf(PTF_CHECK, &rc);
+	report(cc == 1, "Should report");
+
+	cc = ptf(PTF_REQ_VERTICAL, &rc);
+	report(cc == 2 && rc == PTF_ERR_ALRDY_POLARIZED, "Double change to vertical");
+
+	cc = ptf(PTF_CHECK, &rc);
+	report(cc == 0, "Should not report");
+
+	cc = ptf(PTF_REQ_HORIZONTAL, &rc);
+	report(cc == 0, "Change to horizontal");
+
+	cc = ptf(PTF_CHECK, &rc);
+	report(cc == 1, "Should Report");
+
+	cc = ptf(PTF_REQ_HORIZONTAL, &rc);
+	report(cc == 2 && rc == PTF_ERR_ALRDY_POLARIZED, "Double change to horizontal");
+
+	cc = ptf(PTF_CHECK, &rc);
+	report(cc == 0, "Should not report");
+
+	report_prefix_pop();
+}
+
+static void test_ptf(void)
+{
+	check_privilege(PTF_REQ_HORIZONTAL);
+	check_privilege(PTF_REQ_VERTICAL);
+	check_privilege(PTF_CHECK);
+	check_specifications();
+	check_polarization_change();
+}
+
+static struct {
+	const char *name;
+	void (*func)(void);
+} tests[] = {
+	{ "PTF", test_ptf },
+	{ NULL, NULL }
+};
+
+int main(int argc, char *argv[])
+{
+	int i;
+
+	report_prefix_push("CPU Topology");
+
+	if (!test_facility(11)) {
+		report_skip("Topology facility not present");
+		goto end;
+	}
+
+	report_info("Virtual machine level %ld", stsi_get_fc());
+
+	for (i = 0; tests[i].name; i++) {
+		report_prefix_push(tests[i].name);
+		tests[i].func();
+		report_prefix_pop();
+	}
+
+end:
+	report_prefix_pop();
+	return report_summary();
+}
diff --git a/s390x/unittests.cfg b/s390x/unittests.cfg
index b61faf0..fc3666b 100644
--- a/s390x/unittests.cfg
+++ b/s390x/unittests.cfg
@@ -218,3 +218,6 @@  extra_params = -append '--parallel'
 
 [execute]
 file = ex.elf
+
+[topology]
+file = topology.elf