| Message ID | 20230505113856.463650-22-s.hauer@pengutronix.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add perf support to the rockchip-dfi driver | expand |
On 05/05/2023 13:38, Sascha Hauer wrote: > Convert the Rockchip DFI binding to yaml. While at it add the newly > supported rk3568-dfi to the binding. > > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel. You missed at least DT list (maybe more), so this won't be tested. Please resend and include all necessary entries. > --- > .../bindings/devfreq/event/rockchip-dfi.txt | 18 --------- > .../bindings/devfreq/event/rockchip-dfi.yaml | 39 +++++++++++++++++++ Filename matching compatibles style. > 2 files changed, 39 insertions(+), 18 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.txt > create mode 100644 Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.yaml > > diff --git a/Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.txt b/Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.txt > deleted file mode 100644 > index 148191b0fc158..0000000000000 > --- a/Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.txt > +++ /dev/null > @@ -1,18 +0,0 @@ > - > -* Rockchip rk3399 DFI device > - > -Required properties: > -- compatible: Must be "rockchip,rk3399-dfi". > -- reg: physical base address of each DFI and length of memory mapped region > -- rockchip,pmu: phandle to the syscon managing the "pmu general register files" > -- clocks: phandles for clock specified in "clock-names" property > -- clock-names : the name of clock used by the DFI, must be "pclk_ddr_mon"; > - > -Example: > - dfi: dfi@ff630000 { > - compatible = "rockchip,rk3399-dfi"; > - reg = <0x00 0xff630000 0x00 0x4000>; > - rockchip,pmu = <&pmugrf>; > - clocks = <&cru PCLK_DDR_MON>; > - clock-names = "pclk_ddr_mon"; > - }; > diff --git a/Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.yaml b/Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.yaml > new file mode 100644 > index 0000000000000..c0ef02a2d262b > --- /dev/null > +++ b/Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.yaml > @@ -0,0 +1,39 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/devfreq/event/rockchip-dfi.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Rockchip DFI > + > +maintainers: > + - Sascha Hauer <s.hauer@pengutronix.de> > + > +properties: > + compatible: > + enum: > + - rk3399-dfi > + - rk3568-dfi > + - rk3588-dfi These are not real compatibles. Does not look like you tested the bindings. Please run `make dt_binding_check` (see Documentation/devicetree/bindings/writing-schema.rst for instructions). Best regards, Krzysztof
On 05/05/2023 18:29, Krzysztof Kozlowski wrote: > On 05/05/2023 13:38, Sascha Hauer wrote: >> Convert the Rockchip DFI binding to yaml. While at it add the newly >> supported rk3568-dfi to the binding. >> >> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> > > Please use scripts/get_maintainers.pl to get a list of necessary people > and lists to CC. It might happen, that command when run on an older > kernel, gives you outdated entries. Therefore please be sure you base > your patches on recent Linux kernel. > > You missed at least DT list (maybe more), so this won't be tested. > Please resend and include all necessary entries. > Actually you already got such comments and nothing improved here. You just resend same patch with same bugs. This is a waste of our time. Ignoring output of maintainers means there is no testing and the patch does not appear in the inboxes. I don't understand why you insist on ignoring that output. NAK. Best regards, Krzysztof
On Fri, May 05, 2023 at 06:31:35PM +0200, Krzysztof Kozlowski wrote: > On 05/05/2023 18:29, Krzysztof Kozlowski wrote: > > On 05/05/2023 13:38, Sascha Hauer wrote: > >> Convert the Rockchip DFI binding to yaml. While at it add the newly > >> supported rk3568-dfi to the binding. > >> > >> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> > > > > Please use scripts/get_maintainers.pl to get a list of necessary people > > and lists to CC. It might happen, that command when run on an older > > kernel, gives you outdated entries. Therefore please be sure you base > > your patches on recent Linux kernel. > > > > You missed at least DT list (maybe more), so this won't be tested. > > Please resend and include all necessary entries. > > > > Actually you already got such comments and nothing improved here. You > just resend same patch with same bugs. > > This is a waste of our time. Ignoring output of maintainers means there > is no testing and the patch does not appear in the inboxes. > > I don't understand why you insist on ignoring that output. I skipped the device tree list because there was no change in the dts or binding part compared to the previous version. But ok, it's worse. I only *intended* to not change the dts/binding part. In fact I did, because the things you mentioned were already fixed in an earlier version and I indeed ran dtbs_check and dt_binding_check on this ealier version. Somehow old patches sneaked into this series. Sorry for that, I'll send a new version once I sorted this out. Sascha
On 09/05/2023 11:37, Sascha Hauer wrote: > On Fri, May 05, 2023 at 06:31:35PM +0200, Krzysztof Kozlowski wrote: >> On 05/05/2023 18:29, Krzysztof Kozlowski wrote: >>> On 05/05/2023 13:38, Sascha Hauer wrote: >>>> Convert the Rockchip DFI binding to yaml. While at it add the newly >>>> supported rk3568-dfi to the binding. >>>> >>>> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> >>> >>> Please use scripts/get_maintainers.pl to get a list of necessary people >>> and lists to CC. It might happen, that command when run on an older >>> kernel, gives you outdated entries. Therefore please be sure you base >>> your patches on recent Linux kernel. >>> >>> You missed at least DT list (maybe more), so this won't be tested. >>> Please resend and include all necessary entries. >>> >> >> Actually you already got such comments and nothing improved here. You >> just resend same patch with same bugs. >> >> This is a waste of our time. Ignoring output of maintainers means there >> is no testing and the patch does not appear in the inboxes. >> >> I don't understand why you insist on ignoring that output. > > I skipped the device tree list because there was no change in the dts or > binding part compared to the previous version. Please always CC DT list and all maintainers. Just because something did not change here, does not mean that nothing changed elsewhere, e.g. in dependant schemas. What's more, the binding should have changed because I asked to fix several things. > > But ok, it's worse. I only *intended* to not change the dts/binding > part. In fact I did, because the things you mentioned were already fixed > in an earlier version and I indeed ran dtbs_check and dt_binding_check on > this ealier version. > > Somehow old patches sneaked into this series. Sorry for that, I'll send > a new version once I sorted this out. > > Sascha > Best regards, Krzysztof
On Tue, May 09, 2023 at 11:40:26AM +0200, Krzysztof Kozlowski wrote: > On 09/05/2023 11:37, Sascha Hauer wrote: > > On Fri, May 05, 2023 at 06:31:35PM +0200, Krzysztof Kozlowski wrote: > >> On 05/05/2023 18:29, Krzysztof Kozlowski wrote: > >>> On 05/05/2023 13:38, Sascha Hauer wrote: > >>>> Convert the Rockchip DFI binding to yaml. While at it add the newly > >>>> supported rk3568-dfi to the binding. > >>>> > >>>> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> > >>> > >>> Please use scripts/get_maintainers.pl to get a list of necessary people > >>> and lists to CC. It might happen, that command when run on an older > >>> kernel, gives you outdated entries. Therefore please be sure you base > >>> your patches on recent Linux kernel. > >>> > >>> You missed at least DT list (maybe more), so this won't be tested. > >>> Please resend and include all necessary entries. > >>> > >> > >> Actually you already got such comments and nothing improved here. You > >> just resend same patch with same bugs. > >> > >> This is a waste of our time. Ignoring output of maintainers means there > >> is no testing and the patch does not appear in the inboxes. > >> > >> I don't understand why you insist on ignoring that output. > > > > I skipped the device tree list because there was no change in the dts or > > binding part compared to the previous version. > > Please always CC DT list and all maintainers. Just because something did > not change here, does not mean that nothing changed elsewhere, e.g. in > dependant schemas. Ok. > > What's more, the binding should have changed because I asked to fix > several things. You commented on v1 of this series and the things you mentioned were fixed in v2 and v3. It's v4 where I lost them. Sascha
diff --git a/Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.txt b/Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.txt deleted file mode 100644 index 148191b0fc158..0000000000000 --- a/Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.txt +++ /dev/null @@ -1,18 +0,0 @@ - -* Rockchip rk3399 DFI device - -Required properties: -- compatible: Must be "rockchip,rk3399-dfi". -- reg: physical base address of each DFI and length of memory mapped region -- rockchip,pmu: phandle to the syscon managing the "pmu general register files" -- clocks: phandles for clock specified in "clock-names" property -- clock-names : the name of clock used by the DFI, must be "pclk_ddr_mon"; - -Example: - dfi: dfi@ff630000 { - compatible = "rockchip,rk3399-dfi"; - reg = <0x00 0xff630000 0x00 0x4000>; - rockchip,pmu = <&pmugrf>; - clocks = <&cru PCLK_DDR_MON>; - clock-names = "pclk_ddr_mon"; - }; diff --git a/Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.yaml b/Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.yaml new file mode 100644 index 0000000000000..c0ef02a2d262b --- /dev/null +++ b/Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.yaml @@ -0,0 +1,39 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/devfreq/event/rockchip-dfi.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Rockchip DFI + +maintainers: + - Sascha Hauer <s.hauer@pengutronix.de> + +properties: + compatible: + enum: + - rk3399-dfi + - rk3568-dfi + - rk3588-dfi + + clocks: + maxItems: 1 + + rockchip,pmu: + $ref: /schemas/types.yaml#/definitions/phandle + description: + Phandle to the syscon managing the "PMU general register files". + +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + dfi: dfi@fe230000 { + compatible = "rockchip,rk3568-dfi"; + reg = <0x00 0xfe230000 0x00 0x400>; + rockchip,pmu = <&pmugrf>; + };
Convert the Rockchip DFI binding to yaml. While at it add the newly supported rk3568-dfi to the binding. Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> --- .../bindings/devfreq/event/rockchip-dfi.txt | 18 --------- .../bindings/devfreq/event/rockchip-dfi.yaml | 39 +++++++++++++++++++ 2 files changed, 39 insertions(+), 18 deletions(-) delete mode 100644 Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.txt create mode 100644 Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.yaml