| Message ID | 20230505101246.289278-1-haibo.chen@nxp.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | None | expand |
On 05/05/2023 12:12, haibo.chen@nxp.com wrote: > From: Haibo Chen <haibo.chen@nxp.com> > > Driver do not use this property, so remove it here. That's not true, it uses. I got only patch #3 and nothing else. > > Signed-off-by: Haibo Chen <haibo.chen@nxp.com> > --- > Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml | 6 ------ > 1 file changed, 6 deletions(-) Best regards, Krzysztof
> -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Sent: 2023年5月6日 1:48 > To: Bough Chen <haibo.chen@nxp.com>; adrian.hunter@intel.com; > ulf.hansson@linaro.org; linux-mmc@vger.kernel.org; robh+dt@kernel.org; > krzysztof.kozlowski+dt@linaro.org; shawnguo@kernel.org; > s.hauer@pengutronix.de > Cc: dl-linux-imx <linux-imx@nxp.com>; kernel@pengutronix.de; > festevam@gmail.com; cniedermaier@dh-electronics.com; > devicetree@vger.kernel.org; kernel@dh-electronics.com > Subject: Re: [PATCH v2 3/4] dt-bindings: mmc: fsl-imx-esdhc: remove property > "fsl,wp-controller" > > On 05/05/2023 12:12, haibo.chen@nxp.com wrote: > > From: Haibo Chen <haibo.chen@nxp.com> > > > > Driver do not use this property, so remove it here. > > That's not true, it uses. I got only patch #3 and nothing else. This v2 patch only fix a dt-check error, for patch1,2,4, still not get comments, so I do not send out to avoid noise. Here is the patch to remove "fsl,wp-controller" in driver: https://patchwork.kernel.org/project/linux-mmc/patch/20230505084955.238940-2-haibo.chen@nxp.com/ Best Regards Haibo Chen > > > > > Signed-off-by: Haibo Chen <haibo.chen@nxp.com> > > --- > > Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml | 6 ------ > > 1 file changed, 6 deletions(-) > > > Best regards, > Krzysztof
On 06/05/2023 04:37, Bough Chen wrote: >> -----Original Message----- >> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> Sent: 2023年5月6日 1:48 >> To: Bough Chen <haibo.chen@nxp.com>; adrian.hunter@intel.com; >> ulf.hansson@linaro.org; linux-mmc@vger.kernel.org; robh+dt@kernel.org; >> krzysztof.kozlowski+dt@linaro.org; shawnguo@kernel.org; >> s.hauer@pengutronix.de >> Cc: dl-linux-imx <linux-imx@nxp.com>; kernel@pengutronix.de; >> festevam@gmail.com; cniedermaier@dh-electronics.com; >> devicetree@vger.kernel.org; kernel@dh-electronics.com >> Subject: Re: [PATCH v2 3/4] dt-bindings: mmc: fsl-imx-esdhc: remove property >> "fsl,wp-controller" >> >> On 05/05/2023 12:12, haibo.chen@nxp.com wrote: >>> From: Haibo Chen <haibo.chen@nxp.com> >>> >>> Driver do not use this property, so remove it here. >> >> That's not true, it uses. I got only patch #3 and nothing else. > > This v2 patch only fix a dt-check error, for patch1,2,4, still not get comments, so I do not send out to avoid noise. So while sending a patchset of 4 patches you skipped 1+2+4? This does not make sense. Send entire patchset. The patch by itself, without context, is incorrect and not justified. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml index fbfd822b9270..e34b4fb4778a 100644 --- a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml +++ b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml @@ -96,11 +96,6 @@ properties: interrupts: maxItems: 1 - fsl,wp-controller: - description: | - boolean, if present, indicate to use controller internal write protection. - type: boolean - fsl,delay-line: $ref: /schemas/types.yaml#/definitions/uint32 description: | @@ -190,7 +185,6 @@ examples: compatible = "fsl,imx51-esdhc"; reg = <0x70004000 0x4000>; interrupts = <1>; - fsl,wp-controller; }; mmc@70008000 {