| Message ID | 20230504235052.4423-5-bvanassche@acm.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | ufs: Do not requeue while ungating the clock | expand |
On 5/4/2023 4:50 PM, Bart Van Assche wrote: > Unexport these functions since these are only used by the UFS core. Hi Bart, Qualcomm uses these ufshcd_hold() and ufshcd_release() functions in ufs-qcom.c. I am going to post Qualcomm's change soon. Thanks, Bao > > Signed-off-by: Bart Van Assche <bvanassche@acm.org> > --- > drivers/ufs/core/ufshcd.c | 2 -- > include/ufs/ufshcd.h | 3 --- > 2 files changed, 5 deletions(-) > > diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c > index a1bce9c6aee5..54f91d7d0192 100644 > --- a/drivers/ufs/core/ufshcd.c > +++ b/drivers/ufs/core/ufshcd.c > @@ -1847,7 +1847,6 @@ int ufshcd_hold(struct ufs_hba *hba, bool async) > out: > return rc; > } > -EXPORT_SYMBOL_GPL(ufshcd_hold); > > static void ufshcd_gate_work(struct work_struct *work) > { > @@ -1950,7 +1949,6 @@ void ufshcd_release(struct ufs_hba *hba) > __ufshcd_release(hba); > spin_unlock_irqrestore(hba->host->host_lock, flags); > } > -EXPORT_SYMBOL_GPL(ufshcd_release); > > static ssize_t ufshcd_clkgate_delay_show(struct device *dev, > struct device_attribute *attr, char *buf) > diff --git a/include/ufs/ufshcd.h b/include/ufs/ufshcd.h > index d6da1efb0212..13824462452d 100644 > --- a/include/ufs/ufshcd.h > +++ b/include/ufs/ufshcd.h > @@ -1358,9 +1358,6 @@ void ufshcd_fixup_dev_quirks(struct ufs_hba *hba, > int ufshcd_read_string_desc(struct ufs_hba *hba, u8 desc_index, > u8 **buf, bool ascii); > > -int ufshcd_hold(struct ufs_hba *hba, bool async); > -void ufshcd_release(struct ufs_hba *hba); > - > void ufshcd_clkgate_delay_set(struct device *dev, unsigned long value); > > u32 ufshcd_get_local_unipro_ver(struct ufs_hba *hba);
On 5/5/23 11:40, Bao D. Nguyen wrote: > On 5/4/2023 4:50 PM, Bart Van Assche wrote: >> Unexport these functions since these are only used by the UFS core. > > Qualcomm uses these ufshcd_hold() and ufshcd_release() functions in ufs-qcom.c. I am going to post Qualcomm's change soon. Hi Bao, I will drop this patch. Does the code that you plan to post pass 'false' or 'true' as second argument to ufshcd_hold()? Thanks, Bart.
On 5/5/2023 12:00 PM, Bart Van Assche wrote: > On 5/5/23 11:40, Bao D. Nguyen wrote: >> On 5/4/2023 4:50 PM, Bart Van Assche wrote: >>> Unexport these functions since these are only used by the UFS core. >> >> Qualcomm uses these ufshcd_hold() and ufshcd_release() functions in >> ufs-qcom.c. I am going to post Qualcomm's change soon. > > Hi Bao, > > I will drop this patch. > > Does the code that you plan to post pass 'false' or 'true' as second > argument to ufshcd_hold()? Thanks Bart. We are using ufshcd_hold(hba, false); Thanks, Bao > > Thanks, > > Bart.
diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c index a1bce9c6aee5..54f91d7d0192 100644 --- a/drivers/ufs/core/ufshcd.c +++ b/drivers/ufs/core/ufshcd.c @@ -1847,7 +1847,6 @@ int ufshcd_hold(struct ufs_hba *hba, bool async) out: return rc; } -EXPORT_SYMBOL_GPL(ufshcd_hold); static void ufshcd_gate_work(struct work_struct *work) { @@ -1950,7 +1949,6 @@ void ufshcd_release(struct ufs_hba *hba) __ufshcd_release(hba); spin_unlock_irqrestore(hba->host->host_lock, flags); } -EXPORT_SYMBOL_GPL(ufshcd_release); static ssize_t ufshcd_clkgate_delay_show(struct device *dev, struct device_attribute *attr, char *buf) diff --git a/include/ufs/ufshcd.h b/include/ufs/ufshcd.h index d6da1efb0212..13824462452d 100644 --- a/include/ufs/ufshcd.h +++ b/include/ufs/ufshcd.h @@ -1358,9 +1358,6 @@ void ufshcd_fixup_dev_quirks(struct ufs_hba *hba, int ufshcd_read_string_desc(struct ufs_hba *hba, u8 desc_index, u8 **buf, bool ascii); -int ufshcd_hold(struct ufs_hba *hba, bool async); -void ufshcd_release(struct ufs_hba *hba); - void ufshcd_clkgate_delay_set(struct device *dev, unsigned long value); u32 ufshcd_get_local_unipro_ver(struct ufs_hba *hba);
Unexport these functions since these are only used by the UFS core. Signed-off-by: Bart Van Assche <bvanassche@acm.org> --- drivers/ufs/core/ufshcd.c | 2 -- include/ufs/ufshcd.h | 3 --- 2 files changed, 5 deletions(-)