| Message ID | 20230506094428.772239-1-yunchuan@nfschina.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net:ethernet:freescale:dpaa2:Remove unnecessary (void*) conversions | expand |
On Sat, May 06, 2023 at 05:44:28PM +0800, wuych wrote: > Pointer variables of void * type do not require type cast. > > Signed-off-by: wuych <yunchuan@nfschina.com> Hi, this looks good, but a few things to improve: * Did you miss the instance in dpaa2_dbg_bp_show() * For networking patches, please set the target tree in the subject. As this is not a fix it should be 'net-next' (if it was a fix it would be 'net') [PATCH net-next v2] ... * As per the form letter below, -net-next is currently closed, so please repost after May 8th. * I think the subject prefix should be dpaa2-eth: [PATCH net-next v2] dpaa2: ... * I think the patch subject could be a bit clearer [PATCH net-next v2] dpaa2: Remove unnecessary cast of void pointers Lastly, some text borrowed from others: ## Form letter - net-next-closed The merge window for v6.3 has begun and therefore net-next is closed for new drivers, features, code refactoring and optimizations. We are currently accepting bug fixes only. Please repost when net-next reopens after May 8th. RFC patches sent for review only are obviously welcome at any time. See: https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#development-cycle
On Sat, May 06, 2023 at 01:06:22PM +0200, Simon Horman wrote: > On Sat, May 06, 2023 at 05:44:28PM +0800, wuych wrote: > > Pointer variables of void * type do not require type cast. > > > > Signed-off-by: wuych <yunchuan@nfschina.com> > > Hi, > > this looks good, but a few things to improve: > > * Did you miss the instance in dpaa2_dbg_bp_show() > * For networking patches, please set the target tree in the subject. > As this is not a fix it should be 'net-next' (if it was a fix it would be > 'net') > [PATCH net-next v2] ... > * As per the form letter below, -net-next is currently closed, > so please repost after May 8th. > * I think the subject prefix should be dpaa2-eth: > [PATCH net-next v2] dpaa2: ... > * I think the patch subject could be a bit clearer > [PATCH net-next v2] dpaa2: Remove unnecessary cast of void pointers Plus, another thing to consider is to take seriously feedback for other patches https://lore.kernel.org/netdev/19409d2b4222b3a5c6fc0cedbfa7844b6eb3440f.camel@redhat.com/ Thanks
diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth-debugfs.c b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth-debugfs.c index 1af254caeb0d..7b2a3acd3211 100644 --- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth-debugfs.c +++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth-debugfs.c @@ -13,7 +13,7 @@ static struct dentry *dpaa2_dbg_root; static int dpaa2_dbg_cpu_show(struct seq_file *file, void *offset) { - struct dpaa2_eth_priv *priv = (struct dpaa2_eth_priv *)file->private; + struct dpaa2_eth_priv *priv = file->private; struct rtnl_link_stats64 *stats; struct dpaa2_eth_drv_stats *extras; int i; @@ -58,7 +58,7 @@ static char *fq_type_to_str(struct dpaa2_eth_fq *fq) static int dpaa2_dbg_fqs_show(struct seq_file *file, void *offset) { - struct dpaa2_eth_priv *priv = (struct dpaa2_eth_priv *)file->private; + struct dpaa2_eth_priv *priv = file->private; struct dpaa2_eth_fq *fq; u32 fcnt, bcnt; int i, err; @@ -93,7 +93,7 @@ DEFINE_SHOW_ATTRIBUTE(dpaa2_dbg_fqs); static int dpaa2_dbg_ch_show(struct seq_file *file, void *offset) { - struct dpaa2_eth_priv *priv = (struct dpaa2_eth_priv *)file->private; + struct dpaa2_eth_priv *priv = file->private; struct dpaa2_eth_channel *ch; int i;
Pointer variables of void * type do not require type cast. Signed-off-by: wuych <yunchuan@nfschina.com> --- drivers/net/ethernet/freescale/dpaa2/dpaa2-eth-debugfs.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)