| Message ID | 20230425065715.21871-5-chanh@os.amperecomputing.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Update the device tree for Ampere's Mt.Mitchell BMC | expand |
On Tue, 25 Apr 2023, at 16:27, Chanh Nguyen wrote: > Enable MCTP driver on I2C3 bus for MCTP transaction > > Signed-off-by: Chanh Nguyen <chanh@os.amperecomputing.com> > --- > arch/arm/boot/dts/aspeed-bmc-ampere-mtmitchell.dts | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/arm/boot/dts/aspeed-bmc-ampere-mtmitchell.dts > b/arch/arm/boot/dts/aspeed-bmc-ampere-mtmitchell.dts > index 0b5ea8620063..33e06eafed31 100644 > --- a/arch/arm/boot/dts/aspeed-bmc-ampere-mtmitchell.dts > +++ b/arch/arm/boot/dts/aspeed-bmc-ampere-mtmitchell.dts > @@ -366,6 +366,13 @@ > > &i2c3 { > status = "okay"; > + bus-frequency = <1000000>; > + multi-master; > + mctp-controller; > + mctp@10 { > + compatible = "mctp-i2c-controller"; > + reg = <0x10>; This needs to be `reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>;` Andrew
On 27/04/2023 08:04, Andrew Jeffery wrote: > > > On Tue, 25 Apr 2023, at 16:27, Chanh Nguyen wrote: >> Enable MCTP driver on I2C3 bus for MCTP transaction >> >> Signed-off-by: Chanh Nguyen <chanh@os.amperecomputing.com> >> --- >> arch/arm/boot/dts/aspeed-bmc-ampere-mtmitchell.dts | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/arch/arm/boot/dts/aspeed-bmc-ampere-mtmitchell.dts >> b/arch/arm/boot/dts/aspeed-bmc-ampere-mtmitchell.dts >> index 0b5ea8620063..33e06eafed31 100644 >> --- a/arch/arm/boot/dts/aspeed-bmc-ampere-mtmitchell.dts >> +++ b/arch/arm/boot/dts/aspeed-bmc-ampere-mtmitchell.dts >> @@ -366,6 +366,13 @@ >> >> &i2c3 { >> status = "okay"; >> + bus-frequency = <1000000>; >> + multi-master; >> + mctp-controller; >> + mctp@10 { >> + compatible = "mctp-i2c-controller"; >> + reg = <0x10>; > > This needs to be `reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>;` > > Andrew Thank Andrew, I will update that in PATCH v2.
diff --git a/arch/arm/boot/dts/aspeed-bmc-ampere-mtmitchell.dts b/arch/arm/boot/dts/aspeed-bmc-ampere-mtmitchell.dts index 0b5ea8620063..33e06eafed31 100644 --- a/arch/arm/boot/dts/aspeed-bmc-ampere-mtmitchell.dts +++ b/arch/arm/boot/dts/aspeed-bmc-ampere-mtmitchell.dts @@ -366,6 +366,13 @@ &i2c3 { status = "okay"; + bus-frequency = <1000000>; + multi-master; + mctp-controller; + mctp@10 { + compatible = "mctp-i2c-controller"; + reg = <0x10>; + }; }; &i2c4 {
Enable MCTP driver on I2C3 bus for MCTP transaction Signed-off-by: Chanh Nguyen <chanh@os.amperecomputing.com> --- arch/arm/boot/dts/aspeed-bmc-ampere-mtmitchell.dts | 7 +++++++ 1 file changed, 7 insertions(+)