| Message ID | 20230508-parisc-kexec-include-reboot-v1-1-78a155a8a0a4@kernel.org (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | parisc: kexec: include reboot.h | expand |
On 05/09/23 at 09:01am, Simon Horman wrote: > Include reboot.h in machine_kexec.c for declaration of > machine_crash_shutdown and machine_shutdown. > > gcc-12 with W=1 reports: > > arch/parisc/kernel/kexec.c:57:6: warning: no previous prototype for 'machine_crash_shutdown' [-Wmissing-prototypes] > 57 | void machine_crash_shutdown(struct pt_regs *regs) > | ^~~~~~~~~~~~~~~~~~~~~~ > arch/parisc/kernel/kexec.c:61:6: warning: no previous prototype for 'machine_shutdown' [-Wmissing-prototypes] > 61 | void machine_shutdown(void) > | ^~~~~~~~~~~~~~~~ > > No functional changes intended. > Compile tested only. > > Signed-off-by: Simon Horman <horms@kernel.org> Acked-by: Baoquan He <bhe@redhat.com> We may need to find out the places in all architectures and fix all of them. > --- > arch/parisc/kernel/kexec.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/parisc/kernel/kexec.c b/arch/parisc/kernel/kexec.c > index 5eb7f30edc1f..db57345a9daf 100644 > --- a/arch/parisc/kernel/kexec.c > +++ b/arch/parisc/kernel/kexec.c > @@ -4,6 +4,8 @@ > #include <linux/console.h> > #include <linux/kexec.h> > #include <linux/delay.h> > +#include <linux/reboot.h> > + > #include <asm/cacheflush.h> > #include <asm/sections.h> > >
On Tue, May 09, 2023 at 05:01:42PM +0800, Baoquan He wrote: > On 05/09/23 at 09:01am, Simon Horman wrote: > > Include reboot.h in machine_kexec.c for declaration of > > machine_crash_shutdown and machine_shutdown. > > > > gcc-12 with W=1 reports: > > > > arch/parisc/kernel/kexec.c:57:6: warning: no previous prototype for 'machine_crash_shutdown' [-Wmissing-prototypes] > > 57 | void machine_crash_shutdown(struct pt_regs *regs) > > | ^~~~~~~~~~~~~~~~~~~~~~ > > arch/parisc/kernel/kexec.c:61:6: warning: no previous prototype for 'machine_shutdown' [-Wmissing-prototypes] > > 61 | void machine_shutdown(void) > > | ^~~~~~~~~~~~~~~~ > > > > No functional changes intended. > > Compile tested only. > > > > Signed-off-by: Simon Horman <horms@kernel.org> > > Acked-by: Baoquan He <bhe@redhat.com> > > We may need to find out the places in all architectures and fix all of > them. I did check. It seemed to be needed for riscv, m68k and parisc. I've sent out patches for all three. But I may have missed something.
On 5/9/23 13:52, Simon Horman wrote: > On Tue, May 09, 2023 at 05:01:42PM +0800, Baoquan He wrote: >> On 05/09/23 at 09:01am, Simon Horman wrote: >>> Include reboot.h in machine_kexec.c for declaration of >>> machine_crash_shutdown and machine_shutdown. >>> >>> gcc-12 with W=1 reports: >>> >>> arch/parisc/kernel/kexec.c:57:6: warning: no previous prototype for 'machine_crash_shutdown' [-Wmissing-prototypes] >>> 57 | void machine_crash_shutdown(struct pt_regs *regs) >>> | ^~~~~~~~~~~~~~~~~~~~~~ >>> arch/parisc/kernel/kexec.c:61:6: warning: no previous prototype for 'machine_shutdown' [-Wmissing-prototypes] >>> 61 | void machine_shutdown(void) >>> | ^~~~~~~~~~~~~~~~ >>> >>> No functional changes intended. >>> Compile tested only. >>> >>> Signed-off-by: Simon Horman <horms@kernel.org> >> >> Acked-by: Baoquan He <bhe@redhat.com> applied to parisc for-next git tree. Thanks! Helge
On 05/09/23 at 01:52pm, Simon Horman wrote: > On Tue, May 09, 2023 at 05:01:42PM +0800, Baoquan He wrote: > > On 05/09/23 at 09:01am, Simon Horman wrote: > > > Include reboot.h in machine_kexec.c for declaration of > > > machine_crash_shutdown and machine_shutdown. > > > > > > gcc-12 with W=1 reports: > > > > > > arch/parisc/kernel/kexec.c:57:6: warning: no previous prototype for 'machine_crash_shutdown' [-Wmissing-prototypes] > > > 57 | void machine_crash_shutdown(struct pt_regs *regs) > > > | ^~~~~~~~~~~~~~~~~~~~~~ > > > arch/parisc/kernel/kexec.c:61:6: warning: no previous prototype for 'machine_shutdown' [-Wmissing-prototypes] > > > 61 | void machine_shutdown(void) > > > | ^~~~~~~~~~~~~~~~ > > > > > > No functional changes intended. > > > Compile tested only. > > > > > > Signed-off-by: Simon Horman <horms@kernel.org> > > > > Acked-by: Baoquan He <bhe@redhat.com> > > > > We may need to find out the places in all architectures and fix all of > > them. > > I did check. It seemed to be needed for riscv, m68k and parisc. > I've sent out patches for all three. But I may have missed something. That's great, thanks. I didn't notice the other two.
diff --git a/arch/parisc/kernel/kexec.c b/arch/parisc/kernel/kexec.c index 5eb7f30edc1f..db57345a9daf 100644 --- a/arch/parisc/kernel/kexec.c +++ b/arch/parisc/kernel/kexec.c @@ -4,6 +4,8 @@ #include <linux/console.h> #include <linux/kexec.h> #include <linux/delay.h> +#include <linux/reboot.h> + #include <asm/cacheflush.h> #include <asm/sections.h>
Include reboot.h in machine_kexec.c for declaration of machine_crash_shutdown and machine_shutdown. gcc-12 with W=1 reports: arch/parisc/kernel/kexec.c:57:6: warning: no previous prototype for 'machine_crash_shutdown' [-Wmissing-prototypes] 57 | void machine_crash_shutdown(struct pt_regs *regs) | ^~~~~~~~~~~~~~~~~~~~~~ arch/parisc/kernel/kexec.c:61:6: warning: no previous prototype for 'machine_shutdown' [-Wmissing-prototypes] 61 | void machine_shutdown(void) | ^~~~~~~~~~~~~~~~ No functional changes intended. Compile tested only. Signed-off-by: Simon Horman <horms@kernel.org> --- arch/parisc/kernel/kexec.c | 2 ++ 1 file changed, 2 insertions(+)